Skip to content

Commit eb05e25

Browse files
committed
Renamed signTransactionWithCosignedTransactions to eliminate confusions
1 parent e1a36d2 commit eb05e25

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/model/transaction/AggregateTransaction.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,11 @@ export class AggregateTransaction extends Transaction {
152152
* @param {CosignatureSignedTransaction[]} cosignatureSignedTransaction - Array of cosigned transaction
153153
* @return {SignedTransaction}
154154
*/
155-
public signTransactionWithCosignedTransactions(initiatorAccount: Account,
156-
cosignatureSignedTransaction: CosignatureSignedTransaction[]) {
155+
public signTransactionGivenSignatures(initiatorAccount: Account,
156+
cosignatureSignedTransaction: CosignatureSignedTransaction[]) {
157157
const aggregateTransaction = this.buildTransaction();
158-
const signedTransactionRaw = aggregateTransaction.signTransactionWithCosignedTransactions(initiatorAccount,
159-
cosignatureSignedTransaction);
158+
const signedTransactionRaw = aggregateTransaction.signTransactionGivenSignatures(initiatorAccount,
159+
cosignatureSignedTransaction);
160160
return new SignedTransaction(signedTransactionRaw.payload, signedTransactionRaw.hash, initiatorAccount.publicKey,
161161
this.type, this.networkType);
162162
}

test/model/transaction/AggregateTransaction.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ describe('AggregateTransaction', () => {
438438

439439
const recreatedTx = TransactionMapping.createFromPayload(aggregateTransactionPayload) as AggregateTransaction;
440440

441-
const signedTransaction = recreatedTx.signTransactionWithCosignedTransactions(accountAlice, cosignatureSignedTransactions);
441+
const signedTransaction = recreatedTx.signTransactionGivenSignatures(accountAlice, cosignatureSignedTransactions);
442442

443443
expect(signedTransaction.type).to.be.equal(TransactionType.AGGREGATE_COMPLETE);
444444
expect(signedTransaction.signer).to.be.equal(accountAlice.publicKey);

0 commit comments

Comments
 (0)