Improved e2e test

Author: fboucquez

e2e/infrastructure/MosaicHttp.spec.ts

@@ -66,7 +66,7 @@ describe('MosaicHttp', () => {
     describe('Setup test MosaicId', () => {
 
         it('Announce MosaicDefinitionTransaction', async () => {
-            const nonce = MosaicNonce.createFromUint8Array(new Uint8Array([255, 255, 255, 255]));
+            const nonce = MosaicNonce.createFromUint8Array(new Uint8Array([200, 255, 255, 255]));
             mosaicId = MosaicId.createFromNonce(nonce, account.publicAccount);
             const mosaicDefinitionTransaction = MosaicDefinitionTransaction.create(
                 Deadline.create(),
@@ -84,6 +84,11 @@ describe('MosaicHttp', () => {
             expect(mosaicDefinitionTransaction.nonce.toHex()).to.be.equal(listenedTransaction.nonce.toHex());
             expect(mosaicDefinitionTransaction.nonce).to.deep.equal(listenedTransaction.nonce);
             expect(mosaicDefinitionTransaction.getMosaicNonceIntValue()).to.be.equal(listenedTransaction.getMosaicNonceIntValue());
+
+            const savedTransaction = await helper.repositoryFactory.createTransactionRepository().getTransaction(signedTransaction.hash).toPromise() as MosaicDefinitionTransaction;
+            expect(mosaicDefinitionTransaction.nonce.toHex()).to.be.equal(savedTransaction.nonce.toHex());
+            expect(mosaicDefinitionTransaction.nonce).to.deep.equal(savedTransaction.nonce);
+            expect(mosaicDefinitionTransaction.getMosaicNonceIntValue()).to.be.equal(savedTransaction.getMosaicNonceIntValue());
         });
     });
 

test/core/format/Convert.spec.ts

@@ -405,13 +405,26 @@ describe('convert', () => {
 
     describe('uint8ToNumber', () => {
         it('should convert to number and back', () => {
-            const expected = 123456789;
-            const array = convert.numberToUint8Array(expected, 4);
+            const input = 123456789;
+            const array = convert.numberToUint8Array(input, 4);
             // Act:
             const result = convert.uintArray8ToNumber(array);
 
             // Assert:
-            expect(result).to.be.equal(expected);
+            expect(result).to.be.equal(input);
+        });
+    });
+
+    describe('uint8ToNumber', () => {
+        it('should convert to number and back when negative', () => {
+            const input = 123456789 >> (Number.MAX_SAFE_INTEGER);
+            const array = convert.numberToUint8Array(input, 4);
+            // Act:
+            const result = convert.uintArray8ToNumber(array);
+
+            // Assert:
+            expect(result).to.be.equal(123456789);
+            expect(input).to.be.equal(123456789);
         });
     });