Fixed issue on mosaic array sorting

Use Long to compare unsigned mosaicId
Fixed issue on Uint64.toString issue (use long instead)

Author: rg911

src/model/UInt64.ts

@@ -116,7 +116,7 @@ export class UInt64 {
      * @return {string}
      */
     public toString(): string {
-        return this.compact().toString();
+        return Long.fromBits(this.lower, this.higher, true).toString();
     }
 
     /**

src/model/transaction/TransferTransaction.ts

@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import * as Long from 'long';
 import { Convert, Convert as convert } from '../../core/format';
 import { RawAddress } from '../../core/format/RawAddress';
 import { AmountDto } from '../../infrastructure/catbuffer/AmountDto';
@@ -181,7 +182,9 @@ export class TransferTransaction extends Transaction {
      */
     public sortMosaics(): Mosaic[] {
         return this.mosaics.sort((a, b) => {
-            return a.id.id.compact() - b.id.id.compact();
+            const long_a = Long.fromBits(a.id.id.lower, a.id.id.higher, true);
+            const long_b = Long.fromBits(b.id.id.lower, b.id.id.higher, true);
+            return long_a.compare(long_b);
         });
     }
 

test/model/transaction/TransferTransaction.spec.ts

@@ -332,4 +332,31 @@ describe('TransferTransaction', () => {
         expect(sorted.mosaics[0].id.id.compact()).to.be.equal(100);
         expect(sorted.mosaics[1].id.id.compact()).to.be.equal(200);
     });
+
+    it('should sort the Mosaic array - using Hex MosaicId', () => {
+        const mosaics = [
+            new Mosaic(new MosaicId('D525AD41D95FCF29'), UInt64.fromUint(5)),
+            new Mosaic(new MosaicId('77A1969932D987D7'), UInt64.fromUint(6)),
+            new Mosaic(new MosaicId('67F2B76F28BD36BA'), UInt64.fromUint(10)),
+        ];
+
+        const transferTransaction = TransferTransaction.create(
+            Deadline.create(),
+            Address.createFromRawAddress('SBILTA367K2LX2FEXG5TFWAS7GEFYAGY7QLFBYKC'),
+            mosaics,
+            PlainMessage.create('NEM'),
+            NetworkType.MIJIN_TEST,
+        );
+
+        expect(transferTransaction.mosaics[0].id.toHex()).to.be.equal('D525AD41D95FCF29');
+        expect(transferTransaction.mosaics[1].id.toHex()).to.be.equal('77A1969932D987D7');
+        expect(transferTransaction.mosaics[2].id.toHex()).to.be.equal('67F2B76F28BD36BA');
+
+        const signedTransaction = transferTransaction.signWith(account, generationHash);
+        const sorted = CreateTransactionFromPayload(signedTransaction.payload) as TransferTransaction;
+        expect(sorted.mosaics[0].id.toHex()).to.be.equal('67F2B76F28BD36BA');
+        expect(sorted.mosaics[1].id.toHex()).to.be.equal('77A1969932D987D7');
+        expect(sorted.mosaics[2].id.toHex()).to.be.equal('D525AD41D95FCF29');
+
+    });
 });