review feedback

Author: rg911

e2e/infrastructure/NetworkHttp.spec.ts

@@ -40,4 +40,15 @@ describe('NetworkHttp', () => {
                 });
         });
     });
+
+    describe('getNetworkName', () => {
+        it('should return network name and description', (done) => {
+            networkHttp.getNetworkName()
+                .subscribe((networkName) => {
+                    expect(networkName.name.toLowerCase()).to.be.equal('mijintest');
+                    expect(networkName.description.toLowerCase()).to.be.equal('catapult development network');
+                    done();
+                });
+        });
+    });
 });

src/infrastructure/NetworkHttp.ts

@@ -57,9 +57,7 @@ export class NetworkHttp extends Http implements NetworkRepository {
      */
     public getNetworkType(): Observable<NetworkType> {
         return observableFrom(this.nodeHttp.getNodeInfo()).pipe(
-            map(((nodeInfo: NodeInfo) => {
-                return nodeInfo.networkIdentifier;
-            }),
+            map(((nodeInfo: NodeInfo) => nodeInfo.networkIdentifier),
             catchError((error) =>  throwError(this.errorHandling(error)))),
         );
     }
@@ -71,9 +69,8 @@ export class NetworkHttp extends Http implements NetworkRepository {
      */
     public getNetworkName(): Observable<NetworkName> {
         return observableFrom(this.networkRouteApi.getNetworkType()).pipe(
-            map((response: { response: ClientResponse; body: NetworkTypeDTO; }) => {
-                return new NetworkName(response.body.name, response.body.description);
-            }),
+            map((response: { response: ClientResponse; body: NetworkTypeDTO; }) =>
+                new NetworkName(response.body.name, response.body.description)),
             catchError((error) =>  throwError(this.errorHandling(error))),
         );
     }