Skip to content

Commit 92b2b95

Browse files
committed
Fixed #132 bugs in encrypt / decrypt messages
1 parent 3ef7130 commit 92b2b95

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

src/model/transaction/EncryptedMessage.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ export class EncryptedMessage extends Message {
3535

3636
/**
3737
*
38-
* @param message
39-
* @param recipientPublicAccount
40-
* @param privateKey
38+
* @param message - Plain message to be encrypted
39+
* @param recipientPublicAccount - Recipient public account
40+
* @param privateKey - Sender private key
4141
*/
4242
public static create(message: string, recipientPublicAccount: PublicAccount, privateKey) {
4343
return new EncryptedMessage(
@@ -55,9 +55,9 @@ export class EncryptedMessage extends Message {
5555

5656
/**
5757
*
58-
* @param encryptMessage
59-
* @param privateKey
60-
* @param recipientPublicAccount
58+
* @param encryptMessage - Encrypted message to be decrypted
59+
* @param privateKey - Recipient private key
60+
* @param recipientPublicAccount - Sender public account
6161
*/
6262
public static decrypt(encryptMessage: EncryptedMessage, privateKey, recipientPublicAccount: PublicAccount): PlainMessage {
6363
return new PlainMessage(Message.decodeHex(crypto.decode(privateKey, recipientPublicAccount.publicKey, encryptMessage.payload)));

test/model/transaction/EncryptedMessage.spec.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,32 +17,34 @@
1717
import {expect} from 'chai';
1818
import {Account} from '../../../src/model/account/Account';
1919
import {EncryptedMessage} from '../../../src/model/transaction/EncryptedMessage';
20-
import { TestingAccount } from '../../conf/conf.spec';
20+
import { MultisigAccount, TestingAccount } from '../../conf/conf.spec';
2121

2222
describe('EncryptedMessage', () => {
2323

2424
let account: Account;
25+
let recipient: Account;
2526

2627
before(() => {
2728
account = TestingAccount;
29+
recipient = MultisigAccount;
2830
});
2931

3032
it('should create a encrypted message from a DTO', () => {
3133
const encryptedMessage = EncryptedMessage.createFromDTO('test transaction');
3234
expect(encryptedMessage.payload).to.be.equal('test transaction');
3335
});
3436

35-
it('should return encrypted message dto', () => {;
36-
const encryptedMessage = account.encryptMessage('test transaction', account.publicAccount);
37-
const plainMessage = account.decryptMessage(encryptedMessage, account.publicAccount);
37+
it('should return encrypted message dto', () => {
38+
const encryptedMessage = account.encryptMessage('test transaction', recipient.publicAccount);
39+
const plainMessage = recipient.decryptMessage(encryptedMessage, account.publicAccount);
3840
expect(plainMessage.payload).to.be.equal('test transaction');
3941
});
4042

4143
it('should create an encrypted message from a DTO and decrypt it', () => {
4244
const encryptMessage = EncryptedMessage
43-
.createFromDTO('7245170507448c53d808524221b5d157e19b06f574120a044e48f54dd8e0a4dedbf50ded7ae71' +
44-
'b90b59949bb6acde81d987ee6648aae9f093b94ac7cc3e8dba0bed8fa04ba286df6b32d2d6d21cbdc4e');
45-
const plainMessage = account.decryptMessage(encryptMessage, account.publicAccount);
45+
.createFromDTO('A3216D046C7147C8E848EF3F594725EA6F4EA2745829CA1021182E2FFA019C30D3E369F6AD236658A4' +
46+
'0BF5C6C2855DAC5C5B22255DBC231374CEA2124E44FA0629913747E31D87964320237B58B3C377');
47+
const plainMessage = recipient.decryptMessage(encryptMessage, account.publicAccount);
4648
expect(plainMessage.payload).to.be.equal('test transaction');
4749
});
4850
});

0 commit comments

Comments
 (0)