fix: AccountMetadataTransaction value string type changed to byte array

Author: Baha

e2e/infrastructure/MetadataHttp.spec.ts

@@ -18,6 +18,7 @@ import { deepEqual } from 'assert';
 import { expect } from 'chai';
 import { firstValueFrom } from 'rxjs';
 import { take, toArray } from 'rxjs/operators';
+import { Convert } from '../..';
 import { MetadataPaginationStreamer, MetadataRepository, Order } from '../../src/infrastructure';
 import { Metadata, MetadataType, UInt64 } from '../../src/model';
 import { Account, Address } from '../../src/model/account';
@@ -115,7 +116,7 @@ describe('MetadataHttp', () => {
                 account.address,
                 UInt64.fromUint(6),
                 23,
-                `Test account meta value`,
+                Convert.utf8ToUint8(`Test account meta value`),
                 networkType,
                 helper.maxFee,
             );

e2e/infrastructure/TransactionHttp.spec.ts

@@ -196,7 +196,7 @@ describe('TransactionHttp', () => {
                 account.address,
                 UInt64.fromUint(5),
                 10,
-                Convert.uint8ToUtf8(new Uint8Array(10)),
+                new Uint8Array(10),
                 networkType,
                 helper.maxFee,
             );

src/infrastructure/transaction/CreateTransactionFromDTO.ts

@@ -393,7 +393,7 @@ const CreateStandaloneTransactionFromDTO = (transactionDTO, transactionInfo): Tr
                 extractRecipient(transactionDTO.targetAddress),
                 UInt64.fromHex(transactionDTO.scopedMetadataKey),
                 transactionDTO.valueSizeDelta,
-                convert.decodeHex(transactionDTO.value),
+                convert.utf8ToUint8(transactionDTO.value),
                 signature,
                 signer,
                 transactionInfo,

src/infrastructure/transaction/SerializeTransactionToJSON.ts

@@ -246,7 +246,7 @@ export const SerializeTransactionToJSON = (transaction: Transaction): any => {
             scopedMetadataKey: accountMetadataTx.scopedMetadataKey.toHex(),
             valueSizeDelta: accountMetadataTx.valueSizeDelta,
             valueSize: accountMetadataTx.value.length,
-            value: Convert.utf8ToHex(accountMetadataTx.value),
+            value: accountMetadataTx.value,
         };
     } else if (transaction.type === TransactionType.MOSAIC_METADATA) {
         const mosaicMetadataTx = transaction as MosaicMetadataTransaction;

src/model/transaction/AccountMetadataTransaction.ts

@@ -60,7 +60,7 @@ export class AccountMetadataTransaction extends Transaction {
         targetAddress: UnresolvedAddress,
         scopedMetadataKey: UInt64,
         valueSizeDelta: number,
-        value: string,
+        value: Uint8Array,
         networkType: NetworkType,
         maxFee: UInt64 = new UInt64([0, 0]),
         signature?: string,
@@ -111,10 +111,10 @@ export class AccountMetadataTransaction extends Transaction {
          */
         public readonly valueSizeDelta: number,
         /**
-         * String value with UTF-8 encoding.
+         * xor of previous and the new value
          * Difference between the previous value and new value.
          */
-        public readonly value: string,
+        public readonly value: Uint8Array,
         signature?: string,
         signer?: PublicAccount,
         transactionInfo?: TransactionInfo,
@@ -142,7 +142,7 @@ export class AccountMetadataTransaction extends Transaction {
             UnresolvedMapping.toUnresolvedAddress(Convert.uint8ToHex(builder.getTargetAddress().unresolvedAddress)),
             new UInt64(builder.getScopedMetadataKey()),
             builder.getValueSizeDelta(),
-            Convert.uint8ToUtf8(builder.getValue()),
+            builder.getValue(),
             networkType,
             isEmbedded ? new UInt64([0, 0]) : new UInt64((builder as AccountMetadataTransactionBuilder).fee.amount),
             signature,
@@ -167,7 +167,7 @@ export class AccountMetadataTransaction extends Transaction {
             new UnresolvedAddressDto(this.targetAddress.encodeUnresolvedAddress(this.networkType)),
             this.scopedMetadataKey.toDTO(),
             this.valueSizeDelta,
-            Convert.utf8ToUint8(this.value),
+            this.value,
         );
         return transactionBuilder;
     }
@@ -185,7 +185,7 @@ export class AccountMetadataTransaction extends Transaction {
             new UnresolvedAddressDto(this.targetAddress.encodeUnresolvedAddress(this.networkType)),
             this.scopedMetadataKey.toDTO(),
             this.valueSizeDelta,
-            Convert.utf8ToUint8(this.value),
+            this.value,
         );
     }
 

src/service/MetadataTransactionService.ts

@@ -69,12 +69,14 @@ export class MetadataTransactionService {
                         const metadata = metadatas.data[0];
                         const currentValueByte = Convert.utf8ToUint8(metadata.metadataEntry.value);
                         const newValueBytes = Convert.utf8ToUint8(value);
+                        const xoredBytes = Convert.hexToUint8(Convert.xor(currentValueByte, newValueBytes));
+
                         return AccountMetadataTransaction.create(
                             deadline,
                             targetAddress,
                             key,
                             newValueBytes.length - currentValueByte.length,
-                            Convert.decodeHex(Convert.xor(currentValueByte, newValueBytes)),
+                            xoredBytes,
                             networkType,
                             maxFee,
                         );
@@ -85,7 +87,7 @@ export class MetadataTransactionService {
                         targetAddress,
                         key,
                         newValueBytes.length,
-                        value,
+                        Convert.utf8ToUint8(value),
                         networkType,
                         maxFee,
                     );

test/core/utils/TransactionMapping.spec.ts

@@ -523,7 +523,7 @@ describe('TransactionMapping - createFromPayload', () => {
             account.address,
             UInt64.fromUint(1000),
             1,
-            Convert.uint8ToUtf8(new Uint8Array(10)),
+            new Uint8Array(10),
             TestNetworkType,
         );
         const mosaicMetadataTransaction = MosaicMetadataTransaction.create(
@@ -872,7 +872,7 @@ describe('TransactionMapping - createFromPayload', () => {
             account.address,
             UInt64.fromUint(1000),
             1,
-            Convert.uint8ToUtf8(new Uint8Array(10)),
+            new Uint8Array(10),
             TestNetworkType,
         );
 
@@ -1552,7 +1552,7 @@ describe('TransactionMapping - createFromDTO (Transaction.toJSON() feed)', () =>
             account.address,
             UInt64.fromUint(1000),
             1,
-            'Test Value',
+            Convert.utf8ToUint8('Test Value'),
             TestNetworkType,
         );
 
@@ -1566,7 +1566,7 @@ describe('TransactionMapping - createFromDTO (Transaction.toJSON() feed)', () =>
         expect(transaction.targetAddress.equals(account.address)).to.be.true;
         expect(transaction.scopedMetadataKey.toHex()).to.be.equal(UInt64.fromUint(1000).toHex());
         expect(transaction.valueSizeDelta).to.be.equal(1);
-        expect(transaction.value).to.be.equal('Test Value');
+        expect(Convert.uint8ToHex(transaction.value)).to.be.equal(Convert.utf8ToHex('Test Value'));
     });
 
     it('should create MosaicMetadataTransaction', () => {

test/core/utils/TransactionMappingWithSignatures.spec.ts

@@ -534,7 +534,7 @@ describe('TransactionMapping - createFromPayload with optional sigature and sign
             account.address,
             UInt64.fromUint(1000),
             1,
-            Convert.uint8ToUtf8(new Uint8Array(10)),
+            new Uint8Array(10),
             NetworkType.TEST_NET,
         );
         const mosaicMetadataTransaction = MosaicMetadataTransaction.create(
@@ -969,7 +969,7 @@ describe('TransactionMapping - createFromPayload with optional sigature and sign
             account.address,
             UInt64.fromUint(1000),
             1,
-            Convert.uint8ToUtf8(new Uint8Array(10)),
+            new Uint8Array(10),
             NetworkType.TEST_NET,
             undefined,
             testSignature,

test/model/transaction/AccountMetadataTransaction.spec.ts

@@ -41,7 +41,7 @@ describe('AccountMetadataTransaction', () => {
             account.address,
             UInt64.fromUint(1000),
             1,
-            Convert.uint8ToUtf8(new Uint8Array(10)),
+            new Uint8Array(10),
             TestNetworkType,
         );
 
@@ -55,7 +55,7 @@ describe('AccountMetadataTransaction', () => {
             account.address,
             UInt64.fromUint(1000),
             1,
-            Convert.uint8ToUtf8(new Uint8Array(10)),
+            new Uint8Array(10),
             TestNetworkType,
             new UInt64([1, 0]),
         );
@@ -70,7 +70,7 @@ describe('AccountMetadataTransaction', () => {
             account.address,
             UInt64.fromUint(1000),
             1,
-            Convert.uint8ToUtf8(new Uint8Array(10)),
+            new Uint8Array(10),
             TestNetworkType,
         );
 
@@ -88,7 +88,7 @@ describe('AccountMetadataTransaction', () => {
                 account.address,
                 UInt64.fromUint(1000),
                 1,
-                Convert.uint8ToUtf8(new Uint8Array(10)),
+                new Uint8Array(10),
                 TestNetworkType,
             );
 
@@ -105,7 +105,7 @@ describe('AccountMetadataTransaction', () => {
                 account.address,
                 UInt64.fromUint(1000),
                 1,
-                Convert.uint8ToUtf8(new Uint8Array(10)),
+                new Uint8Array(10),
                 TestNetworkType,
             );
 
@@ -122,7 +122,7 @@ describe('AccountMetadataTransaction', () => {
             account.address,
             UInt64.fromUint(1000),
             1,
-            Convert.uint8ToUtf8(new Uint8Array(10)),
+            new Uint8Array(10),
             TestNetworkType,
         );
 
@@ -141,7 +141,7 @@ describe('AccountMetadataTransaction', () => {
             account.address,
             UInt64.fromUint(1000),
             1,
-            Convert.uint8ToUtf8(new Uint8Array(10)),
+            new Uint8Array(10),
             TestNetworkType,
         );
 
@@ -157,7 +157,7 @@ describe('AccountMetadataTransaction', () => {
             account.address,
             UInt64.fromUint(1000),
             1,
-            Convert.uint8ToUtf8(new Uint8Array(10)),
+            new Uint8Array(10),
             TestNetworkType,
         );
 
@@ -179,7 +179,7 @@ describe('AccountMetadataTransaction', () => {
             alias,
             UInt64.fromUint(1000),
             1,
-            Convert.uint8ToUtf8(new Uint8Array(10)),
+            new Uint8Array(10),
             TestNetworkType,
         );
 

test/service/MetadataTransactionservice.spec.ts

@@ -124,7 +124,7 @@ describe('MetadataTransactionService', () => {
             .subscribe((transaction: AccountMetadataTransaction) => {
                 expect(transaction.type).to.be.equal(TransactionType.ACCOUNT_METADATA);
                 expect(transaction.scopedMetadataKey.toHex()).to.be.equal(key.toHex());
-                expect(Convert.utf8ToHex(transaction.value)).to.be.equal(
+                expect(Convert.uint8ToHex(transaction.value)).to.be.equal(
                     Convert.xor(Convert.utf8ToUint8(value), Convert.utf8ToUint8(value + deltaValue)),
                 );
                 expect(transaction.valueSizeDelta).to.be.equal(deltaValue.length);