Fixed Namespace Alias bug

Fixed error handling in Metadata and MosaicRestriction bug

Author: rg911

src/infrastructure/NamespaceHttp.ts

@@ -270,9 +270,9 @@ export class NamespaceHttp extends Http implements NamespaceRepository {
      */
     private extractAlias(namespace: any): Alias {
         if (namespace.alias && namespace.alias.type === AliasType.Mosaic) {
-            return new MosaicAlias(namespace.alias.mosaicId);
+            return new MosaicAlias(new MosaicId(namespace.alias.mosaicId));
         } else if (namespace.alias && namespace.alias.type === AliasType.Address) {
-            return new AddressAlias(namespace.alias.address);
+            return new AddressAlias(Address.createFromEncoded(namespace.alias.address));
         }
 
         return new EmptyAlias();

src/service/MetadataTransactionService.ts

@@ -142,8 +142,9 @@ export class MetadataTransactionService {
                     maxFee,
                 );
             }),
-            catchError((err) => {
-                if (err.response.statusCode === 404) {
+            catchError((err: Error) => {
+                const error = JSON.parse(err.message);
+                if (error && error.statusCode && error.statusCode === 404) {
                     const newValueBytes = Convert.utf8ToUint8(value);
                     return of(AccountMetadataTransaction.create(
                         deadline,
@@ -155,7 +156,7 @@ export class MetadataTransactionService {
                         maxFee,
                     ));
                 }
-                throw Error(err);
+                throw Error(err.message);
               }));
     }
 
@@ -195,8 +196,9 @@ export class MetadataTransactionService {
                     maxFee,
                 );
             }),
-            catchError((err) => {
-                if (err.response.statusCode === 404) {
+            catchError((err: Error) => {
+                const error = JSON.parse(err.message);
+                if (error && error.statusCode && error.statusCode === 404) {
                     const newValueBytes = Convert.utf8ToUint8(value);
                     return of(MosaicMetadataTransaction.create(
                         deadline,
@@ -209,7 +211,7 @@ export class MetadataTransactionService {
                         maxFee,
                     ));
                 }
-                throw Error(err);
+                throw Error(err.message);
               }));
     }
 
@@ -249,8 +251,9 @@ export class MetadataTransactionService {
                     maxFee,
                 );
             }),
-            catchError((err) => {
-                if (err.response.statusCode === 404) {
+            catchError((err: Error) => {
+                const error = JSON.parse(err.message);
+                if (error && error.statusCode && error.statusCode === 404) {
                     const newValueBytes = Convert.utf8ToUint8(value);
                     return of(NamespaceMetadataTransaction.create(
                         deadline,
@@ -263,7 +266,7 @@ export class MetadataTransactionService {
                         maxFee,
                     ));
                 }
-                throw Error(err);
+                throw Error(err.message);
               }));
     }
 }

src/service/MosaicRestrictionTransactionService.ts

@@ -127,8 +127,9 @@ export class MosaicRestrictionTransactionService {
                             maxFee,
                         );
                     }),
-                    catchError((err) => {
-                        if (err.response && err.response.statusCode && err.response.statusCode === 404) {
+                    catchError((err: Error) => {
+                        const error = JSON.parse(err.message);
+                        if (error && error.statusCode && error.statusCode === 404) {
                             return of(MosaicAddressRestrictionTransaction.create(
                                 deadline,
                                 mosaicId,
@@ -140,7 +141,7 @@ export class MosaicRestrictionTransactionService {
                                 maxFee,
                             ));
                         }
-                        throw Error(err);
+                        throw Error(err.message);
                 }));
             }),
         );