Merge branch 'task/g426_persistent_harvesting' of github.com:NEMStudios/nem2-sdk-typescript-javascript into task/g426_persistent_harvesting

Author: fboucquez

e2e/infrastructure/AccountHttp.spec.ts

@@ -229,9 +229,9 @@ describe('AccountHttp', () => {
 
     describe('transactions', () => {
         it('should not return accounts when account does not exist', () => {
-            return accountRepository.getAccountInfo(Account.generateNewAccount(networkType).address).toPromise().then(r => {
+            return accountRepository.getAccountInfo(Account.generateNewAccount(networkType).address).toPromise().then((r) => {
                 return Promise.reject('should fail!');
-            }, err => {
+            }, (err) => {
                 const error = JSON.parse(err.message);
                 expect(error.statusCode).to.be.eq(404);
                 expect(error.errorDetails.statusMessage).to.be.eq('Not Found');
@@ -245,7 +245,7 @@ describe('AccountHttp', () => {
             const transactions = await accountRepository.getAccountTransactions(publicAccount.address, {transactionType: TransactionType.TRANSFER} as QueryParams).toPromise();
 
             expect(transactions.length).to.be.greaterThan(0);
-            transactions.forEach(t => {
+            transactions.forEach((t) => {
                 expect(t.type).to.be.eq(TransactionType.TRANSFER);
             });
         });

e2e/infrastructure/RestrictionHttp.spec.ts

@@ -16,7 +16,7 @@
 
 import { deepEqual } from 'assert';
 import { expect } from 'chai';
-import { RestrictionAccountRepository } from '../../src/infrastructure/RestrictionAccountRespository';
+import { RestrictionAccountRepository } from '../../src/infrastructure/RestrictionAccountRepository';
 import { RestrictionMosaicRepository } from '../../src/infrastructure/RestrictionMosaicRepository';
 import { Account } from '../../src/model/account/Account';
 import { Address } from '../../src/model/account/Address';

e2e/infrastructure/TransactionHttp.spec.ts

@@ -531,7 +531,7 @@ describe('TransactionHttp', () => {
             const addressModification = AccountRestrictionTransaction.createOperationRestrictionModificationTransaction(
                 Deadline.create(),
                 AccountRestrictionFlags.BlockIncomingTransactionType,
-                [TransactionType.LINK_ACCOUNT],
+                [TransactionType.ACCOUNT_LINK],
                 [],
                 networkType, helper.maxFee,
             );
@@ -551,7 +551,7 @@ describe('TransactionHttp', () => {
                 Deadline.create(),
                 AccountRestrictionFlags.BlockIncomingTransactionType,
                 [],
-                [TransactionType.LINK_ACCOUNT],
+                [TransactionType.ACCOUNT_LINK],
                 networkType, helper.maxFee,
             );
             const aggregateTransaction = AggregateTransaction.createComplete(Deadline.create(),
@@ -569,12 +569,12 @@ describe('TransactionHttp', () => {
         it('standalone', () => {
             AccountRestrictionModification.createForOperation(
                 AccountRestrictionModificationAction.Add,
-                TransactionType.LINK_ACCOUNT,
+                TransactionType.ACCOUNT_LINK,
             );
             const addressModification = AccountRestrictionTransaction.createOperationRestrictionModificationTransaction(
                 Deadline.create(),
                 AccountRestrictionFlags.BlockOutgoingTransactionType,
-                [TransactionType.LINK_ACCOUNT],
+                [TransactionType.ACCOUNT_LINK],
                 [],
                 networkType, helper.maxFee,
             );
@@ -595,7 +595,7 @@ describe('TransactionHttp', () => {
                 Deadline.create(),
                 AccountRestrictionFlags.BlockOutgoingTransactionType,
                 [],
-                [TransactionType.LINK_ACCOUNT],
+                [TransactionType.ACCOUNT_LINK],
                 networkType, helper.maxFee,
             );
             const aggregateTransaction = AggregateTransaction.createComplete(Deadline.create(),

e2e/service/MetadataTransactionService.spec.ts

@@ -160,7 +160,7 @@ describe('MetadataTransactionService', () => {
                 newValue,
                 targetAccount.publicAccount,
             ).subscribe((transaction: AccountMetadataTransaction) => {
-                expect(transaction.type).to.be.equal(TransactionType.ACCOUNT_METADATA_TRANSACTION);
+                expect(transaction.type).to.be.equal(TransactionType.ACCOUNT_METADATA);
                 expect(transaction.scopedMetadataKey.toHex()).to.be.equal(key.toHex());
                 expect(transaction.value).to.be.equal(newValue);
                 expect(transaction.targetPublicKey).to.be.equal(targetAccount.publicKey);
@@ -180,7 +180,7 @@ describe('MetadataTransactionService', () => {
                 targetAccount.publicAccount,
                 mosaicId,
             ).subscribe((transaction: MosaicMetadataTransaction) => {
-                expect(transaction.type).to.be.equal(TransactionType.MOSAIC_METADATA_TRANSACTION);
+                expect(transaction.type).to.be.equal(TransactionType.MOSAIC_METADATA);
                 expect(transaction.scopedMetadataKey.toHex()).to.be.equal(key.toHex());
                 expect(transaction.valueSizeDelta).to.be.equal(5);
                 expect(transaction.value).to.be.equal(newValue + 'delta');
@@ -202,7 +202,7 @@ describe('MetadataTransactionService', () => {
                 targetAccount.publicAccount,
                 namespaceId,
             ).subscribe((transaction: NamespaceMetadataTransaction) => {
-                expect(transaction.type).to.be.equal(TransactionType.NAMESPACE_METADATA_TRANSACTION);
+                expect(transaction.type).to.be.equal(TransactionType.NAMESPACE_METADATA);
                 expect(transaction.scopedMetadataKey.toHex()).to.be.equal(key.toHex());
                 expect(transaction.valueSizeDelta).to.be.equal(5);
                 expect(transaction.value).to.be.equal(newValue + 'delta');

src/core/crypto/nacl_catapult.ts

@@ -681,7 +681,7 @@ export const crypto_shared_key_hash = (shared, pk, sk, hashfunc, signSchema) =>
     d[31] &= 127;
     d[31] |= 64;
 
-    let q = [gf(), gf(), gf(), gf()];
+    const q = [gf(), gf(), gf(), gf()];
     unpackneg(q, pk);
     scalarmult(p, q, d);
     pack(shared, p);

src/core/format/KeyGenerator.ts

@@ -14,8 +14,8 @@
  * limitations under the License.
  */
 
-import { UInt64 } from '../../model/UInt64';
 import { sha3_256 } from 'js-sha3';
+import { UInt64 } from '../../model/UInt64';
 
 export class KeyGenerator {
     /**

src/core/format/RawArray.ts

@@ -50,7 +50,7 @@ export class RawArray {
      * @param {Array} array The array to check.
      * @returns {boolean} true if the array is zero-filled, false otherwise.
      */
-    public static isZeroFilled = (array) => array.every(value => 0 === value);
+    public static isZeroFilled = (array) => array.every((value) => 0 === value);
 
     /**
      * Deeply checks the equality of two arrays.

src/infrastructure/BlockHttp.ts

@@ -26,7 +26,7 @@ import { UInt64 } from '../model/UInt64';
 import { BlockRepository } from './BlockRepository';
 import { Http } from './Http';
 import { QueryParams } from './QueryParams';
-import { CreateTransactionFromDTO, extractBeneficiary, } from './transaction/CreateTransactionFromDTO';
+import { CreateTransactionFromDTO, extractBeneficiary } from './transaction/CreateTransactionFromDTO';
 
 /**
  * Blockchain http repository.

src/infrastructure/IListener.ts

@@ -22,7 +22,6 @@ import { CosignatureSignedTransaction } from '../model/transaction/CosignatureSi
 import { Transaction } from '../model/transaction/Transaction';
 import { TransactionStatusError } from '../model/transaction/TransactionStatusError';
 
-
 /**
  * Listener service
  */
@@ -53,7 +52,7 @@ export interface IListener {
      *
      * @return an observable stream of BlockInfo
      */
-    newBlock(): Observable<BlockInfo>
+    newBlock(): Observable<BlockInfo>;
 
     /**
      * Returns an observable stream of Transaction for a specific address.
@@ -68,13 +67,13 @@ export interface IListener {
     confirmed(address: Address, transactionHash?: string): Observable<Transaction>;
 
     /**
-    * Returns an observable stream of Transaction for a specific address.
-    * Each time a transaction is in unconfirmed state an it involves the address,
-    * it emits a new Transaction in the event stream.
-    *
-    * @param address address we listen when a transaction is in unconfirmed state
-    * @return an observable stream of Transaction with state unconfirmed
-    */
+     * Returns an observable stream of Transaction for a specific address.
+     * Each time a transaction is in unconfirmed state an it involves the address,
+     * it emits a new Transaction in the event stream.
+     *
+     * @param address address we listen when a transaction is in unconfirmed state
+     * @return an observable stream of Transaction with state unconfirmed
+     */
      unconfirmedAdded(address: Address): Observable<Transaction>;
 
     /**
@@ -96,7 +95,7 @@ export interface IListener {
      * @param transactionHash transactionHash for filtering multiple transactions
      * @return an observable stream of AggregateTransaction with missing signatures state
      */
-    aggregateBondedAdded(address: Address, transactionHash?: string): Observable<AggregateTransaction>
+    aggregateBondedAdded(address: Address, transactionHash?: string): Observable<AggregateTransaction>;
 
     /**
      * Returns an observable stream of Transaction Hashes for specific address.
@@ -106,7 +105,7 @@ export interface IListener {
      * @param address address we listen when a transaction is confirmed or rejected
      * @return an observable stream of Strings with the transaction hash
      */
-    aggregateBondedRemoved(address: Address): Observable<string>
+    aggregateBondedRemoved(address: Address): Observable<string>;
 
     /**
      * Returns an observable stream of {@link TransactionStatusError} for specific address.

src/infrastructure/RepositoryFactory.ts

@@ -28,7 +28,7 @@ import { NamespaceRepository } from './NamespaceRepository';
 import { NetworkRepository } from './NetworkRepository';
 import { NodeRepository } from './NodeRepository';
 import { ReceiptRepository } from './ReceiptRepository';
-import { RestrictionAccountRepository } from './RestrictionAccountRespository';
+import { RestrictionAccountRepository } from './RestrictionAccountRepository';
 import { RestrictionMosaicRepository } from './RestrictionMosaicRepository';
 import { TransactionRepository } from './TransactionRepository';