Applied catbuffer on aggregate transaction

Author: rg911

src/model/transaction/AggregateTransaction.ts

@@ -267,6 +267,6 @@ export class AggregateTransaction extends Transaction {
      * @returns {Uint8Array}
      */
     protected generateEmbeddedBytes(): Uint8Array {
-        throw new Error('Not implemented');
+        throw new Error('Method not implemented');
     }
 }

src/model/transaction/MosaicDefinitionTransaction.ts

@@ -205,10 +205,8 @@ export class MosaicDefinitionTransaction extends Transaction {
      * @returns {Uint8Array}
      */
     protected generateEmbeddedBytes(): Uint8Array {
-        const signerBuffer = new Uint8Array(32);
-
         const transactionBuilder = new EmbeddedMosaicDefinitionTransactionBuilder(
-            new KeyDto(signerBuffer),
+            new KeyDto(Convert.hexToUint8(this.signer!.publicKey)),
             this.versionToDTO(),
             TransactionType.MOSAIC_DEFINITION.valueOf(),
             new MosaicNonceDto(this.getMosaicNonceIntValue()),

src/model/transaction/MosaicSupplyChangeTransaction.ts

@@ -32,6 +32,7 @@ import { Transaction } from './Transaction';
 import { TransactionInfo } from './TransactionInfo';
 import { TransactionType } from './TransactionType';
 import { TransactionVersion } from './TransactionVersion';
+import { Convert } from '../../core/format';
 
 /**
  * In case a mosaic has the flag 'supplyMutable' set to true, the creator of the mosaic can change the supply,

src/model/transaction/TransferTransaction.ts

@@ -230,9 +230,8 @@ export class TransferTransaction extends Transaction {
      * @returns {Uint8Array}
      */
     protected generateEmbeddedBytes(): Uint8Array {
-        const signerBuffer = new Uint8Array(32);
         const transactionBuilder = new EmbeddedTransferTransactionBuilder(
-            new KeyDto(signerBuffer),
+            new KeyDto(Convert.hexToUint8(this.signer!.publicKey)),
             this.versionToDTO(),
             TransactionType.TRANSFER.valueOf(),
             new UnresolvedAddressDto(RawAddress.stringToAddress(this.recipientToString())),

test/model/transaction/AggregateTransaction.spec.ts

@@ -106,7 +106,7 @@ describe('AggregateTransaction', () => {
             NetworkType.MIJIN_TEST,
             []);
 
-        const signedTransaction = aggregateTransaction.signWith(account, generationHash);
+        const signedTransaction = aggregateTransaction.signWithCatbuffer(account, generationHash);
 
         expect(signedTransaction.payload.substring(0, 8)).to.be.equal('CD000000');
         expect(signedTransaction.payload.substring(240, 256)).to.be.equal('5100000051000000');