Skip to content

Commit 4543d44

Browse files
committed
SHA3Hasher - Removed unused method and added missing unit tests
1 parent 091b864 commit 4543d44

File tree

2 files changed

+30
-16
lines changed

2 files changed

+30
-16
lines changed

src/core/crypto/SHA3Hasher.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,6 @@ export class SHA3Hasher {
7373
} [length];
7474
}
7575

76-
/**
77-
* Create a hasher instance with given payload bytes and return hash array buffer.
78-
* @param {Uint8Array} payload Payload in bytes.
79-
* @param {SignSchema} signSchema The Sign Schema. (KECCAK(NIS1) / SHA3(Catapult))
80-
* @returns {ArrayBuffer}
81-
*/
82-
public static getHashArrayBuffer(payload: Uint8Array, signSchema: SignSchema): ArrayBuffer {
83-
return signSchema === SignSchema.SHA3 ? sha3_256.arrayBuffer(payload) : keccak256.arrayBuffer(payload);
84-
}
85-
8676
/**
8777
* Resolve signature schema from given network type
8878
*

test/core/crypto/sha3Hasher.spec.ts

Lines changed: 30 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,24 @@ describe('hasher', () => {
126126
});
127127
}
128128

129+
describe('Resolve SignSchema', () => {
130+
it('Should return Keccak schema', () => {
131+
let signSchema = sha3Hasher.resolveSignSchema(NetworkType.MAIN_NET);
132+
expect(signSchema).to.be.equal(SignSchema.KECCAK);
133+
134+
signSchema = sha3Hasher.resolveSignSchema(NetworkType.TEST_NET);
135+
expect(signSchema).to.be.equal(SignSchema.KECCAK);
136+
});
137+
138+
it('Should return SHA3 schema', () => {
139+
let signSchema = sha3Hasher.resolveSignSchema(NetworkType.MIJIN);
140+
expect(signSchema).to.be.equal(SignSchema.SHA3);
141+
142+
signSchema = sha3Hasher.resolveSignSchema(NetworkType.MIJIN_TEST);
143+
expect(signSchema).to.be.equal(SignSchema.SHA3);
144+
});
145+
});
146+
129147
describe('sha3 256', () => {
130148
// https://github.com/gvanas/KeccakCodePackage/blob/master/TestVectors/ShortMsgKAT_SHA3-256.txt
131149
addSha3Tests(32, [
@@ -141,12 +159,18 @@ describe('hasher', () => {
141159
describe('sha3 512', () => {
142160
// https://github.com/gvanas/KeccakCodePackage/blob/master/TestVectors/ShortMsgKAT_SHA3-512.txt
143161
addSha3Tests(64, [
144-
'A69F73CCA23A9AC5C8B567DC185A756E97C982164FE25859E0D1DCC1475C80A615B2123AF1F5F94C11E3E9402C3AC558F500199D95B6D3E301758586281DCD26',
145-
'3939FCC8B57B63612542DA31A834E5DCC36E2EE0F652AC72E02624FA2E5ADEECC7DD6BB3580224B4D6138706FC6E80597B528051230B00621CC2B22999EAA205',
146-
'AA092865A40694D91754DBC767B5202C546E226877147A95CB8B4C8F8709FE8CD6905256B089DA37896EA5CA19D2CD9AB94C7192FC39F7CD4D598975A3013C69',
147-
'CB20DCF54955F8091111688BECCEF48C1A2F0D0608C3A575163751F002DB30F40F2F671834B22D208591CFAF1F5ECFE43C49863A53B3225BDFD7C6591BA7658B',
148-
'D4B4BDFEF56B821D36F4F70AB0D231B8D0C9134638FD54C46309D14FADA92A2840186EED5415AD7CF3969BDFBF2DAF8CCA76ABFE549BE6578C6F4143617A4F1A',
149-
'B087C90421AEBF87911647DE9D465CBDA166B672EC47CCD4054A7135A1EF885E7903B52C3F2C3FE722B1C169297A91B82428956A02C631A2240F12162C7BC726',
162+
'A69F73CCA23A9AC5C8B567DC185A756E97C982164FE25859E0D1DCC1475C80A615' +
163+
'B2123AF1F5F94C11E3E9402C3AC558F500199D95B6D3E301758586281DCD26',
164+
'3939FCC8B57B63612542DA31A834E5DCC36E2EE0F652AC72E02624FA2E5ADEECC7' +
165+
'DD6BB3580224B4D6138706FC6E80597B528051230B00621CC2B22999EAA205',
166+
'AA092865A40694D91754DBC767B5202C546E226877147A95CB8B4C8F8709FE8CD69' +
167+
'05256B089DA37896EA5CA19D2CD9AB94C7192FC39F7CD4D598975A3013C69',
168+
'CB20DCF54955F8091111688BECCEF48C1A2F0D0608C3A575163751F002DB30F40F2' +
169+
'F671834B22D208591CFAF1F5ECFE43C49863A53B3225BDFD7C6591BA7658B',
170+
'D4B4BDFEF56B821D36F4F70AB0D231B8D0C9134638FD54C46309D14FADA92A28401' +
171+
'86EED5415AD7CF3969BDFBF2DAF8CCA76ABFE549BE6578C6F4143617A4F1A',
172+
'B087C90421AEBF87911647DE9D465CBDA166B672EC47CCD4054A7135A1EF885E7903' +
173+
'B52C3F2C3FE722B1C169297A91B82428956A02C631A2240F12162C7BC726',
150174
]);
151175
});
152176
});

0 commit comments

Comments
 (0)