Added more test cases and fixed a few bugs

Author: rg911

src/infrastructure/transaction/CreateTransactionFromPayload.ts

@@ -456,8 +456,8 @@ const parseInnerTransactionFromBinary = (innerTransactionBinary: string): string
     let innerBinary = innerTransactionBinary;
 
     while (innerBinary.length) {
-        const payloadSize = parseInt(convert.uint8ToHex(convert.hexToUint8(innerTransactionBinary.substring(0, 8)).reverse()), 16) * 2;
-        const innerTransaction = innerTransactionBinary.substring(8, payloadSize);
+        const payloadSize = parseInt(convert.uint8ToHex(convert.hexToUint8(innerBinary.substring(0, 8)).reverse()), 16) * 2;
+        const innerTransaction = innerBinary.substring(8, payloadSize);
         embeddedTransaction.push(innerTransaction);
         innerBinary = innerBinary.substring(payloadSize);
     }

src/service/AggregatedTransactionService.ts

@@ -15,7 +15,7 @@
  */
 
 import {from as observableFrom , Observable, of as observableOf} from 'rxjs';
-import { map, mergeMap} from 'rxjs/operators';
+import { flatMap, map, mergeMap, toArray} from 'rxjs/operators';
 import { TransactionMapping } from '../core/utils/TransactionMapping';
 import { AccountHttp } from '../infrastructure/AccountHttp';
 import { MultisigAccountGraphInfo } from '../model/account/MultisigAccountGraphInfo';
@@ -52,7 +52,6 @@ export class AggregatedTransactionService {
         if (signedTransaction.signer) {
             signers.push(signedTransaction.signer);
         }
-
         return observableFrom(aggregateTransaction.innerTransactions).pipe(
             mergeMap((innerTransaction) => this.accountHttp.getMultisigAccountInfo(innerTransaction.signer.address)
                 .pipe(
@@ -63,11 +62,16 @@ export class AggregatedTransactionService {
                         this.accountHttp.getMultisigAccountGraphInfo(_.account.address)
                         .pipe(
                             map((graphInfo) => this.validateCosignatories(graphInfo, signers, innerTransaction)),
-                        ) : observableOf(true),
+                        ) : observableOf(signers.find((s) => s === _.account.publicKey ) !== undefined),
                         ),
                     ),
                 ),
-            );
+            toArray(),
+        ).pipe(
+            flatMap((results) => {
+                return observableOf(results.every((isComplete) => isComplete));
+            }),
+        );
     }
 
     /**