github PR#63: Added TransactionVersion class containing constants for current network transaction format versions

Author: Greg S

src/model/transaction/AggregateTransaction.ts

@@ -26,6 +26,7 @@ import { SignedTransaction } from './SignedTransaction';
 import { Transaction } from './Transaction';
 import { TransactionInfo } from './TransactionInfo';
 import { TransactionType } from './TransactionType';
+import { TransactionVersion } from './TransactionVersion';
 
 /**
  * Aggregate innerTransactions contain multiple innerTransactions that can be initiated by different accounts.
@@ -77,7 +78,7 @@ export class AggregateTransaction extends Transaction {
                                  cosignatures: AggregateTransactionCosignature[]): AggregateTransaction {
         return new AggregateTransaction(networkType,
             TransactionType.AGGREGATE_COMPLETE,
-            2,
+            TransactionVersion.AGGREGATE_COMPLETE,
             deadline,
             new UInt64([0, 0]),
             innerTransactions,
@@ -99,7 +100,7 @@ export class AggregateTransaction extends Transaction {
                                cosignatures: AggregateTransactionCosignature[] = []): AggregateTransaction {
         return new AggregateTransaction(networkType,
             TransactionType.AGGREGATE_BONDED,
-            2,
+            TransactionVersion.AGGREGATE_BONDED,
             deadline,
             new UInt64([0, 0]),
             innerTransactions,

src/model/transaction/LockFundsTransaction.ts

@@ -24,6 +24,7 @@ import { SignedTransaction } from './SignedTransaction';
 import { Transaction } from './Transaction';
 import { TransactionInfo } from './TransactionInfo';
 import { TransactionType } from './TransactionType';
+import { TransactionVersion } from './TransactionVersion';
 
 /**
  * Lock funds transaction is used before sending an Aggregate bonded transaction, as a deposit to announce the transaction.
@@ -53,7 +54,7 @@ export class LockFundsTransaction extends Transaction {
                          networkType: NetworkType): LockFundsTransaction {
         return new LockFundsTransaction(
             networkType,
-            1,
+            TransactionVersion.LOCK,
             deadline,
             UInt64.fromUint(0),
             mosaic,

src/model/transaction/ModifyMultisigAccountTransaction.ts

@@ -23,6 +23,7 @@ import { MultisigCosignatoryModification } from './MultisigCosignatoryModificati
 import { Transaction } from './Transaction';
 import { TransactionInfo } from './TransactionInfo';
 import { TransactionType } from './TransactionType';
+import { TransactionVersion } from './TransactionVersion';
 
 /**
  * Modify multisig account transactions are part of the NEM's multisig account system.
@@ -47,7 +48,7 @@ export class ModifyMultisigAccountTransaction extends Transaction {
                          modifications: MultisigCosignatoryModification[],
                          networkType: NetworkType): ModifyMultisigAccountTransaction {
         return new ModifyMultisigAccountTransaction(networkType,
-            3,
+            TransactionVersion.MODIFY_MULTISIG_ACCOUNT,
             deadline,
             new UInt64([0, 0]),
             minApprovalDelta,

src/model/transaction/MosaicDefinitionTransaction.ts

@@ -25,6 +25,7 @@ import { Deadline } from './Deadline';
 import { Transaction } from './Transaction';
 import { TransactionInfo } from './TransactionInfo';
 import { TransactionType } from './TransactionType';
+import { TransactionVersion } from './TransactionVersion';
 
 /**
  * Before a mosaic can be created or transferred, a corresponding definition of the mosaic has to be created and published to the network.
@@ -47,7 +48,7 @@ export class MosaicDefinitionTransaction extends Transaction {
                          mosaicProperties: MosaicProperties,
                          networkType: NetworkType): MosaicDefinitionTransaction {
         return new MosaicDefinitionTransaction(networkType,
-            3,
+            TransactionVersion.MOSAIC_DEFINITION,
             deadline,
             new UInt64([0, 0]),
             mosaicNonce,

src/model/transaction/MosaicSupplyChangeTransaction.ts

@@ -24,6 +24,7 @@ import { Deadline } from './Deadline';
 import { Transaction } from './Transaction';
 import { TransactionInfo } from './TransactionInfo';
 import { TransactionType } from './TransactionType';
+import { TransactionVersion } from './TransactionVersion';
 
 /**
  * In case a mosaic has the flag 'supplyMutable' set to true, the creator of the mosaic can change the supply,
@@ -46,7 +47,7 @@ export class MosaicSupplyChangeTransaction extends Transaction {
                          delta: UInt64,
                          networkType: NetworkType): MosaicSupplyChangeTransaction {
         return new MosaicSupplyChangeTransaction(networkType,
-            2,
+            TransactionVersion.MOSAIC_SUPPLY_CHANGE,
             deadline,
             new UInt64([0, 0]),
             mosaicId,

src/model/transaction/RegisterNamespaceTransaction.ts

@@ -24,6 +24,7 @@ import { Deadline } from './Deadline';
 import { Transaction } from './Transaction';
 import { TransactionInfo } from './TransactionInfo';
 import { TransactionType } from './TransactionType';
+import { TransactionVersion } from './TransactionVersion';
 
 /**
  * Accounts can rent a namespace for an amount of blocks and after a this renew the contract.
@@ -44,7 +45,7 @@ export class RegisterNamespaceTransaction extends Transaction {
                                       duration: UInt64,
                                       networkType: NetworkType): RegisterNamespaceTransaction {
         return new RegisterNamespaceTransaction(networkType,
-            2,
+            TransactionVersion.REGISTER_NAMESPACE,
             deadline,
             new UInt64([0, 0]),
             NamespaceType.RootNamespace,

src/model/transaction/SecretLockTransaction.ts

@@ -24,6 +24,7 @@ import { HashType, HashTypeLengthValidator } from './HashType';
 import { Transaction } from './Transaction';
 import { TransactionInfo } from './TransactionInfo';
 import { TransactionType } from './TransactionType';
+import { TransactionVersion } from './TransactionVersion';
 
 export class SecretLockTransaction extends Transaction {
 
@@ -49,7 +50,7 @@ export class SecretLockTransaction extends Transaction {
                          networkType: NetworkType): SecretLockTransaction {
         return new SecretLockTransaction(
             networkType,
-            1,
+            TransactionVersion.SECRET_LOCK,
             deadline,
             UInt64.fromUint(0),
             mosaic,

src/model/transaction/SecretProofTransaction.ts

@@ -22,6 +22,7 @@ import { HashType, HashTypeLengthValidator } from './HashType';
 import { Transaction } from './Transaction';
 import { TransactionInfo } from './TransactionInfo';
 import { TransactionType } from './TransactionType';
+import { TransactionVersion } from './TransactionVersion';
 
 export class SecretProofTransaction extends Transaction {
 
@@ -43,7 +44,7 @@ export class SecretProofTransaction extends Transaction {
                          networkType: NetworkType): SecretProofTransaction {
         return new SecretProofTransaction(
             networkType,
-            1,
+            TransactionVersion.SECRET_PROOF,
             deadline,
             UInt64.fromUint(0),
             hashType,

src/model/transaction/TransactionVersion.ts

@@ -0,0 +1,88 @@
+/*
+ * Copyright 2019 NEM
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * Static class containing transaction version constants.
+ *
+ * Transaction format versions are defined in catapult-server in
+ * each transaction's plugin source code.
+ * 
+ * In [catapult-server](https://github.com/nemtech/catapult-server), the `DEFINE_TRANSACTION_CONSTANTS` macro
+ * is used to define the `TYPE` and `VERSION` of the transaction format.
+ * 
+ * @see https://github.com/nemtech/catapult-server/blob/master/plugins/txes/transfer/src/model/TransferTransaction.h#L37
+ */
+export class TransactionVersion {
+
+    /**
+     * Transfer Transaction transaction version.
+     * @type {number}
+     */
+    public static readonly TRANSFER = 3;
+
+    /**
+     * Register namespace transaction version.
+     * @type {number}
+     */
+    public static readonly REGISTER_NAMESPACE = 2;
+
+    /**
+     * Mosaic definition transaction version.
+     * @type {number}
+     */
+    public static readonly MOSAIC_DEFINITION = 3;
+
+    /**
+     * Mosaic supply change transaction.
+     * @type {number}
+     */
+    public static readonly MOSAIC_SUPPLY_CHANGE = 2;
+
+    /**
+     * Modify multisig account transaction version.
+     * @type {number}
+     */
+    public static readonly MODIFY_MULTISIG_ACCOUNT = 3;
+
+    /**
+     * Aggregate complete transaction version.
+     * @type {number}
+     */
+    public static readonly AGGREGATE_COMPLETE = 2;
+
+    /**
+     * Aggregate bonded transaction version
+     */
+    public static readonly AGGREGATE_BONDED = 2;
+
+    /**
+     * Lock transaction version
+     * @type {number}
+     */
+    public static readonly LOCK = 1;
+
+    /**
+     * Secret Lock transaction version
+     * @type {number}
+     */
+    public static readonly SECRET_LOCK = 1;
+
+    /**
+     * Secret Proof transaction version
+     * @type {number}
+     */
+    public static readonly SECRET_PROOF = 1;
+}

src/model/transaction/TransferTransaction.ts

@@ -25,6 +25,7 @@ import { Message } from './Message';
 import { Transaction } from './Transaction';
 import { TransactionInfo } from './TransactionInfo';
 import { TransactionType } from './TransactionType';
+import { TransactionVersion } from './TransactionVersion';
 
 /**
  * Transfer transactions contain data about transfers of mosaics and message to another account.
@@ -45,7 +46,7 @@ export class TransferTransaction extends Transaction {
                          message: Message,
                          networkType: NetworkType): TransferTransaction {
         return new TransferTransaction(networkType,
-            3,
+            TransactionVersion.TRANSFER,
             deadline,
             new UInt64([0, 0]),
             recipient,