You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Fixed#628
- Metadata & Receipt Pagination
* Moved receiptMerkle to blockHttp
* Fixed e2e tests
* Fixed#628
- Metadata & Receipt Pagination
* Moved receiptMerkle to blockHttp
* Fixed e2e tests
* temp push
* Receipt Streamer improvement
* Fixed unit tests
* Added metadata type in metadata service
* Updated openAPI version
* Updated branch name from master to main
* Improved coverage
* Refactored metadata service
* - Added missing imports
- removed @internal in public methods
Co-authored-by: fernando <fboucquez@gmail.com>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+22-27Lines changed: 22 additions & 27 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,31 +1,31 @@
1
1
# Contributing to symbol-sdk-typescript-javascript
2
2
3
-
First off, thank you for considering contributing to symbol-sdk-typescript-javascript.
3
+
First off, thank you for considering contributing to symbol-sdk-typescript-javascript.
4
4
It’s people like you that make symbol-sdk-typescript-javascript such a great tool.
5
5
6
-
symbol-sdk-typescript-javascript is an open source project and we love to receive contributions from
7
-
our community — you! There are many ways to contribute, from writing tutorials or blog
8
-
posts, improving the documentation, submitting bug reports and feature requests or
6
+
symbol-sdk-typescript-javascript is an open source project and we love to receive contributions from
7
+
our community — you! There are many ways to contribute, from writing tutorials or blog
8
+
posts, improving the documentation, submitting bug reports and feature requests or
9
9
writing code which can be incorporated into symbol-sdk-typescript-javascript itself.
10
10
11
-
Following these guidelines helps to communicate that you respect the time of
12
-
the developers managing and developing this open source project. In return,
13
-
they should reciprocate that respect in addressing your issue, assessing changes,
11
+
Following these guidelines helps to communicate that you respect the time of
12
+
the developers managing and developing this open source project. In return,
13
+
they should reciprocate that respect in addressing your issue, assessing changes,
14
14
and helping you finalize your pull requests.
15
15
16
-
Please, **don't use the issue tracker for support questions**.
16
+
Please, **don't use the issue tracker for support questions**.
17
17
18
18
## Bug reports
19
19
20
-
If you think you have found a bug in symbol-sdk-typescript-javascript, first make sure that you
21
-
are testing against the latest version of symbol-sdk-typescript-javascript - your issue may already
22
-
have been fixed. If not, search our issues list on GitHub in case a similar
20
+
If you think you have found a bug in symbol-sdk-typescript-javascript, first make sure that you
21
+
are testing against the latest version of symbol-sdk-typescript-javascript - your issue may already
22
+
have been fixed. If not, search our issues list on GitHub in case a similar
23
23
issue has already been opened.
24
24
25
-
It is very helpful if you can prepare a reproduction of the bug. In other words,
26
-
provide a small test case which we can run to confirm your bug. It makes it easier to
25
+
It is very helpful if you can prepare a reproduction of the bug. In other words,
26
+
provide a small test case which we can run to confirm your bug. It makes it easier to
27
27
find the problem and to fix it.
28
-
28
+
29
29
Please, take in consideration the next template to report your issue:
30
30
31
31
> **Expected Behaviour**\
@@ -35,26 +35,25 @@ Please, take in consideration the next template to report your issue:
35
35
> **Steps to reproduce**\
36
36
> For faster issue detection, we would need a step by step description do reproduce the issue.
37
37
38
-
39
38
Provide as much information as you can.
40
39
41
40
Open a new issue [here][github-issues].
42
41
43
42
## Feature requests
44
43
45
-
If you find yourself wishing for a feature that doesn't exist in symbol-sdk-typescript-javascript,
46
-
you are probably not alone. There are bound to be others out there with similar
47
-
needs. Many of the features that symbol-sdk-typescript-javascript has today have been added because
48
-
our users saw the need. Open an [issue][github-issues] on our issues list on GitHub which describes
44
+
If you find yourself wishing for a feature that doesn't exist in symbol-sdk-typescript-javascript,
45
+
you are probably not alone. There are bound to be others out there with similar
46
+
needs. Many of the features that symbol-sdk-typescript-javascript has today have been added because
47
+
our users saw the need. Open an [issue][github-issues] on our issues list on GitHub which describes
49
48
the feature you would like to see, why you need it, and how it should work.
50
49
51
50
## Contributing code and documentation changes
52
51
53
-
If you have a bugfix or new feature that you would like to contribute to symbol-sdk-typescript-javascript, please find or open an issue
54
-
about it first. Talk about what you would like to do. It may be that somebody is already working on it, or that there
52
+
If you have a bugfix or new feature that you would like to contribute to symbol-sdk-typescript-javascript, please find or open an issue
53
+
about it first. Talk about what you would like to do. It may be that somebody is already working on it, or that there
55
54
are particular issues that you should know about before implementing the change.
56
55
57
-
We enjoy working with contributors to get their code accepted. There are many approaches to fixing a problem and it is
56
+
We enjoy working with contributors to get their code accepted. There are many approaches to fixing a problem and it is
58
57
important to find the best approach before writing too much code.
59
58
60
59
### Contributing License Notice
@@ -65,7 +64,7 @@ Whether or not you state this explicitly, by submitting any copyrighted material
65
64
66
65
### Fork and clone the repository
67
66
68
-
You will need to fork the main symbol-sdk-typescript-javascript code or documentation repository and clone
67
+
You will need to fork the main symbol-sdk-typescript-javascript code or documentation repository and clone
69
68
it to your local machine. See [github help page](https://help.github.com/articles/fork-a-repo/) for help.
70
69
71
70
Further instructions for specific projects are given below.
@@ -75,13 +74,9 @@ Further instructions for specific projects are given below.
75
74
Once your changes and tests are ready to submit for review:
76
75
77
76
1. Test your changes
78
-
79
77
Run the test suite to make sure that nothing is broken.
80
-
81
78
2. Submit a pull request
82
-
83
79
Push your local changes to your forked copy of the repository and [submit a pull request](https://help.github.com/articles/about-pull-requests/). In the pull request, choose a title which sums up the changes that you have made, and in the body provide more details about what your changes do. Also mention the number of the issue where discussion has taken place, eg "Closes #123".
84
-
85
80
Then sit back and wait. There will probably be discussion about the pull request and, if any changes are needed, we would love to work with you to get your pull request merged into symbol-sdk-typescript-javascript.
86
81
87
82
*CONTRIBUTING.md is based on [CONTRIBUTING-template.md](https://github.com/nayafia/contributing-template/blob/master/CONTRIBUTING-template.md)* , [elasticsearch/CONTRIBUTING](https://github.com/elastic/elasticsearch/blob/master/CONTRIBUTING.md) and [spark/CONTRIBUTING](https://github.com/apache/spark/blob/master/CONTRIBUTING.md)
0 commit comments