short implementation + test

Author: khawarizmus

package.json

@@ -5,6 +5,7 @@
   "scripts": {
     "pretest": "npm run build",
     "test": "mocha --ui bdd --recursive ./dist/test --timeout 90000",
+    "tran": "mocha --ui bdd --recursive ./dist/test/model/transaction/Transaction.spec --timeout 90000",
     "test:e2e": "mocha --ui bdd --recursive ./dist/e2e --timeout 90000",
     "test:all": "mocha --ui bdd --recursive ./dist/ --timeout 90000",
     "build": "rm -rf dist/ && tsc",

src/model/transaction/AggregateTransaction.ts

@@ -145,28 +145,4 @@ export class AggregateTransaction extends Transaction {
             || (this.signer !== undefined && this.signer.equals(publicAccount));
     }
 
-    /**
-     * @description re-aplly a given value to the transaction in an immutable way
-     * @param {Deadline} deadline
-     * @returns {Transaction}
-     * @memberof Transaction
-     */
-    public reaplygiven(newDeadline: Deadline): AggregateTransaction {
-
-        if (this.isUnannounced) {
-            return new AggregateTransaction(
-            this.networkType,
-            this.type,
-            this.version,
-            newDeadline,
-            this.fee,
-            this.innerTransactions,
-            this.cosignatures,
-            this.signature,
-            this.signer);
-        } else {
-            throw new Error('Should not modify an announced transaction');
-        }
-    }
-
 }

src/model/transaction/LockFundsTransaction.ts

@@ -114,28 +114,4 @@ export class LockFundsTransaction extends Transaction {
             .build();
     }
 
-    /**
-     * @description re-aplly a given value to the transaction in an immutable way
-     * @param {Deadline} deadline
-     * @returns {Transaction}
-     * @memberof Transaction
-     */
-    public reaplygiven(deadline: Deadline, signedTransaction: SignedTransaction): LockFundsTransaction {
-
-        if (this.isUnannounced) {
-            return new LockFundsTransaction(
-            this.networkType,
-            this.type,
-            deadline,
-            this.fee,
-            this.mosaic,
-            this.duration,
-            signedTransaction,
-            this.signature,
-            this.signer);
-        } else {
-            throw new Error('Should not modify an announced transaction');
-        }
-    }
-
 }

src/model/transaction/ModifyMultisigAccountTransaction.ts

@@ -106,27 +106,4 @@ export class ModifyMultisigAccountTransaction extends Transaction {
             .build();
     }
 
-    /**
-     * @description re-aplly a given value to the transaction in an immutable way
-     * @param {Deadline} deadline
-     * @returns {Transaction}
-     * @memberof Transaction
-     */
-    public reaplygiven(newDeadline: Deadline): ModifyMultisigAccountTransaction {
-
-        if (this.isUnannounced) {
-            return new ModifyMultisigAccountTransaction(
-                this.networkType,
-                this.version,
-                newDeadline,
-                this.fee,
-                this.minApprovalDelta,
-                this.minRemovalDelta,
-                this.modifications,
-                this.signature,
-                this.signer);
-        } else {
-            throw new Error('Should not modify an announced transaction');
-        }
-    }
 }

src/model/transaction/MosaicDefinitionTransaction.ts

@@ -126,28 +126,4 @@ export class MosaicDefinitionTransaction extends Transaction {
         return mosaicDefinitionTransaction.build();
     }
 
-    /**
-     * @description re-aplly a given value to the transaction in an immutable way
-     * @param {Deadline} deadline
-     * @returns {Transaction}
-     * @memberof Transaction
-     */
-    public reaplygiven(newDeadline: Deadline): MosaicDefinitionTransaction {
-
-        if (this.isUnannounced) {
-            return new MosaicDefinitionTransaction(
-                this.networkType,
-                this.version,
-                newDeadline,
-                this.fee,
-                this.parentId,
-                this.mosaicId,
-                this.mosaicName,
-                this.mosaicProperties,
-                this.signature,
-                this.signer);
-        } else {
-            throw new Error('Should not modify an announced transaction');
-        }
-    }
 }

src/model/transaction/MosaicSupplyChangeTransaction.ts

@@ -104,27 +104,4 @@ export class MosaicSupplyChangeTransaction extends Transaction {
             .build();
     }
 
-    /**
-     * @description re-aplly a given value to the transaction in an immutable way
-     * @param {Deadline} deadline
-     * @returns {Transaction}
-     * @memberof Transaction
-     */
-    public reaplygiven(newDeadline: Deadline): MosaicSupplyChangeTransaction {
-
-        if (this.isUnannounced) {
-            return new MosaicSupplyChangeTransaction(
-                this.networkType,
-                this.version,
-                newDeadline,
-                this.fee,
-                this.mosaicId,
-                this.direction,
-                this.delta,
-                this.signature,
-                this.signer);
-        } else {
-            throw new Error('Should not modify an announced transaction');
-        }
-    }
 }

src/model/transaction/RegisterNamespaceTransaction.ts

@@ -151,29 +151,4 @@ export class RegisterNamespaceTransaction extends Transaction {
         return registerNamespacetransaction.build();
     }
 
-    /**
-     * @description re-aplly a given value to the transaction in an immutable way
-     * @param {Deadline} deadline
-     * @returns {Transaction}
-     * @memberof Transaction
-     */
-    public reaplygiven(newDeadline: Deadline): RegisterNamespaceTransaction {
-
-        if (this.isUnannounced) {
-            return new RegisterNamespaceTransaction(
-                this.networkType,
-                this.version,
-                newDeadline,
-                this.fee,
-                this.namespaceType,
-                this.namespaceName,
-                this.namespaceId,
-                this.duration,
-                this.parentId,
-                this.signature,
-                this.signer);
-        } else {
-            throw new Error('Should not modify an announced transaction');
-        }
-    }
 }

src/model/transaction/SecretLockTransaction.ts

@@ -126,29 +126,4 @@ export class SecretLockTransaction extends Transaction {
             .build();
     }
 
-    /**
-     * @description re-aplly a given value to the transaction in an immutable way
-     * @param {Deadline} deadline
-     * @returns {Transaction}
-     * @memberof Transaction
-     */
-    public reaplygiven(newDeadline: Deadline): SecretLockTransaction {
-
-        if (this.isUnannounced) {
-            return new SecretLockTransaction(
-            this.networkType,
-            this.version,
-            newDeadline,
-            this.fee,
-            this.mosaic,
-            this.duration,
-            this.hashType,
-            this.secret,
-            this.recipient,
-            this.signature,
-            this.signer);
-        } else {
-            throw new Error('Should not modify an announced transaction');
-        }
-    }
 }

src/model/transaction/SecretProofTransaction.ts

@@ -96,27 +96,4 @@ export class SecretProofTransaction extends Transaction {
             .build();
     }
 
-    /**
-     * @description re-aplly a given value to the transaction in an immutable way
-     * @param {Deadline} deadline
-     * @returns {Transaction}
-     * @memberof Transaction
-     */
-    public reaplygiven(newDeadline: Deadline): SecretProofTransaction {
-
-        if (this.isUnannounced) {
-            return new SecretProofTransaction(
-            this.networkType,
-            this.version,
-            newDeadline,
-            this.fee,
-            this.hashType,
-            this.secret,
-            this.proof,
-            this.signature,
-            this.signer);
-        } else {
-            throw new Error('Should not modify an announced transaction');
-        }
-    }
 }

src/model/transaction/Transaction.ts

@@ -163,5 +163,11 @@ export abstract class Transaction {
      * @returns {Transaction}
      * @memberof Transaction
      */
-    public abstract reaplygiven(deadline: Deadline, signedTransaction?: SignedTransaction): Transaction;
+    public reapplygiven(deadline: Deadline): Transaction {
+        if (this.isUnannounced()) {
+            return Object.assign({__proto__: Object.getPrototypeOf(this)}, this, {deadline});
+        } else {
+            throw new Error('an Announced transaction can\'t be modified');
+        }
+    }
 }