issue #53: implementation proposal for Transaction.size and type classes overloads

Author: Greg S

src/model/transaction/AccountLinkTransaction.ts

@@ -80,6 +80,22 @@ export class AccountLinkTransaction extends Transaction {
         super(TransactionType.LINK_ACCOUNT, networkType, version, deadline, maxFee, signature, signer, transactionInfo);
     }
 
+    /**
+     * @override Transaction.size()
+     * @description get the byte size of a AccountLinkTransaction
+     * @returns {number}
+     * @memberof AccountLinkTransaction
+     */
+    public get size(): number {
+        const byteSize = super.size;
+
+        // set static byte size fields
+        const bytePublicKey = 32;
+        const byteLinkAction = 1;
+
+        return byteSize + bytePublicKey + byteLinkAction;
+    }
+
     /**
      * @internal
      * @returns {VerifiableTransaction}

src/model/transaction/AccountPropertyTransaction.ts

@@ -51,7 +51,7 @@ export class AccountPropertyTransaction {
             propertyType,
             modifications,
             networkType,
-            maxFee
+            maxFee,
         );
     }
 
@@ -79,7 +79,7 @@ export class AccountPropertyTransaction {
             propertyType,
             modifications,
             networkType,
-            maxFee
+            maxFee,
         );
     }
 
@@ -107,7 +107,7 @@ export class AccountPropertyTransaction {
             propertyType,
             modifications,
             networkType,
-            maxFee
+            maxFee,
         );
     }
 

src/model/transaction/AddressAliasTransaction.ts

@@ -93,6 +93,23 @@ export class AddressAliasTransaction extends Transaction {
         super(TransactionType.ADDRESS_ALIAS, networkType, version, deadline, maxFee, signature, signer, transactionInfo);
     }
 
+    /**
+     * @override Transaction.size()
+     * @description get the byte size of a AddressAliasTransaction
+     * @returns {number}
+     * @memberof AddressAliasTransaction
+     */
+    public get size(): number {
+        const byteSize = super.size;
+
+        // set static byte size fields
+        const byteActionType = 1;
+        const byteNamespaceId = 8;
+        const byteAddress = 25;
+
+        return byteSize + byteActionType + byteNamespaceId + byteAddress;
+    }
+
     /**
      * @internal
      * @returns {VerifiableTransaction}

src/model/transaction/AggregateTransaction.ts

@@ -151,4 +151,24 @@ export class AggregateTransaction extends Transaction {
             || (this.signer !== undefined && this.signer.equals(publicAccount));
     }
 
+    /**
+     * @override Transaction.size()
+     * @description get the byte size of a AggregateTransaction
+     * @returns {number}
+     * @memberof AggregateTransaction
+     */
+    public get size(): number {
+        const byteSize = super.size;
+
+        // set static byte size fields
+        const byteTransactionsSize = 4;
+
+        // calculate each inner transaction's size
+        let byteTransactions = 0;
+        this.innerTransactions.map((transaction) => {
+            byteTransactions += transaction.size;
+        });
+
+        return byteSize + byteTransactionsSize + byteTransactions;
+    }
 }

src/model/transaction/LockFundsTransaction.ts

@@ -101,6 +101,24 @@ export class LockFundsTransaction extends Transaction {
         }
     }
 
+    /**
+     * @override Transaction.size()
+     * @description get the byte size of a LockFundsTransaction
+     * @returns {number}
+     * @memberof LockFundsTransaction
+     */
+    public get size(): number {
+        const byteSize = super.size;
+
+        // set static byte size fields
+        const byteMosaicId = 8;
+        const byteAmount = 8;
+        const byteDuration = 8;
+        const byteHash = 32;
+
+        return byteSize + byteMosaicId + byteAmount + byteDuration + byteHash;
+    }
+
     /**
      * @internal
      * @return {VerifiableTransaction}

src/model/transaction/ModifyAccountPropertyAddressTransaction.ts

@@ -74,6 +74,27 @@ export class ModifyAccountPropertyAddressTransaction extends Transaction {
         super(TransactionType.MODIFY_ACCOUNT_PROPERTY_ADDRESS, networkType, version, deadline, maxFee, signature, signer, transactionInfo);
     }
 
+    /**
+     * @override Transaction.size()
+     * @description get the byte size of a ModifyAccountPropertyAddressTransaction
+     * @returns {number}
+     * @memberof ModifyAccountPropertyAddressTransaction
+     */
+    public get size(): number {
+        const byteSize = super.size;
+
+        // set static byte size fields
+        const bytePropertyType = 1;
+        const byteModificationCount = 1;
+
+        // each modification contains :
+        // - 1 byte for modificationType
+        // - 25 bytes for the modification value (address)
+        const byteModifications = 26 * this.modifications.length;
+
+        return byteSize + bytePropertyType + byteModificationCount + byteModifications;
+    }
+
     /**
      * @internal
      * @returns {VerifiableTransaction}

src/model/transaction/ModifyAccountPropertyEntityTypeTransaction.ts

@@ -75,6 +75,27 @@ export class ModifyAccountPropertyEntityTypeTransaction extends Transaction {
         super(TransactionType.MODIFY_ACCOUNT_PROPERTY_ENTITY_TYPE, networkType, version, deadline, maxFee, signature, signer, transactionInfo);
     }
 
+    /**
+     * @override Transaction.size()
+     * @description get the byte size of a ModifyAccountPropertyEntityTypeTransaction
+     * @returns {number}
+     * @memberof ModifyAccountPropertyEntityTypeTransaction
+     */
+    public get size(): number {
+        const byteSize = super.size;
+
+        // set static byte size fields
+        const bytePropertyType = 1;
+        const byteModificationCount = 1;
+
+        // each modification contains :
+        // - 1 byte for modificationType
+        // - 2 bytes for the modification value (transaction type)
+        const byteModifications = 3 * this.modifications.length;
+
+        return byteSize + bytePropertyType + byteModificationCount + byteModifications;
+    }
+
     /**
      * @internal
      * @returns {VerifiableTransaction}

src/model/transaction/ModifyAccountPropertyMosaicTransaction.ts

@@ -74,6 +74,27 @@ export class ModifyAccountPropertyMosaicTransaction extends Transaction {
         super(TransactionType.MODIFY_ACCOUNT_PROPERTY_MOSAIC, networkType, version, deadline, maxFee, signature, signer, transactionInfo);
     }
 
+    /**
+     * @override Transaction.size()
+     * @description get the byte size of a ModifyAccountPropertyMosaicTransaction
+     * @returns {number}
+     * @memberof ModifyAccountPropertyMosaicTransaction
+     */
+    public get size(): number {
+        const byteSize = super.size;
+
+        // set static byte size fields
+        const bytePropertyType = 1;
+        const byteModificationCount = 1;
+
+        // each modification contains :
+        // - 1 byte for modificationType
+        // - 8 bytes for the modification value (mosaicId)
+        const byteModifications = 9 * this.modifications.length;
+
+        return byteSize + bytePropertyType + byteModificationCount + byteModifications;
+    }
+
     /**
      * @internal
      * @returns {VerifiableTransaction}

src/model/transaction/ModifyMultisigAccountTransaction.ts

@@ -94,6 +94,28 @@ export class ModifyMultisigAccountTransaction extends Transaction {
         super(TransactionType.MODIFY_MULTISIG_ACCOUNT, networkType, version, deadline, maxFee, signature, signer, transactionInfo);
     }
 
+    /**
+     * @override Transaction.size()
+     * @description get the byte size of a ModifyMultisigAccountTransaction
+     * @returns {number}
+     * @memberof ModifyMultisigAccountTransaction
+     */
+    public get size(): number {
+        const byteSize = super.size;
+
+        // set static byte size fields
+        const byteRemovalDelta = 1;
+        const byteApprovalDelta = 1;
+        const byteNumModifications = 1;
+
+        // each modification contains :
+        // - 1 byte for modificationType
+        // - 32 bytes for cosignatoryPublicKey
+        const byteModifications = 33 * this.modifications.length
+
+        return byteSize + byteRemovalDelta + byteApprovalDelta + byteNumModifications + byteModifications;
+    }
+
     /**
      * @internal
      * @returns {VerifiableTransaction}

src/model/transaction/MosaicAliasTransaction.ts

@@ -93,6 +93,23 @@ export class MosaicAliasTransaction extends Transaction {
         super(TransactionType.MOSAIC_ALIAS, networkType, version, deadline, maxFee, signature, signer, transactionInfo);
     }
 
+    /**
+     * @override Transaction.size()
+     * @description get the byte size of a MosaicAliasTransaction
+     * @returns {number}
+     * @memberof MosaicAliasTransaction
+     */
+    public get size(): number {
+        const byteSize = super.size;
+
+        // set static byte size fields
+        const byteType = 1;
+        const byteNamespaceId = 8;
+        const byteMosaicId = 8;
+
+        return byteSize + byteType + byteNamespaceId + byteMosaicId;
+    }
+
     /**
      * @internal
      * @returns {VerifiableTransaction}