[sourcekit] Avoid duplicating implementation of InProc and XPC service when possible

When installing both InProc and XPC versions of sourcekitd, dynamically
link the XPC service to the InProc version. This lets us install both
frameworks without wasting the disk space from having another copy of
the swift frontend statically linked.

Author: benlangmuir

tools/SourceKit/cmake/modules/AddSwiftSourceKit.cmake

@@ -363,11 +363,10 @@ macro(add_sourcekit_xpc_service name framework_target)
 
   add_dependencies(${framework_target} ${name})
 
-  # This is necessary to avoid having an rpath with an absolute build directory.
-  # Without this, such an rpath is added during build time and preserved at install time.
+  # Add rpath for sourcekitdInProc
   set_target_properties(${name} PROPERTIES
                         BUILD_WITH_INSTALL_RPATH On
-                        INSTALL_RPATH "@loader_path/../lib"
+                        INSTALL_RPATH "@loader_path/../../../../../../.."
                         INSTALL_NAME_DIR "@rpath")
 
   if (SOURCEKIT_DEPLOYMENT_OS MATCHES "^macosx")

tools/SourceKit/tools/sourcekitd/bin/InProc/CMakeLists.txt

@@ -1,4 +1,4 @@
-set(EXPORTED_SYMBOL_FILE "${SOURCEKITD_SOURCE_DIR}/bin/sourcekitd.exports")
+set(EXPORTED_SYMBOL_FILE "${CMAKE_CURRENT_SOURCE_DIR}/sourcekitdInProc.exports")
 
 option(SOURCEKITD_BUILD_STATIC_INPROC
   "Build sourcekitdInProc as a static library (in addition to a shared one)" OFF)

tools/SourceKit/tools/sourcekitd/bin/InProc/sourcekitdInProc.exports

@@ -0,0 +1,82 @@
+sourcekitd_cancel_request
+sourcekitd_initialize
+sourcekitd_request_array_create
+sourcekitd_request_array_set_int64
+sourcekitd_request_array_set_string
+sourcekitd_request_array_set_stringbuf
+sourcekitd_request_array_set_uid
+sourcekitd_request_array_set_value
+sourcekitd_request_create_from_yaml
+sourcekitd_request_description_copy
+sourcekitd_request_description_dump
+sourcekitd_request_dictionary_create
+sourcekitd_request_dictionary_set_int64
+sourcekitd_request_dictionary_set_string
+sourcekitd_request_dictionary_set_stringbuf
+sourcekitd_request_dictionary_set_uid
+sourcekitd_request_dictionary_set_value
+sourcekitd_request_int64_create
+sourcekitd_request_retain
+sourcekitd_request_release
+sourcekitd_request_string_create
+sourcekitd_request_uid_create
+sourcekitd_response_description_copy
+sourcekitd_response_description_dump
+sourcekitd_response_description_dump_filedesc
+sourcekitd_response_dispose
+sourcekitd_response_error_get_description
+sourcekitd_response_error_get_kind
+sourcekitd_response_get_value
+sourcekitd_response_is_error
+sourcekitd_send_request
+sourcekitd_send_request_sync
+sourcekitd_set_interrupted_connection_handler
+sourcekitd_set_notification_handler
+sourcekitd_set_uid_handler
+sourcekitd_set_uid_handlers
+sourcekitd_shutdown
+sourcekitd_uid_get_from_buf
+sourcekitd_uid_get_from_cstr
+sourcekitd_uid_get_length
+sourcekitd_uid_get_string_ptr
+sourcekitd_variant_array_apply
+sourcekitd_variant_array_apply_f
+sourcekitd_variant_array_get_bool
+sourcekitd_variant_array_get_count
+sourcekitd_variant_array_get_int64
+sourcekitd_variant_array_get_string
+sourcekitd_variant_array_get_uid
+sourcekitd_variant_array_get_value
+sourcekitd_variant_bool_get_value
+sourcekitd_variant_description_copy
+sourcekitd_variant_description_dump
+sourcekitd_variant_description_dump_filedesc
+sourcekitd_variant_dictionary_apply
+sourcekitd_variant_dictionary_apply_f
+sourcekitd_variant_dictionary_get_bool
+sourcekitd_variant_dictionary_get_int64
+sourcekitd_variant_dictionary_get_string
+sourcekitd_variant_dictionary_get_value
+sourcekitd_variant_dictionary_get_uid
+sourcekitd_variant_get_type
+sourcekitd_variant_json_description_copy
+sourcekitd_variant_string_get_length
+sourcekitd_variant_string_get_ptr
+sourcekitd_variant_data_get_size
+sourcekitd_variant_data_get_ptr
+sourcekitd_variant_int64_get_value
+sourcekitd_variant_uid_get_value
+_ZN10sourcekitd13enableLoggingEN4llvm9StringRefE
+_ZN10sourcekitd13handleRequestEPvNSt3__18functionIFvS0_EEE
+_ZN10sourcekitd17initializeServiceEN4llvm9StringRefES1_NSt3__18functionIFvPvEEE
+_ZN10sourcekitd24createErrorRequestFailedEN4llvm9StringRefE
+_ZN9SourceKit6Logger12LoggingLevelE
+_ZN9SourceKit6LoggerD1Ev
+_ZN9SourceKit6UIdent6setTagEPv
+_ZN9SourceKit6UIdentC1EN4llvm9StringRefE
+_ZN9SourceKit9WorkQueue4Impl12dispatchSyncEPvRKNS0_12DispatchDataE
+_ZN9SourceKit9WorkQueue4Impl15dispatchBarrierEPvRKNS0_12DispatchDataE
+_ZN9SourceKit9WorkQueue4Impl6createENS0_9DequeuingENS0_8PriorityEN4llvm9StringRefE
+_ZN9SourceKit9WorkQueue4Impl7releaseEPv
+_ZNK9SourceKit6UIdent5c_strEv
+_ZNK9SourceKit6UIdent6getTagEv

tools/SourceKit/tools/sourcekitd/bin/XPC/Client/CMakeLists.txt

@@ -2,7 +2,7 @@ set(public_headers
   ${SOURCEKITD_SOURCE_DIR}/include/sourcekitd/sourcekitd.h
 )
 
-set(EXPORTED_SYMBOL_FILE "${SOURCEKITD_SOURCE_DIR}/bin/sourcekitd.exports")
+set(EXPORTED_SYMBOL_FILE "${CMAKE_CURRENT_SOURCE_DIR}/sourcekitd.exports")
 
 # FIXME: If you delete sourcekitd.framework, the soft links inside it need
 # a CMake reconfigure in order for them to be created.

tools/SourceKit/tools/sourcekitd/bin/sourcekitd.exports renamed to tools/SourceKit/tools/sourcekitd/bin/XPC/Client/sourcekitd.exports

@@ -3,9 +3,14 @@ if (BUILD_SOURCEKIT_XPC_SERVICE)
     XPCService.cpp
     LLVM_LINK_COMPONENTS support coverage
   )
-  target_link_libraries(SourceKitService PRIVATE
-    SourceKitSwiftLang
-    sourcekitdAPI)
+  swift_is_installing_component(sourcekit-inproc SOURCEKIT_INSTALLING_INPROC)
+  if(SOURCEKIT_INSTALLING_INPROC)
+    target_link_libraries(SourceKitService PUBLIC sourcekitdInProc)
+  else()
+    target_link_libraries(SourceKitService PRIVATE
+      SourceKitSwiftLang
+      sourcekitdAPI)
+  endif()
 endif()
 
 if (NOT SOURCEKIT_DEPLOYMENT_OS MATCHES "^macosx")