Merge pull request swiftlang#33851 from freddi-kit/fix/may-trap-condition

[sil-opt] Fix covering all-case of trapping instruction of SILInstruction::mayTrap

Author: xedin

lib/SIL/IR/SILInstruction.cpp

@@ -1266,6 +1266,7 @@ bool SILInstruction::mayTrap() const {
   case SILInstructionKind::CondFailInst:
   case SILInstructionKind::UnconditionalCheckedCastInst:
   case SILInstructionKind::UnconditionalCheckedCastAddrInst:
+  case SILInstructionKind::UnconditionalCheckedCastValueInst:
     return true;
   default:
     return false;

test/SILOptimizer/side-effect.sil

@@ -210,6 +210,23 @@ bb0(%0 : $Builtin.NativeObject):
   return %r : $()
 }
 
+// CHECK-LABEL: sil @checkedaddr
+// CHECK: <func=rw+-,param0=,param1=;alloc;trap;readrc>
+sil @checkedaddr : $@convention(thin) (Builtin.NativeObject, X) -> () {
+bb0(%0 : $Builtin.NativeObject, %1 : $X):
+  unconditional_checked_cast_addr Builtin.NativeObject in %0 : $Builtin.NativeObject to X in %1 : $X
+  %r = tuple ()
+  return %r : $()
+}
+
+// CHECK-LABEL: sil @checkedcastvalue
+// CHECK: <func=r,param0=;trap>
+sil @checkedcastvalue : $@convention(thin) (Builtin.NativeObject) -> () {
+bb0(%0 : $Builtin.NativeObject):
+  %1 = unconditional_checked_cast_value Builtin.NativeObject in %0 : $Builtin.NativeObject to X
+  %r = tuple ()
+  return %r : $()
+}
 
 sil_global public @sil_global1 : $Int32