[DiagnosticEngine] Don't account ignored diagnostics in Sema.NumSwift6Errors statistic

xedin · xedin · commit 9fda61011ad4 · 2025-02-24T18:17:44.000-08:00
Since the diagnostic is not going to be emitted counting it in `Swift6Errors` statistics is going to be confusing to the users. Resolves: swiftlang#79291 Resolves: rdar://145341605 (cherry picked from commit 664c119)
diff --git a/lib/AST/DiagnosticEngine.cpp b/lib/AST/DiagnosticEngine.cpp
@@ -432,7 +432,8 @@ InFlightDiagnostic::limitBehaviorUntilSwiftVersion(
     limitBehavior(limit);
   }
 
-  if (majorVersion == 6) {
+  // Record all of the diagnostics that are going to be emitted.
+  if (majorVersion == 6 && limit != DiagnosticBehavior::Ignore) {
     if (auto stats = Engine->statsReporter) {
       ++stats->getFrontendCounters().NumSwift6Errors;
     }

Original file line number	Diff line number	Diff line change
`@@ -432,7 +432,8 @@ InFlightDiagnostic::limitBehaviorUntilSwiftVersion(`
`432`	`432`	`limitBehavior(limit);`
`433`	`433`	`}`
`434`	`434`
`435`		`- if (majorVersion == 6) {`
	`435`	`+ // Record all of the diagnostics that are going to be emitted.`
	`436`	`+ if (majorVersion == 6 && limit != DiagnosticBehavior::Ignore) {`
`436`	`437`	`if (auto stats = Engine->statsReporter) {`
`437`	`438`	`++stats->getFrontendCounters().NumSwift6Errors;`
`438`	`439`	`}`