Enable AccessEnforcementOpts with OSSA

Author: atrick

lib/SIL/IR/SILInstruction.cpp

@@ -1134,7 +1134,6 @@ bool SILInstruction::mayRelease() const {
     return true;
 
   case SILInstructionKind::DestroyValueInst:
-    assert(!SILModuleConventions(getModule()).useLoweredAddresses());
     return true;
 
   case SILInstructionKind::UnconditionalCheckedCastAddrInst:

lib/SILOptimizer/PassManager/PassPipeline.cpp

@@ -242,6 +242,9 @@ void addHighLevelLoopOptPasses(SILPassPipelinePlan &P) {
   P.addSimplifyCFG();
   // Optimize access markers for better LICM: might merge accesses
   // It will also set the no_nested_conflict for dynamic accesses
+  // AccessEnforcementReleaseSinking results in non-canonical OSSA.
+  // It is only used to expose opportunities in AccessEnforcementOpts
+  // before CanonicalOSSA re-hoists destroys.
   P.addAccessEnforcementReleaseSinking();
   P.addAccessEnforcementOpts();
   P.addHighLevelLICM();
@@ -250,6 +253,9 @@ void addHighLevelLoopOptPasses(SILPassPipelinePlan &P) {
   // LICM might have added new merging potential by hoisting
   // we don't want to restart the pipeline - ignore the
   // potential of merging out of two loops
+  // AccessEnforcementReleaseSinking results in non-canonical OSSA.
+  // It is only used to expose opportunities in AccessEnforcementOpts
+  // before CanonicalOSSA re-hoists destroys.
   P.addAccessEnforcementReleaseSinking();
   P.addAccessEnforcementOpts();
   // Start of loop unrolling passes.

lib/SILOptimizer/Transforms/AccessEnforcementOpts.cpp

@@ -17,6 +17,8 @@
 /// - Should run immediately before the AccessEnforcementWMO to share
 ///   AccessedStorageAnalysis results.
 ///
+/// - Benefits from running after AccessEnforcementReleaseSinking.
+///
 /// This pass optimizes access enforcement as follows:
 ///
 /// **Access marker folding**
@@ -727,7 +729,7 @@ void AccessConflictAndMergeAnalysis::visitFullApply(FullApplySite fullApply,
   ASA->getCallSiteEffects(callSiteAccesses, fullApply);
 
   LLVM_DEBUG(llvm::dbgs() << "Visiting: " << *fullApply.getInstruction()
-                          << "  call site accesses: ";
+                          << "  call site accesses:\n";
              callSiteAccesses.dump());
   recordConflicts(state, callSiteAccesses.getResult());
 }
@@ -1094,10 +1096,6 @@ struct AccessEnforcementOpts : public SILFunctionTransform {
     if (F->empty())
       return;
 
-    // FIXME: Support ownership.
-    if (F->hasOwnership())
-      return;
-
     LLVM_DEBUG(llvm::dbgs() << "Running local AccessEnforcementOpts on "
                             << F->getName() << "\n");