Merge pull request swiftlang#32491 from xedin/rdar-62927467-5.3

[5.3][CSApply] Always try to load arguments constructing object literals

Author: xedin

lib/Sema/CSApply.cpp

@@ -2643,6 +2643,7 @@ namespace {
       if (!witness || !isa<AbstractFunctionDecl>(witness.getDecl()))
         return nullptr;
       expr->setInitializer(witness);
+      expr->setArg(cs.coerceToRValue(expr->getArg()));
       return expr;
     }
 

test/Sema/object_literals_osx.swift

@@ -27,3 +27,13 @@ let text = #fileLiteral(resourceName: "TextFile.txt").relativeString! // expecte
 
 // rdar://problem/49861813
 #fileLiteral() // expected-error{{missing argument for parameter 'resourceName' in call}} expected-error{{could not infer type of file reference literal}} expected-note{{import Foundation to use 'URL' as the default file reference literal type}}
+
+// rdar://problem/62927467
+func test_literal_arguments_are_loaded() {
+  var resource = "foo.txt" // expected-warning {{variable 'resource' was never mutated; consider changing to 'let' constant}}
+  let _: Path = #fileLiteral(resourceName: resource) // Ok
+
+  func test(red: inout Float, green: inout Float) -> S {
+    return #colorLiteral(red: red, green: green, blue: 1, alpha: 1) // Ok
+  }
+}