Merge pull request swiftlang#60921 from AnthonyLatsis/migrate-test-suite-to-gh-issues-18

AnthonyLatsis · web-flow · commit 1b121e5527a1 · 2022-09-09T12:07:51.000+03:00
Gardening: Migrate test suite to GH issues p. 18
diff --git a/test/Reflection/box_descriptors.sil b/test/Reflection/box_descriptors.sil
@@ -2,10 +2,10 @@
 // RUN: %target-build-swift %s -emit-module -emit-library -module-name capture_descriptors -o %t/capture_descriptors%{target-shared-library-suffix}
 // RUN: %target-swift-reflection-dump -binary-filename %t/capture_descriptors%{target-shared-library-suffix} | %FileCheck %s
 
-// SR-10758
+// https://github.com/apple/swift/issues/53148
 // UNSUPPORTED: OS=linux-gnu, OS=linux-android, OS=linux-androideabi
 
-// SR-12893
+// https://github.com/apple/swift/issues/55339
 // XFAIL: OS=openbsd
 
 sil_stage canonical
diff --git a/test/Reflection/capture_descriptors.sil b/test/Reflection/capture_descriptors.sil
@@ -1,7 +1,7 @@
 
 // REQUIRES: no_asan
 
-// SR-12893
+// https://github.com/apple/swift/issues/55339
 // XFAIL: OS=openbsd
 // UNSUPPORTED: OS=linux-android, OS=linux-androideabi
 
diff --git a/test/Reflection/typeref_decoding_imported.swift b/test/Reflection/typeref_decoding_imported.swift
@@ -1,6 +1,6 @@
 // XFAIL: OS=windows-msvc
 
-// SR-12893
+// https://github.com/apple/swift/issues/55339
 // XFAIL: OS=openbsd
 
 // RUN: %empty-directory(%t)
diff --git a/test/Runtime/lazy_witness_table_cycle.swift b/test/Runtime/lazy_witness_table_cycle.swift
@@ -2,7 +2,8 @@
 // REQUIRES: executable_test
 // REQUIRES: foundation
 
-// SR-5958
+// https://github.com/apple/swift/issues/48517
+
 import Foundation
 
 public struct Property: Equatable, Hashable, Codable {
diff --git a/test/Sanitizers/tsan/racy_async_let_fibonacci.swift b/test/Sanitizers/tsan/racy_async_let_fibonacci.swift
@@ -12,7 +12,7 @@
 // UNSUPPORTED: back_deployment_runtime
 
 // rdar://86825277
-// SR-15805
+// https://github.com/apple/swift/issues/58082
 // UNSUPPORTED: CPU=arm64 || CPU=arm64e
 
 // Disabled because this test is flaky rdar://76542113
diff --git a/test/Sema/accessibility_private.swift b/test/Sema/accessibility_private.swift
@@ -207,13 +207,14 @@ extension Container {
   fileprivate class PrivateGenericUser<T> where T: PrivateInnerClass {} // expected-error {{generic class cannot be declared fileprivate because its generic requirement uses a private type}} {{none}}
 }
 
-fileprivate struct SR2579 {
+// https://github.com/apple/swift/issues/45184
+fileprivate struct C_45184 {
   private struct Inner {
     private struct InnerPrivateType {}
-    var innerProperty = InnerPrivateType() // expected-error {{property must be declared private because its type 'SR2579.Inner.InnerPrivateType' uses a private type}}
+    var innerProperty = InnerPrivateType() // expected-error {{property must be declared private because its type 'C_45184.Inner.InnerPrivateType' uses a private type}}
   }
   // FIXME: We need better errors when one access violation results in more
   // downstream.
-  private var outerProperty = Inner().innerProperty // expected-error {{property cannot be declared in this context because its type 'SR2579.Inner.InnerPrivateType' uses a private type}}
-  var outerProperty2 = Inner().innerProperty // expected-error {{property must be declared private because its type 'SR2579.Inner.InnerPrivateType' uses a private type}}
+  private var outerProperty = Inner().innerProperty // expected-error {{property cannot be declared in this context because its type 'C_45184.Inner.InnerPrivateType' uses a private type}}
+  var outerProperty2 = Inner().innerProperty // expected-error {{property must be declared private because its type 'C_45184.Inner.InnerPrivateType' uses a private type}}
 }
diff --git a/test/Sema/call_as_function_generic.swift b/test/Sema/call_as_function_generic.swift
@@ -42,7 +42,8 @@ _ = genericString("Hello")
 let genericInt = GenericType<Set<Int>>(collection: [1, 2, 3])
 _ = genericInt(initialValue: 1)
 
-// SR-11386
+// https://github.com/apple/swift/issues/53787
+
 class C<T> {}
 protocol P1 {}
 extension C where T : P1 { // expected-note {{where 'T' = 'Int'}}
diff --git a/test/Sema/call_as_function_simple.swift b/test/Sema/call_as_function_simple.swift
@@ -199,7 +199,8 @@ func testIUO(a: SimpleCallable!, b: MultipleArgsCallable!, c: Extended!,
   _ = try? h { throw DummyError() }
 }
 
-// SR-11778
+// https://github.com/apple/swift/issues/54185
+
 struct DoubleANumber {
   func callAsFunction(_ x: Int, completion: (Int) -> Void = { _ in }) {
     completion(x + x)
@@ -211,7 +212,8 @@ func testDefaults(_ x: DoubleANumber) {
   x(5, completion: { _ in })
 }
 
-// SR-11881
+// https://github.com/apple/swift/issues/54296
+
 struct IUOCallable {
   static var callable: IUOCallable { IUOCallable() }
   func callAsFunction(_ x: Int) -> IUOCallable! { nil }
@@ -235,12 +237,14 @@ func testAccessControl(_ x: PrivateCallable) {
   x(5) // expected-error {{'callAsFunction' is inaccessible due to 'private' protection level}}
 }
 
-struct SR_11909 {
-  static let s = SR_11909()
-  func callAsFunction(_ x: Int = 0) -> SR_11909 { SR_11909() }
-}
+// https://github.com/apple/swift/issues/54327
+do {
+  struct S {
+    static let s = S()
+    func callAsFunction(_ x: Int = 0) -> S {}
+  }
 
-func testDefaultsWithUMEs(_ x: SR_11909) {
-  let _: SR_11909 = .s()
-  let _: SR_11909 = .s(5)
+  // Test default argument with 'UnresolvedMemberExpr'.
+  let _: S = .s()
+  let _: S = .s(5)
 }
diff --git a/test/Sema/circularity_multifile_error.swift b/test/Sema/circularity_multifile_error.swift
@@ -1,6 +1,6 @@
 // RUN: %target-swift-frontend -emit-silgen -verify -primary-file %s %S/Inputs/circularity_multifile_error_helper.swift
 
-// SR-4594
+// https://github.com/apple/swift/issues/47171
 
 struct A {
   var b: AnUndefinedType // expected-error {{cannot find type 'AnUndefinedType' in scope}}
diff --git a/test/Sema/complex_expressions.swift b/test/Sema/complex_expressions.swift
@@ -1,7 +1,8 @@
 // RUN: %target-typecheck-verify-swift
 
-// SR-838:
-// expression test_seconds() was too complex to be solved in reasonable time
+// https://github.com/apple/swift/issues/43450
+// Expression in 'test_seconds' was too complex to be solved in reasonable time
+
 struct Nano : CustomStringConvertible {
   var value: Int64 = 0
   init(_ x: Int64) { self.value = x }
@@ -30,8 +31,8 @@ func test_seconds() {
   print((u_minute + u_second + Nano(500)) + " = " + (1.i + 1.s + 500.ns))
 }
 
-// SR-2102:
-// DictionaryExpr was too complex to be solved in reasonable time
+// https://github.com/apple/swift/issues/44710:
+// 'DictionaryExpr' was too complex to be solved in reasonable time
 
 let M_PI: Double = 3.1415926535897931
 let M_E : Double = 2.7182818284590451
@@ -74,14 +75,16 @@ var operations: Dictionary<String, Operation> = [
   "=": .equals,
 ]
 
-// SR-1794
-struct P {
-  let x: Float
-  let y: Float
-}
+// https://github.com/apple/swift/issues/44403
+do {
+  struct P {
+    let x: Float
+    let y: Float
+  }
 
-func sr1794(pt: P, p0: P, p1: P) -> Bool {
-  return (pt.x - p0.x) * (p1.y - p0.y) - (pt.y - p0.y) * (p1.x - p0.x) < 0.0
+  func f(pt: P, p0: P, p1: P) -> Bool {
+    return (pt.x - p0.x) * (p1.y - p0.y) - (pt.y - p0.y) * (p1.x - p0.x) < 0.0
+  }
 }
 
 // Tests for partial contextual type application in sub-expressions
@@ -94,18 +97,18 @@ let v5 = ([1 + 2 + 3, 4] as [UInt32]) + ([2 * 3] as [UInt32])
 let v6 = [1 + 2 + 3, 4] as Set<UInt32>
 let v7: [UInt32] = [55 * 8, 0]
 
-// SR-3668
+// https://github.com/apple/swift/issues/46253
 // "Expression was too complex" errors for short dictionary literals
 // of simple closure expressions
 
-let sr3668Dict1: Dictionary<Int, (Int, Int) -> Bool> =
+let _: Dictionary<Int, (Int, Int) -> Bool> =
   [  0: { $0 == $1 },  1: { $0 == $1 },  2: { $0 == $1 },  3: { $0 == $1 },
      4: { $0 == $1 },  5: { $0 == $1 },  6: { $0 == $1 },  7: { $0 == $1 },
      8: { $0 == $1 },  9: { $0 == $1 }, 10: { $0 == $1 }, 11: { $0 == $1 },
     12: { $0 == $1 }, 13: { $0 == $1 }, 14: { $0 == $1 }, 15: { $0 == $1 },
     16: { $0 == $1 }, 17: { $0 == $1 }, 18: { $0 == $1 }, 19: { $0 == $1 } ]
 
-let sr3668Dict2: [Int: (Int, Int) -> Bool] =
+let _: [Int: (Int, Int) -> Bool] =
   [  0: { $0 != $1 },  1: { $0 != $1 },  2: { $0 != $1 },  3: { $0 != $1 },
      4: { $0 != $1 },  5: { $0 != $1 },  6: { $0 != $1 },  7: { $0 != $1 },
      8: { $0 != $1 },  9: { $0 != $1 }, 10: { $0 != $1 }, 11: { $0 != $1 },
diff --git a/test/Sema/composition_extension.swift b/test/Sema/composition_extension.swift
@@ -1,8 +1,10 @@
 // RUN: %target-typecheck-verify-swift
 // RUN: %empty-directory(%t)
-// RUN: %target-swift-frontend -primary-file %s %S/Inputs/composition_extension_usage.swift -emit-module-path %t/P-partial.swiftmodule -module-name SR11227 -enable-testing
-// RUN: %target-swift-frontend -primary-file %S/Inputs/composition_extension_usage.swift %s -emit-module-path %t/S-partial.swiftmodule -module-name SR11227 -enable-testing
-// RUN: %target-swift-frontend -merge-modules -emit-module %t/P-partial.swiftmodule %t/S-partial.swiftmodule -o %t/SR11227.swiftmodule
+// RUN: %target-swift-frontend -primary-file %s %S/Inputs/composition_extension_usage.swift -emit-module-path %t/P-partial.swiftmodule -module-name M -enable-testing
+// RUN: %target-swift-frontend -primary-file %S/Inputs/composition_extension_usage.swift %s -emit-module-path %t/S-partial.swiftmodule -module-name M -enable-testing
+// RUN: %target-swift-frontend -merge-modules -emit-module %t/P-partial.swiftmodule %t/S-partial.swiftmodule -o %t/M.swiftmodule
+
+// https://github.com/apple/swift/issues/53628
 
 protocol P1 {}
 
diff --git a/test/Sema/diag_ambiguous_overloads_swift4.swift b/test/Sema/diag_ambiguous_overloads_swift4.swift
@@ -1,7 +1,7 @@
 // RUN: %target-typecheck-verify-swift -swift-version 4
 
-//=-------------- SR-7295 --------------=/
-class sr7295 {
+// https://github.com/apple/swift/issues/49843
+class C_49843 {
   func doSomething(a: (() -> Void)? = nil, completion: @escaping ((String, Error?) -> Void)) {}
   func doSomething(b: @escaping ((String, Error?, Bool) -> Void)) {}
   func a() {
diff --git a/test/Sema/diag_defer_block_end.swift b/test/Sema/diag_defer_block_end.swift
@@ -8,14 +8,17 @@ if (x > y) {
     }
 }
 
-func sr7307(_ value: Bool) {
-    let negated = !value 
-    defer { // expected-warning {{'defer' statement at end of scope always executes immediately}}{{5-10=do}}
-        print("negated value is \(negated)")
-    }
-}
+// https://github.com/apple/swift/issues/49855
+do {
+  func f(_ value: Bool) {
+      let negated = !value
+      defer { // expected-warning {{'defer' statement at end of scope always executes immediately}}{{7-12=do}}
+          print("negated value is \(negated)")
+      }
+  }
 
-sr7307(true)
+  f(true)
+}
 
 defer { // No note
     print("end of program.")
diff --git a/test/Sema/diag_get_vs_set_subscripts.swift b/test/Sema/diag_get_vs_set_subscripts.swift
@@ -1,26 +1,25 @@
 // RUN: %target-typecheck-verify-swift
 
-enum Key: Int {
-  case aKey
-  case anotherKey // expected-note {{'anotherKey' declared here}}
-}
- 
-class sr6175 {
-  var dict: [Key: String] = [:]
-  func what() -> Void {
-    dict[.notAKey] = "something" // expected-error {{type 'Key' has no member 'notAKey'; did you mean 'anotherKey'?}}
-  }
-  
-  subscript(i: Int) -> Int {
-    return i*i
+// https://github.com/apple/swift/issues/48727
+do {
+  enum Key: Int {
+    case aKey
+    case anotherKey // expected-note {{'anotherKey' declared here}}
   }
-  subscript(j: Double) -> Double {
-    get { return j*j }
-    set {}
+
+  class C {
+    var dict: [Key: String] = [:]
+    func what() -> Void {
+      dict[.notAKey] = "something" // expected-error {{type 'Key' has no member 'notAKey'; did you mean 'anotherKey'?}}
+    }
+
+    subscript(i: Int) -> Int { get {} }
+
+    subscript(j: Double) -> Double { get {} set {} }
   }
-}
 
-let s = sr6175()
-let one: Int = 1
-// Should choose the settable subscript to find a problem with, not the get-only subscript
-s[one] = 2.5 // expected-error {{cannot convert value of type 'Int' to expected argument type 'Double'}}
+  let c = C()
+  let one: Int = 1
+  // Should choose the settable subscript to find a problem with, not the get-only subscript
+  c[one] = 2.5 // expected-error {{cannot convert value of type 'Int' to expected argument type 'Double'}}
+}
diff --git a/test/Sema/diag_non_ephemeral.swift b/test/Sema/diag_non_ephemeral.swift
@@ -47,7 +47,8 @@ takesOptMutableRaw(&arr) // expected-error {{cannot use inout expression here; a
 // expected-note@-1 {{implicit argument conversion from '[Int8]' to 'UnsafeMutableRawPointer?' produces a pointer valid only for the duration of the call to 'takesOptMutableRaw'}}
 // expected-note@-2 {{use the 'withUnsafeMutableBytes' method on Array in order to explicitly convert argument to buffer pointer valid for a defined scope}}
 
-// FIXME(SR-9100): This currently uses inout-to-pointer instead of array-to-pointer.
+// FIXME: This currently uses inout-to-pointer instead of array-to-pointer
+// (https://github.com/apple/swift/issues/51597).
 takesOptMutableRaw(&optionalArr)
 
 takesOptConst(arr) // expected-error {{cannot pass '[Int8]' to parameter; argument #1 must be a pointer that outlives the call to 'takesOptConst'}}
diff --git a/test/Sema/diag_non_ephemeral_warning.swift b/test/Sema/diag_non_ephemeral_warning.swift
@@ -47,7 +47,8 @@ takesOptMutableRaw(&arr) // expected-warning {{cannot use inout expression here;
 // expected-note@-1 {{implicit argument conversion from '[Int8]' to 'UnsafeMutableRawPointer?' produces a pointer valid only for the duration of the call to 'takesOptMutableRaw'}}
 // expected-note@-2 {{use the 'withUnsafeMutableBytes' method on Array in order to explicitly convert argument to buffer pointer valid for a defined scope}}
 
-// FIXME(SR-9100): This currently uses inout-to-pointer instead of array-to-pointer.
+// FIXME: This currently uses inout-to-pointer instead of array-to-pointer
+// (https://github.com/apple/swift/issues/51597).
 takesOptMutableRaw(&optionalArr)
 
 takesOptConst(arr) // expected-warning {{cannot pass '[Int8]' to parameter; argument #1 must be a pointer that outlives the call to 'takesOptConst'}}
diff --git a/test/Sema/diag_type_conversion.swift b/test/Sema/diag_type_conversion.swift
@@ -73,15 +73,17 @@ _ = p =*= &o
 func rdar25963182(_ bytes: [UInt8] = nil) {}
 // expected-error@-1 {{nil default argument value cannot be converted to type}}
 
-// SR-13262
-struct SR13262_S {}
+// https://github.com/apple/swift/issues/55702
+do {
+  struct S {}
 
-func SR13262(_ x: Int) {}
-func SR13262_Int(_ x: Int) -> Int { 0 }
-func SR13262_SF(_ x: Int) -> SR13262_S { SR13262_S() }
+  func returnVoid(_ x: Int) {}
+  func returnInt(_ x: Int) -> Int {}
+  func returnS(_ x: Int) -> S {}
 
-func testSR13262(_ arr: [Int]) {
-  for x in arr where SR13262(x) {} // expected-error {{cannot convert value of type '()' to expected condition type 'Bool'}}
-  for x in arr where SR13262_Int(x) {} // expected-error {{type 'Int' cannot be used as a boolean; test for '!= 0' instead}} {{22-22=(}} {{36-36= != 0)}} 
-  for x in arr where SR13262_SF(x) {} // expected-error {{cannot convert value of type 'SR13262_S' to expected condition type 'Bool'}}
+  let arr: [Int]
+
+  for x in arr where returnVoid(x) {} // expected-error {{cannot convert value of type '()' to expected condition type 'Bool'}}
+  for x in arr where returnInt(x) {} // expected-error {{type 'Int' cannot be used as a boolean; test for '!= 0' instead}} {{22-22=(}} {{34-34= != 0)}}
+  for x in arr where returnS(x) {} // expected-error {{cannot convert value of type 'S' to expected condition type 'Bool'}}
 }
diff --git a/test/Sema/diag_unintended_optional_behavior_swift_5.swift b/test/Sema/diag_unintended_optional_behavior_swift_5.swift
@@ -104,10 +104,13 @@ func warnCollectionOfIUOToAnyCoercion(_ a: Int!) { // expected-note 2{{implicitl
   // expected-note@-7 {{explicitly cast to 'Any' with 'as Any' to silence this warning}}{{40-40= as Any}}
 }
 
-func takesAny_sr10199(_ x: Any) {}
-
-let fn_sr10199: (() -> Int?)! = { return nil }
-takesAny_sr10199(fn_sr10199()) // expected-warning {{expression implicitly coerced from 'Int?' to 'Any'}}
-// expected-note@-1 {{provide a default value to avoid this warning}}
-// expected-note@-2 {{force-unwrap the value to avoid this warning}}
-// expected-note@-3 {{explicitly cast to 'Any' with 'as Any' to silence this warning}}
+// https://github.com/apple/swift/issues/52599
+do {
+  func takesAny(_ x: Any) {}
+
+  let fn: (() -> Int?)! = { return nil }
+  takesAny(fn()) // expected-warning {{expression implicitly coerced from 'Int?' to 'Any'}}
+  // expected-note@-1 {{provide a default value to avoid this warning}}
+  // expected-note@-2 {{force-unwrap the value to avoid this warning}}
+  // expected-note@-3 {{explicitly cast to 'Any' with 'as Any' to silence this warning}}
+}
diff --git a/test/Sema/diag_use_before_declaration.swift b/test/Sema/diag_use_before_declaration.swift
diff --git a/test/Sema/immutability.swift b/test/Sema/immutability.swift
diff --git a/test/Sema/keypath_subscript_nolabel.swift b/test/Sema/keypath_subscript_nolabel.swift
diff --git a/test/Sema/property_wrappers.swift b/test/Sema/property_wrappers.swift
diff --git a/test/Sema/single_expression_closure.swift b/test/Sema/single_expression_closure.swift
diff --git a/test/Sema/suppress-argument-labels-in-types.swift b/test/Sema/suppress-argument-labels-in-types.swift
diff --git a/test/Sema/typo_correction.swift b/test/Sema/typo_correction.swift
diff --git a/test/Sema/where_clause_across_module_boundaries.swift b/test/Sema/where_clause_across_module_boundaries.swift

Original file line number	Diff line number	Diff line change
`@@ -207,13 +207,14 @@ extension Container {`
`207`	`207`	`fileprivate class PrivateGenericUser<T> where T: PrivateInnerClass {} // expected-error {{generic class cannot be declared fileprivate because its generic requirement uses a private type}} {{none}}`
`208`	`208`	`}`
`209`	`209`
`210`		`-fileprivate struct SR2579 {`
	`210`	`+// https://github.com/apple/swift/issues/45184`
	`211`	`+fileprivate struct C_45184 {`
`211`	`212`	`private struct Inner {`
`212`	`213`	`private struct InnerPrivateType {}`
`213`		`- var innerProperty = InnerPrivateType() // expected-error {{property must be declared private because its type 'SR2579.Inner.InnerPrivateType' uses a private type}}`
	`214`	`+ var innerProperty = InnerPrivateType() // expected-error {{property must be declared private because its type 'C_45184.Inner.InnerPrivateType' uses a private type}}`
`214`	`215`	`}`
`215`	`216`	`// FIXME: We need better errors when one access violation results in more`
`216`	`217`	`// downstream.`
`217`		`- private var outerProperty = Inner().innerProperty // expected-error {{property cannot be declared in this context because its type 'SR2579.Inner.InnerPrivateType' uses a private type}}`
`218`		`- var outerProperty2 = Inner().innerProperty // expected-error {{property must be declared private because its type 'SR2579.Inner.InnerPrivateType' uses a private type}}`
	`218`	`+ private var outerProperty = Inner().innerProperty // expected-error {{property cannot be declared in this context because its type 'C_45184.Inner.InnerPrivateType' uses a private type}}`
	`219`	`+ var outerProperty2 = Inner().innerProperty // expected-error {{property must be declared private because its type 'C_45184.Inner.InnerPrivateType' uses a private type}}`
`219`	`220`	`}`