Tests: Hard-skip spectests on Android

Author: kateinoigakukun

Tests/WATTests/Spectest.swift

@@ -17,25 +17,29 @@ enum Spectest {
     }
 
     static func wastFiles(include: [String] = [], exclude: [String] = ["annotations.wast"]) -> [URL] {
-        return [
-            testsuitePath,
-            testsuitePath.appendingPathComponent("proposals/memory64"),
-            testsuitePath.appendingPathComponent("proposals/tail-call"),
-            rootDirectory.appendingPathComponent("Tests/WasmKitTests/ExtraSuite"),
-        ].flatMap {
-            try! FileManager.default.contentsOfDirectory(at: $0, includingPropertiesForKeys: nil)
-        }.compactMap { filePath in
-            guard filePath.pathExtension == "wast" else {
-                return nil
+        #if os(Android)
+            return []
+        #else
+            return [
+                testsuitePath,
+                testsuitePath.appendingPathComponent("proposals/memory64"),
+                testsuitePath.appendingPathComponent("proposals/tail-call"),
+                rootDirectory.appendingPathComponent("Tests/WasmKitTests/ExtraSuite"),
+            ].flatMap {
+                try! FileManager.default.contentsOfDirectory(at: $0, includingPropertiesForKeys: nil)
+            }.compactMap { filePath in
+                guard filePath.pathExtension == "wast" else {
+                    return nil
+                }
+                guard !filePath.lastPathComponent.starts(with: "simd_") else { return nil }
+                if !include.isEmpty {
+                    guard include.contains(filePath.lastPathComponent) else { return nil }
+                } else {
+                    guard !exclude.contains(filePath.lastPathComponent) else { return nil }
+                }
+                return filePath
             }
-            guard !filePath.lastPathComponent.starts(with: "simd_") else { return nil }
-            if !include.isEmpty {
-                guard include.contains(filePath.lastPathComponent) else { return nil }
-            } else {
-                guard !exclude.contains(filePath.lastPathComponent) else { return nil }
-            }
-            return filePath
-        }
+        #endif
     }
 
     static func deriveFeatureSet(wast: URL) -> WasmFeatureSet {

Tests/WasmKitTests/FuzzTranslatorRegressionTests.swift

@@ -23,18 +23,20 @@
             }
         }
 
-        @Test(
-            .disabled("unable to run fuzz translator regression tests on Android due to missing files on emulator", platforms: [.android]),
-            arguments: try failCases()
-        )
-        func run(test: Case) throws {
-            let data = try Data(contentsOf: test.path)
-            do {
-                try WasmKitFuzzing.fuzzInstantiation(bytes: Array(data))
-            } catch {
-                // Skip exceptions without crash
+        #if !os(Android)
+            @Test(
+                .disabled("unable to run fuzz translator regression tests on Android due to missing files on emulator", platforms: [.android]),
+                arguments: try failCases()
+            )
+            func run(test: Case) throws {
+                let data = try Data(contentsOf: test.path)
+                do {
+                    try WasmKitFuzzing.fuzzInstantiation(bytes: Array(data))
+                } catch {
+                    // Skip exceptions without crash
+                }
             }
-        }
+        #endif
     }
 
 #endif

Tests/WasmKitTests/SpectestTests.swift

@@ -19,26 +19,28 @@
             ]
         }
 
-        @Test(
-            .disabled("unable to run spectest on Android due to missing files on emulator", platforms: [.android]),
-            arguments: try SpectestDiscovery(path: SpectestTests.testPaths).discover()
-        )
-        func run(test: TestCase) throws {
-            let defaultConfig = EngineConfiguration()
-            let runner = try SpectestRunner(configuration: defaultConfig)
-            try runner.run(test: test, reporter: NullSpectestProgressReporter())
-        }
+        #if !os(Android)
+            @Test(
+                .disabled("unable to run spectest on Android due to missing files on emulator", platforms: [.android]),
+                arguments: try SpectestDiscovery(path: SpectestTests.testPaths).discover()
+            )
+            func run(test: TestCase) throws {
+                let defaultConfig = EngineConfiguration()
+                let runner = try SpectestRunner(configuration: defaultConfig)
+                try runner.run(test: test, reporter: NullSpectestProgressReporter())
+            }
 
-        @Test(
-            .disabled("unable to run spectest on Android due to missing files on emulator", platforms: [.android]),
-            arguments: try SpectestDiscovery(path: SpectestTests.testPaths).discover()
-        )
-        func runWithTokenThreading(test: TestCase) throws {
-            let defaultConfig = EngineConfiguration()
-            guard defaultConfig.threadingModel != .token else { return }
-            // Sanity check that non-default threading models work.
-            let runner = try SpectestRunner(configuration: defaultConfig)
-            try runner.run(test: test, reporter: NullSpectestProgressReporter())
-        }
+            @Test(
+                .disabled("unable to run spectest on Android due to missing files on emulator", platforms: [.android]),
+                arguments: try SpectestDiscovery(path: SpectestTests.testPaths).discover()
+            )
+            func runWithTokenThreading(test: TestCase) throws {
+                let defaultConfig = EngineConfiguration()
+                guard defaultConfig.threadingModel != .token else { return }
+                // Sanity check that non-default threading models work.
+                let runner = try SpectestRunner(configuration: defaultConfig)
+                try runner.run(test: test, reporter: NullSpectestProgressReporter())
+            }
+        #endif
     }
 #endif