less embedded conditions and added comments

Author: sliemeobn

Sources/JavaScriptKit/FundamentalObjects/JSFunction.swift

@@ -84,8 +84,8 @@ public class JSFunction: JSObject, _JSFunctionProtocol {
     public var `throws`: JSThrowingFunction {
         JSThrowingFunction(self)
     }
+#endif
 
-#else
     @discardableResult
     public func callAsFunction(arguments: [JSValue]) -> JSValue {
         invokeNonThrowingJSFunction(arguments: arguments).jsValue
@@ -98,7 +98,6 @@ public class JSFunction: JSObject, _JSFunctionProtocol {
             }
         }
     }
-#endif
 
     @available(*, unavailable, message: "Please use JSClosure instead")
     public static func from(_: @escaping ([JSValue]) -> JSValue) -> JSFunction {
@@ -109,15 +108,15 @@ public class JSFunction: JSObject, _JSFunctionProtocol {
         .function(self)
     }
 
-#if hasFeature(Embedded)
     final func invokeNonThrowingJSFunction(arguments: [JSValue]) -> RawJSValue {
         arguments.withRawJSValues { invokeNonThrowingJSFunction(rawValues: $0) }
     }
 
     final func invokeNonThrowingJSFunction(arguments: [JSValue], this: JSObject) -> RawJSValue {
         arguments.withRawJSValues { invokeNonThrowingJSFunction(rawValues: $0, this: this) }
     }
-#else
+
+#if !hasFeature(Embedded)
     final func invokeNonThrowingJSFunction(arguments: [ConvertibleToJSValue]) -> RawJSValue {
         arguments.withRawJSValues { invokeNonThrowingJSFunction(rawValues: $0) }
     }
@@ -164,11 +163,14 @@ public class JSFunction: JSObject, _JSFunctionProtocol {
     }
 }
 
+/// Internal protocol to support generic arguments for `JSFunction`.
+/// 
+/// In Swift Embedded, non-final classes cannot have generic methods.
 public protocol _JSFunctionProtocol: JSFunction {}
 
 #if hasFeature(Embedded)
+// NOTE: once embedded supports variadic generics, we can remove these overloads
 public extension _JSFunctionProtocol {
-     // hand-made "varidacs" for Embedded
 
     @discardableResult
     func callAsFunction(this: JSObject) -> JSValue {

Sources/JavaScriptKit/FundamentalObjects/JSObject.swift

@@ -231,10 +231,14 @@ public class JSThrowingObject {
 }
 #endif
 
+/// Internal protocol to support generic arguments for `JSObject`.
+/// 
+/// In Swift Embedded, non-final classes cannot have generic methods.
 public protocol _JSObjectProtocol: JSObject {
 }
 
 #if hasFeature(Embedded)
+// NOTE: once embedded supports variadic generics, we can remove these overloads
 public extension _JSObjectProtocol {
     @_disfavoredOverload
     subscript(dynamicMember name: String) -> (() -> JSValue)? {

Sources/JavaScriptKit/FundamentalObjects/JSString.swift

@@ -31,12 +31,9 @@ public struct JSString: LosslessStringConvertible, Equatable {
             var bytesRef: JavaScriptObjectRef = 0
             let bytesLength = Int(swjs_encode_string(jsRef, &bytesRef))
             // +1 for null terminator
-            // TODO: revert this back to malloc and free
-            // let buffer = malloc(Int(bytesLength + 1))!.assumingMemoryBound(to: UInt8.self)
-            let buffer = UnsafeMutablePointer<UInt8>.allocate(capacity: Int(bytesLength + 1))
+            let buffer = UnsafeMutablePointer<UInt8>.allocate(capacity: bytesLength + 1)
             defer {
                 buffer.deallocate()
-                // free(buffer)
                 swjs_release(bytesRef)
             }
             swjs_load_string(bytesRef, buffer)

Sources/JavaScriptKit/FundamentalObjects/JSSymbol.swift

@@ -10,11 +10,7 @@ public class JSSymbol: JSObject {
 
     public init(_ description: JSString) {
         // can’t do `self =` so we have to get the ID manually
-    #if hasFeature(Embedded)
         let result = Symbol.invokeNonThrowingJSFunction(arguments: [description.jsValue])
-    #else
-        let result = Symbol.invokeNonThrowingJSFunction(arguments: [description])
-    #endif
         precondition(result.kind == .symbol)
         super.init(id: UInt32(result.payload1))
     }