Fix PackageToJS plugin wasm-opt fallback when output file exists

When wasm-opt is not installed, PackageToJS plugin falls back to copying
the input Wasm file directly to output. However, FileManager.copyItem
fails if the destination file already exists, while wasm-opt overwrites
existing files.

Changes:
- Remove existing output file before copying in wasm-opt fallback
- Add comprehensive test suite for wasm-opt fallback behavior
- Test both missing wasm-opt and existing output file scenarios

Fixes issue where builds fail with 'File exists' error when wasm-opt
is unavailable and output file already exists from previous builds.

Author: kateinoigakukun

Plugins/PackageToJS/Sources/PackageToJS.swift

@@ -309,6 +309,10 @@ final class DefaultPackagingSystem: PackagingSystem {
     func wasmOpt(_ arguments: [String], input: String, output: String) throws {
         guard let wasmOpt = try? which("wasm-opt") else {
             _ = warnMissingWasmOpt
+            // Remove existing output file if it exists (to match wasm-opt behavior)
+            if FileManager.default.fileExists(atPath: output) {
+                try FileManager.default.removeItem(atPath: output)
+            }
             try FileManager.default.copyItem(atPath: input, toPath: output)
             return
         }

Plugins/PackageToJS/Tests/FileManagerCopyBugTest.swift

@@ -0,0 +1,68 @@
+import Foundation
+import Testing
+
+@testable import PackageToJS
+
+@Suite struct FileManagerCopyBugTest {
+    
+    @Test func copyItemFailsWhenDestinationExists() throws {
+        try withTemporaryDirectory { tempDir, _ in
+            let inputFile = tempDir.appendingPathComponent("input.wasm")
+            let outputFile = tempDir.appendingPathComponent("output.wasm")
+            let inputContent = Data("input content".utf8)
+            let existingContent = Data("existing content".utf8)
+            
+            // Create input file
+            try inputContent.write(to: inputFile)
+            // Create existing output file
+            try existingContent.write(to: outputFile)
+            
+            // Try to copy - this should fail because destination exists
+            #expect(throws: (any Error).self) {
+                try FileManager.default.copyItem(atPath: inputFile.path, toPath: outputFile.path)
+            }
+        }
+    }
+    
+    @Test func defaultPackagingSystemHandlesExistingFileCorrectly() throws {
+        try withTemporaryDirectory { tempDir, _ in
+            let inputFile = tempDir.appendingPathComponent("input.wasm")
+            let outputFile = tempDir.appendingPathComponent("output.wasm")
+            let inputContent = Data("input content".utf8)
+            let existingContent = Data("existing content".utf8)
+            
+            // Create input file
+            try inputContent.write(to: inputFile)
+            // Create existing output file
+            try existingContent.write(to: outputFile)
+            
+            var warnings: [String] = []
+            let system = DefaultPackagingSystem { warning in
+                warnings.append(warning)
+            }
+            
+            // Temporarily remove wasm-opt if it exists to force fallback behavior
+            let wasmOptPath = "/opt/homebrew/bin/wasm-opt"
+            let backupPath = "/tmp/wasm-opt-backup-test"
+            let wasmOptExists = FileManager.default.fileExists(atPath: wasmOptPath)
+            
+            if wasmOptExists {
+                try? FileManager.default.moveItem(atPath: wasmOptPath, toPath: backupPath)
+            }
+            
+            defer {
+                if wasmOptExists {
+                    try? FileManager.default.moveItem(atPath: backupPath, toPath: wasmOptPath)
+                }
+            }
+            
+            // This should work - fallback should handle existing file
+            try system.wasmOpt(["-Os"], input: inputFile.path, output: outputFile.path)
+            
+            // Verify the output file was overwritten with input content
+            let finalContent = try Data(contentsOf: outputFile)
+            #expect(finalContent == inputContent)
+            #expect(warnings.contains { $0.contains("wasm-opt is not installed") })
+        }
+    }
+}

Plugins/PackageToJS/Tests/WasmOptTests.swift

@@ -0,0 +1,160 @@
+import Foundation
+import Testing
+
+@testable import PackageToJS
+
+@Suite struct WasmOptTests {
+    
+    /// A mock system that simulates wasm-opt not being available
+    class MockPackagingSystemWithoutWasmOpt: PackagingSystem {
+        var warnings: [String] = []
+        var wasmOptCalls: [(arguments: [String], input: String, output: String)] = []
+        
+        func npmInstall(packageDir: String) throws {
+            // No-op for testing
+        }
+        
+        func wasmOpt(_ arguments: [String], input: String, output: String) throws {
+            wasmOptCalls.append((arguments, input, output))
+            
+            // Simulate wasm-opt not found by using the same logic as DefaultPackagingSystem
+            // but without the actual which() call succeeding
+            warnings.append("Warning: wasm-opt is not installed, optimizations will not be applied")
+            
+            // Test the file copy logic that would happen when wasm-opt is not found
+            // (This matches the fixed behavior that removes existing files first)
+            if FileManager.default.fileExists(atPath: output) {
+                try FileManager.default.removeItem(atPath: output)
+            }
+            try FileManager.default.copyItem(atPath: input, toPath: output)
+        }
+    }
+    
+    /// A mock system that fails when copying files (to test error handling)
+    class MockPackagingSystemWithCopyFailure: PackagingSystem {
+        var wasmOptCalls: [(arguments: [String], input: String, output: String)] = []
+        
+        func npmInstall(packageDir: String) throws {
+            // No-op for testing
+        }
+        
+        func wasmOpt(_ arguments: [String], input: String, output: String) throws {
+            wasmOptCalls.append((arguments, input, output))
+            
+            // Simulate the case where wasm-opt is not found and file copy fails
+            throw PackageToJSError("Permission denied when copying wasm file")
+        }
+    }
+    
+    @Test func wasmOptNotInstalledFallbackWorksCorrectly() throws {
+        try withTemporaryDirectory { tempDir, _ in
+            // Create a dummy input wasm file
+            let inputFile = tempDir.appendingPathComponent("input.wasm")
+            let outputFile = tempDir.appendingPathComponent("output.wasm")
+            let dummyContent = Data("dummy wasm content".utf8)
+            try dummyContent.write(to: inputFile)
+            
+            let mockSystem = MockPackagingSystemWithoutWasmOpt()
+            
+            // This should copy the file instead of optimizing
+            try mockSystem.wasmOpt(["-Os"], input: inputFile.path, output: outputFile.path)
+            
+            // Verify the file was copied
+            #expect(FileManager.default.fileExists(atPath: outputFile.path))
+            let copiedContent = try Data(contentsOf: outputFile)
+            #expect(copiedContent == dummyContent)
+            
+            // Verify warning was recorded
+            #expect(mockSystem.warnings.count == 1)
+            #expect(mockSystem.warnings[0].contains("wasm-opt is not installed"))
+            
+            // Verify the call was made
+            #expect(mockSystem.wasmOptCalls.count == 1)
+            #expect(mockSystem.wasmOptCalls[0].arguments == ["-Os"])
+        }
+    }
+    
+    @Test func wasmOptNotInstalledHandlesExistingOutputFile() throws {
+        try withTemporaryDirectory { tempDir, _ in
+            // Create a dummy input wasm file
+            let inputFile = tempDir.appendingPathComponent("input.wasm")
+            let outputFile = tempDir.appendingPathComponent("output.wasm")
+            let inputContent = Data("input wasm content".utf8)
+            let existingContent = Data("existing output content".utf8)
+            
+            try inputContent.write(to: inputFile)
+            try existingContent.write(to: outputFile)
+            
+            let mockSystem = MockPackagingSystemWithoutWasmOpt()
+            
+            // This should overwrite the existing output file
+            try mockSystem.wasmOpt(["-Os"], input: inputFile.path, output: outputFile.path)
+            
+            // Verify the output file has the input content (not the existing content)
+            #expect(FileManager.default.fileExists(atPath: outputFile.path))
+            let finalContent = try Data(contentsOf: outputFile)
+            #expect(finalContent == inputContent)
+            #expect(finalContent != existingContent)
+        }
+    }
+    
+    @Test func wasmOptCopyFailureThrowsError() throws {
+        try withTemporaryDirectory { tempDir, _ in
+            let inputFile = tempDir.appendingPathComponent("input.wasm")
+            let outputFile = tempDir.appendingPathComponent("output.wasm")
+            
+            let mockSystem = MockPackagingSystemWithCopyFailure()
+            
+            // This should throw an error
+            #expect(throws: PackageToJSError.self) {
+                try mockSystem.wasmOpt(["-Os"], input: inputFile.path, output: outputFile.path)
+            }
+            
+            // Verify the call was made
+            #expect(mockSystem.wasmOptCalls.count == 1)
+        }
+    }
+    
+    @Test func realDefaultPackagingSystemFallbackBehavior() throws {
+        try withTemporaryDirectory { tempDir, _ in
+            // Create a dummy input wasm file
+            let inputFile = tempDir.appendingPathComponent("input.wasm")
+            let outputFile = tempDir.appendingPathComponent("output.wasm")
+            let dummyContent = Data("dummy wasm content".utf8)
+            try dummyContent.write(to: inputFile)
+            
+            var capturedWarnings: [String] = []
+            let realSystem = DefaultPackagingSystem { warning in
+                capturedWarnings.append(warning)
+            }
+            
+            // Temporarily move wasm-opt out of the way to simulate it not being installed
+            let wasmOptPath = "/opt/homebrew/bin/wasm-opt"
+            let tempWasmOptPath = "/tmp/wasm-opt-backup-for-test"
+            
+            let wasmOptExists = FileManager.default.fileExists(atPath: wasmOptPath)
+            if wasmOptExists {
+                try? FileManager.default.moveItem(atPath: wasmOptPath, toPath: tempWasmOptPath)
+            }
+            
+            defer {
+                // Restore wasm-opt if it existed
+                if wasmOptExists {
+                    try? FileManager.default.moveItem(atPath: tempWasmOptPath, toPath: wasmOptPath)
+                }
+            }
+            
+            // This should fall back to copying since wasm-opt is not available
+            try realSystem.wasmOpt(["-Os"], input: inputFile.path, output: outputFile.path)
+            
+            // Verify the file was copied
+            #expect(FileManager.default.fileExists(atPath: outputFile.path))
+            let copiedContent = try Data(contentsOf: outputFile)
+            #expect(copiedContent == dummyContent)
+            
+            // Verify warning was issued
+            #expect(capturedWarnings.count >= 1)
+            #expect(capturedWarnings[0].contains("wasm-opt is not installed"))
+        }
+    }
+}