lint and type-check TypeScript scripts in CI (#1815)

Author: matthewbastien

package-lock.json

@@ -1962,7 +1962,7 @@
     "watch": "npm run compile -- --watch",
     "compile-documentation-webview": "del-cli ./assets/documentation-webview && esbuild ./src/documentation/webview/webview.ts --bundle --outfile=assets/documentation-webview/index.js --define:process.env.NODE_ENV=\\\"production\\\" --define:process.env.CI=\\\"\\\" --format=cjs --sourcemap",
     "watch-documentation-webview": "npm run compile-documentation-webview -- --watch",
-    "lint": "eslint ./ --ext ts && tsc --noEmit",
+    "lint": "eslint ./ --ext ts && tsc --noEmit && tsc --noEmit -p scripts/tsconfig.json",
     "update-swift-docc-render": "tsx ./scripts/update_swift_docc_render.ts",
     "compile-icons": "tsx ./scripts/compile_icons.ts",
     "format": "prettier --check .",
@@ -2002,6 +2002,9 @@
     "@types/semver": "^7.7.0",
     "@types/sinon": "^17.0.4",
     "@types/sinon-chai": "^3.2.12",
+    "@types/svg2ttf": "^5.0.3",
+    "@types/svgicons2svgfont": "^10.0.5",
+    "@types/ttf2woff": "^2.0.4",
     "@types/vscode": "^1.88.0",
     "@types/xml2js": "^0.4.14",
     "@typescript-eslint/eslint-plugin": "^8.39.1",

package.json

@@ -15,7 +15,6 @@
 
 import { getExtensionVersion, main } from "./lib/utilities";
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 main(async () => {
     const version = await getExtensionVersion();
     if (version.minor % 2 !== 0) {

scripts/check_package_json.ts

@@ -51,7 +51,6 @@ function minifyIcon(icon: string, color: string = "#424242"): string {
     }).data;
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 main(async () => {
     const iconsSourceDirectory = path.join(__dirname, "../src/icons");
     const iconAssetsDirectory = path.join(__dirname, "../assets/icons");

scripts/compile_icons.ts

@@ -15,7 +15,6 @@
 
 import { getExtensionVersion, main, packageExtension } from "./lib/utilities";
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 main(async () => {
     const version = await getExtensionVersion();
     const devVersion = `${version.major}.${version.minor}.${version.patch}-dev`;

scripts/dev_package.ts

@@ -13,14 +13,12 @@
 //===----------------------------------------------------------------------===//
 /* eslint-disable no-console */
 
-import * as DecompressType from "decompress";
+import decompress from "decompress";
 import { createWriteStream } from "node:fs";
 import { appendFile, unlink } from "node:fs/promises";
 import { pipeline } from "node:stream/promises";
 import { Octokit } from "octokit";
-
-// eslint-disable-next-line @typescript-eslint/no-require-imports
-const decompress: typeof DecompressType = require("decompress");
+import { main } from "./lib/utilities";
 
 const artifact_id = process.env["VSCODE_SWIFT_VSIX_ID"];
 if (!artifact_id) {
@@ -41,8 +39,7 @@ const repository = process.env["GITHUB_REPOSITORY"] || "swiftlang/vscode-swift";
 const owner = repository.split("/")[0];
 const repo = repository.split("/")[1];
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
-(async function () {
+main(async function () {
     const octokit = new Octokit({
         auth: token,
     });
@@ -90,4 +87,4 @@ const repo = repository.split("/")[1];
         }
     }
     await unlink("artifacts.zip");
-})();
+});

scripts/download_vsix.ts

@@ -27,13 +27,11 @@ import { replaceInFile } from "replace-in-file";
  *
  * @param mainFn The main function of the script that will be run.
  */
-export async function main(mainFn: () => Promise<void>): Promise<void> {
-    try {
-        await mainFn();
-    } catch (error) {
+export function main(mainFn: () => Promise<void>) {
+    mainFn().catch(error => {
         console.error(error);
         process.exit(1);
-    }
+    });
 }
 
 /**

scripts/lib/utilities.ts

@@ -15,7 +15,6 @@
 
 import { getExtensionVersion, main, packageExtension } from "./lib/utilities";
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 main(async () => {
     const version = await getExtensionVersion();
     // Leave the "prerelease" tag out

scripts/package.ts

@@ -27,7 +27,6 @@ function formatDate(date: Date): string {
     return year + month + day;
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 main(async () => {
     const version = await getExtensionVersion();
     // Decrement the minor version and set the patch version to today's date

scripts/preview_package.ts

@@ -2,8 +2,8 @@
   "compilerOptions": {
     "composite": true,
 
-    "rootDir": ".",
-    "outDir": "dist",
+    "rootDir": "..",
+    "outDir": "../dist",
 
     "lib": ["ES2021"],
     "target": "ES2020",
@@ -15,5 +15,6 @@
     "sourceMap": true,
 
     "types": []
-  }
+  },
+  "include": ["**/*.ts", "../src/icons/**/*.ts"]
 }