Improve user feedback if SourceKit-LSP is disabled (#1308)

* Improve user feedback if SourceKit-LSP is disabled

Add some notifications to let users know that several things won't work
as expected if SourceKit-LSP is disabled.

Issue: #892

* Add option to enable sourcekit-lsp in test warning

Change the messaging to strongly suggest that no testing features will
be available and add an option to allow the user to turn on
sourcekit-lsp from the warning prompt in Test Explorer.

Issue: #892

Author: rbenegal

package.json

@@ -576,7 +576,7 @@
           "swift.sourcekit-lsp.disable": {
             "type": "boolean",
             "default": false,
-            "markdownDescription": "Disable SourceKit-LSP",
+            "markdownDescription": "Disable SourceKit-LSP. This will turn off features like code completion, error diagnostics and jump-to-definition. Features like swift-testing test discovery will not work correctly.",
             "order": 6
           },
           "sourcekit-lsp.inlayHints.enabled": {

src/TestExplorer/TestExplorer.ts

@@ -261,6 +261,34 @@ export class TestExplorer {
     async discoverTestsInWorkspaceSPM(token: vscode.CancellationToken) {
         async function runDiscover(explorer: TestExplorer, firstTry: boolean) {
             try {
+                // we depend on sourcekit-lsp to detect swift-testing tests so let the user know
+                // that things won't work properly if sourcekit-lsp has been disabled for some reason
+                // and provide an option to enable sourcekit-lsp again
+                const ok = "OK";
+                const enable = "Enable SourceKit-LSP";
+                if (firstTry && configuration.lsp.disable === true) {
+                    vscode.window
+                        .showInformationMessage(
+                            `swift-testing tests will not be detected since SourceKit-LSP
+                            has been disabled for this workspace.`,
+                            enable,
+                            ok
+                        )
+                        .then(selected => {
+                            if (selected === enable) {
+                                explorer.folderContext.workspaceContext.outputChannel.log(
+                                    `Enabling SourceKit-LSP after swift-testing message`
+                                );
+                                vscode.workspace
+                                    .getConfiguration("swift")
+                                    .update("sourcekit-lsp.disable", false);
+                            } else if (selected === ok) {
+                                explorer.folderContext.workspaceContext.outputChannel.log(
+                                    `User acknowledged that SourceKit-LSP is disabled`
+                                );
+                            }
+                        });
+                }
                 const toolchain = explorer.folderContext.workspaceContext.toolchain;
                 // get build options before build is run so we can be sure they aren't changed
                 // mid-build

src/sourcekit-lsp/LanguageClientManager.ts

@@ -225,8 +225,8 @@ export class LanguageClientManager implements vscode.Disposable {
                         // Language client is already stopped
                         return;
                     }
-                    message =
-                        "You have disabled the Swift language server, but it is still running. Would you like to stop it now?";
+                    message = `You have disabled the Swift language server, but it is still running. Would you like to stop it now?
+                        This will turn off features such as code completion, error diagnostics, jump-to-definition, and test discovery.`;
                     restartLSPButton = "Stop Language Server";
                 } else {
                     if (this.state !== State.Stopped) {