Fix missing windows diagnostics (#1305)

Use the Uri's fsPath right away so we don't need to
worry about mismatches downstream

Issue: #1304

Author: award999

src/DiagnosticsManager.ts

@@ -360,7 +360,7 @@ export class DiagnosticsManager implements vscode.Disposable {
         if (!match) {
             return;
         }
-        const uri = match[1];
+        const uri = vscode.Uri.file(match[1]).fsPath;
         const message = this.capitalize(match[5]).trim();
         const range = this.range(match[2], match[3]);
         const severity = this.severity(match[4]);

test/integration-tests/DiagnosticsManager.test.ts

@@ -157,7 +157,7 @@ suite("DiagnosticsManager Test Suite", async function () {
                 ([_uri, diagnostics]) => diagnostics.length > 0
             );
             console.error(
-                `${title} - Not all diagnostics were fulfilled`,
+                `${title} - Not all diagnostics were fulfilled. Remaining:`,
                 JSON.stringify(remainingDiagnostics, undefined, " ")
             );
         }