Support swift-testing issue severity (#1814)

Add support for swift-testing issue severity, added in
swiftlang/swift-testing#1279

If an issue is recorded with a severity that does not meet the threshold
for a failure then don't record the issue.

Author: plemarquand

src/TestExplorer/TestParsers/SwiftTestingOutputParser.ts

@@ -155,13 +155,16 @@ interface IssueRecorded extends BaseEvent, TestCaseEvent {
     issue: {
         isKnown: boolean;
         sourceLocation: SourceLocation;
+        isFailure?: boolean;
+        severity?: string;
     };
 }
 
 export enum TestSymbol {
     default = "default",
     skip = "skip",
     passWithKnownIssue = "passWithKnownIssue",
+    passWithWarnings = "passWithWarnings",
     fail = "fail",
     pass = "pass",
     difference = "difference",
@@ -378,6 +381,10 @@ export class SwiftTestingOutputParser {
             .map(message => MessageRenderer.render(message))
             .join("\n");
 
+        if (payload.issue.isFailure === false) {
+            return;
+        }
+
         issues.forEach(message => {
             runState.recordIssue(
                 testIndex,
@@ -601,6 +608,7 @@ export class SymbolRenderer {
                     return "\u{25CA}"; // Unicode: LOZENGE
                 case TestSymbol.skip:
                 case TestSymbol.passWithKnownIssue:
+                case TestSymbol.passWithWarnings:
                 case TestSymbol.fail:
                     return "\u{279C}"; // Unicode: HEAVY ROUND-TIPPED RIGHTWARDS ARROW
                 case TestSymbol.pass:
@@ -622,6 +630,7 @@ export class SymbolRenderer {
                     return "\u{25C7}"; // Unicode: WHITE DIAMOND
                 case TestSymbol.skip:
                 case TestSymbol.passWithKnownIssue:
+                case TestSymbol.passWithWarnings:
                 case TestSymbol.fail:
                     return "\u{279C}"; // Unicode: HEAVY ROUND-TIPPED RIGHTWARDS ARROW
                 case TestSymbol.pass:

src/debugger/buildConfig.ts

@@ -538,11 +538,17 @@ export class TestingConfigurationFactory {
             );
         }
 
+        // Starting in 6.3 the version string should match the toolchain version.
+        let versionString = "0";
+        if (this.ctx.toolchain.swiftVersion.isGreaterThanOrEqual(new Version(6, 3, 0))) {
+            versionString = `${this.ctx.toolchain.swiftVersion.major}.${this.ctx.toolchain.swiftVersion.minor}`;
+        }
+
         const swiftTestingArgs = [
             ...this.ctx.toolchain.buildFlags.withAdditionalFlags(args),
             "--enable-swift-testing",
-            "--event-stream-version",
-            "0",
+            "--experimental-event-stream-version",
+            versionString,
             "--event-stream-output-path",
             this.swiftTestingArguments.fifoPipePath,
         ];

test/integration-tests/testexplorer/SwiftTestingOutputParser.test.ts

@@ -302,4 +302,38 @@ suite("SwiftTestingOutputParser Suite", () => {
             },
         ]);
     });
+
+    test("Issue with isFailure: false isn't recorded", async () => {
+        const issueLocation = {
+            _filePath: "file:///some/file.swift",
+            line: 1,
+            column: 2,
+        };
+        const issueEvent = testEvent(
+            "issueRecorded",
+            "MyTests.MyTests/testWarning()",
+            [{ text: "This is a warning", symbol: TestSymbol.warning }],
+            issueLocation
+        );
+        (issueEvent.payload as any).issue.isFailure = false;
+
+        const events = new TestEventStream([
+            testEvent("runStarted"),
+            testEvent("testCaseStarted", "MyTests.MyTests/testWarning()"),
+            issueEvent,
+            testEvent("testCaseEnded", "MyTests.MyTests/testWarning()"),
+            testEvent("runEnded"),
+        ]);
+
+        await outputParser.watch("file:///mock/named/pipe", testRunState, events);
+
+        assert.deepEqual(testRunState.tests, [
+            {
+                name: "MyTests.MyTests/testWarning()",
+                status: TestStatus.passed,
+                timing: { timestamp: 0 },
+                output: [],
+            },
+        ]);
+    });
 });