Add LocalVariableUtils

atrick · atrick · commit ffe9c489767a · 2024-03-05T18:08:16.000-08:00
This includes a reaching-def analysis that can be used by diagnostic passes. Diagnostics should be flow-sensitive.
diff --git a/SwiftCompilerSources/Sources/Optimizer/Utilities/CMakeLists.txt b/SwiftCompilerSources/Sources/Optimizer/Utilities/CMakeLists.txt
@@ -15,6 +15,7 @@ swift_compiler_sources(Optimizer
   ForwardingUtils.swift
   FunctionSignatureTransforms.swift
   LifetimeDependenceUtils.swift
+  LocalVariableUtils.swift
   OptUtils.swift
   OwnershipLiveness.swift
   SSAUpdater.swift
diff --git a/SwiftCompilerSources/Sources/Optimizer/Utilities/ForwardingUtils.swift b/SwiftCompilerSources/Sources/Optimizer/Utilities/ForwardingUtils.swift
@@ -386,7 +386,7 @@ extension NonEscapingClosureDefUseWalker: ForwardingDefUseWalker {
   mutating func nonForwardingUse(of operand: Operand) -> WalkResult {
     // Nonescaping closures may be moved, copied, or borrowed.
     if let transition = operand.instruction as? OwnershipTransitionInstruction {
-      return walkDownUses(of: transition, using: operand)
+      return walkDownUses(of: transition.ownershipResult, using: operand)
     }
     // Otherwise, assume the use cannot propagate the closure context.
     return closureContextLeafUse(of: operand)
diff --git a/SwiftCompilerSources/Sources/Optimizer/Utilities/LocalVariableUtils.swift b/SwiftCompilerSources/Sources/Optimizer/Utilities/LocalVariableUtils.swift

Original file line number	Diff line number	Diff line change
`@@ -386,7 +386,7 @@ extension NonEscapingClosureDefUseWalker: ForwardingDefUseWalker {`
`386`	`386`	`mutating func nonForwardingUse(of operand: Operand) -> WalkResult {`
`387`	`387`	`// Nonescaping closures may be moved, copied, or borrowed.`
`388`	`388`	`if let transition = operand.instruction as? OwnershipTransitionInstruction {`
`389`		`- return walkDownUses(of: transition, using: operand)`
	`389`	`+ return walkDownUses(of: transition.ownershipResult, using: operand)`
`390`	`390`	`}`
`391`	`391`	`// Otherwise, assume the use cannot propagate the closure context.`
`392`	`392`	`return closureContextLeafUse(of: operand)`