[NFC] IRGen: Renamed method.

Author: nate-chandler

lib/IRGen/Outlining.cpp

@@ -150,7 +150,7 @@ irgen::getTypeAndGenericSignatureForManglingOutlineFunction(SILType type) {
           env->getGenericSignature().getCanonicalSignature()};
 }
 
-bool TypeInfo::withMetadataCollector(
+bool TypeInfo::withWitnessableMetadataCollector(
     IRGenFunction &IGF, SILType T, LayoutIsNeeded_t needsLayout,
     DeinitIsNeeded_t needsDeinit,
     llvm::function_ref<void(OutliningMetadataCollector &)> invocation) const {
@@ -177,11 +177,11 @@ bool TypeInfo::withMetadataCollector(
 void TypeInfo::callOutlinedCopy(IRGenFunction &IGF, Address dest, Address src,
                                 SILType T, IsInitialization_t isInit,
                                 IsTake_t isTake) const {
-  if (withMetadataCollector(IGF, T, LayoutIsNeeded, DeinitIsNotNeeded,
-                            [&](auto collector) {
-                              collector.emitCallToOutlinedCopy(
-                                  dest, src, T, *this, isInit, isTake);
-                            })) {
+  if (withWitnessableMetadataCollector(
+          IGF, T, LayoutIsNeeded, DeinitIsNotNeeded, [&](auto collector) {
+            collector.emitCallToOutlinedCopy(dest, src, T, *this, isInit,
+                                             isTake);
+          })) {
     return;
   }
 
@@ -376,7 +376,7 @@ void TypeInfo::callOutlinedDestroy(IRGenFunction &IGF,
   if (IGF.IGM.getTypeLowering(T).isTrivial())
     return;
 
-  if (withMetadataCollector(
+  if (withWitnessableMetadataCollector(
           IGF, T, LayoutIsNeeded, DeinitIsNeeded, [&](auto collector) {
             collector.emitCallToOutlinedDestroy(addr, T, *this);
           })) {

lib/IRGen/Outlining.h

@@ -10,7 +10,7 @@
 //
 //===----------------------------------------------------------------------===//
 //
-// This file defines interfaces for outlining value witnesses.
+// This file defines interfaces for outlined value witnesses.
 //
 //===----------------------------------------------------------------------===//
 

lib/IRGen/TypeInfo.h

@@ -570,12 +570,13 @@ class TypeInfo {
   virtual void verify(IRGenTypeVerifierFunction &IGF,
                       llvm::Value *typeMetadata,
                       SILType T) const;
-  /// Perform \p invocation with the appropriate metadata collector if there is
-  /// one.
+  /// Perform \p invocation with the appropriate metadata collector for use in
+  /// emitting an outlined value function of a value operation that can be
+  /// performed with a value witness.
   ///
-  /// Returns whether there was an appropriate metadata collector (and whether
-  /// \p invocation was called.
-  bool withMetadataCollector(
+  /// Returns whether there was an appropriate emitter (and whether \p
+  /// invocation was called).
+  bool withWitnessableMetadataCollector(
       IRGenFunction &IGF, SILType T, LayoutIsNeeded_t needsLayout,
       DeinitIsNeeded_t needsDeinit,
       llvm::function_ref<void(OutliningMetadataCollector &)> invocation) const;