Review feedback

Author: Catfish-Man

test/api-digester/stability-stdlib-abi-without-asserts.test

@@ -65,6 +65,8 @@ Protocol CodingKey has added inherited protocol Sendable
 Protocol CodingKey has generic signature change from <Self : Swift.CustomDebugStringConvertible, Self : Swift.CustomStringConvertible> to <Self : Swift.CustomDebugStringConvertible, Self : Swift.CustomStringConvertible, Self : Swift.Sendable>
 Protocol Error has added inherited protocol Sendable
 Protocol Error has generic signature change from to <Self : Swift.Sendable>
+Constructor _SmallString.init(taggedCocoa:) has mangled name changing from 'Swift._SmallString.init(taggedCocoa: Swift.AnyObject) -> Swift._SmallString' to 'Swift._SmallString.init(taggedCocoa: Swift.AnyObject) -> Swift.Optional<Swift._SmallString>'
+Constructor _SmallString.init(taggedCocoa:) has return type change from Swift._SmallString to Swift._SmallString?
 Enum Never has added a conformance to an existing protocol Identifiable
 
 // These haven't actually been removed; they are simply marked unavailable.

test/stdlib/Inputs/NSSlowTaggedLocalizedString/NSSlowTaggedLocalizedString.m

@@ -78,9 +78,7 @@ - (id)copyWithZone:(id)unused {
 }
 
 - (uint16_t)characterAtIndex:(NSUInteger)index {
-  abort();
   if (index >= [self length]) {
-    //throw the appropriate exception
     abort();
   }
   return (uint16_t)contents[index];
@@ -102,6 +100,7 @@ - (id) description {
 }
 
 - (BOOL)getBytes:(void *)buffer maxLength:(uint64_t)max usedLength:(uint64_t *)used encoding:(uint64_t)encoding options:(uint64_t)options range:(NSRange)range remainingRange:(NSRange *)leftover {
+  assert(encoding == kCFStringEncodingASCII || encoding == kCFStringEncodingUTF8);
   strncpy(buffer, contents, max);
   if (strlen(contents) > max) {
     leftover->location = max;