Merge pull request #70984 from hamishknight/fix-diag

[Sema] Avoid mentioning `then` in a diagnostic

Author: hamishknight

include/swift/AST/DiagnosticsSema.def

@@ -1274,8 +1274,7 @@ ERROR(single_value_stmt_branch_empty,none,
       "expected expression in branch of '%0' expression",
       (StmtKind))
 ERROR(single_value_stmt_branch_must_end_in_result,none,
-      "non-expression branch of '%0' expression may only end with a 'throw' "
-      "or 'then'",
+      "non-expression branch of '%0' expression may only end with a 'throw'",
       (StmtKind))
 ERROR(cannot_jump_in_single_value_stmt,none,
       "cannot '%0' in '%1' when used as expression",

lib/Sema/MiscDiagnostics.cpp

@@ -3938,6 +3938,8 @@ class SingleValueStmtUsageChecker final : public ASTWalker {
               continue;
             }
           }
+          // TODO: If 'then' statements are enabled by default, the wording of
+          // this diagnostic should be tweaked.
           Diags.diagnose(branch->getEndLoc(),
                          diag::single_value_stmt_branch_must_end_in_result,
                          S->getKind());