Merge pull request #64210 from eeckstein/always-inline-closures

SILGen: Closures within @inline(__always) functions should be always inlined, too

Author: eeckstein

lib/SIL/IR/SILDeclRef.cpp

@@ -931,10 +931,20 @@ bool SILDeclRef::isNoinline() const {
 
 /// True if the function has the @inline(__always) attribute.
 bool SILDeclRef::isAlwaysInline() const {
-  if (!hasDecl())
+  swift::Decl *decl = nullptr;
+  if (hasDecl()) {
+    decl = getDecl();
+  } else if (auto *ce = getAbstractClosureExpr()) {
+    // Closures within @inline(__always) functions should be always inlined, too.
+    // Note that this is different from @inline(never), because closures inside
+    // @inline(never) _can_ be inlined within the inline-never function.
+    decl = ce->getParent()->getInnermostDeclarationDeclContext();
+    if (!decl)
+      return false;
+  } else {
     return false;
+  }
 
-  auto *decl = getDecl();
   if (auto attr = decl->getAttrs().getAttribute<InlineAttr>())
     if (attr->getKind() == InlineKind::Always)
       return true;

test/SILGen/inline_always.swift

@@ -4,6 +4,13 @@
 @inline(__always)
 func always_inline_callee() {}
 
+// CHECK-LABEL: sil hidden [always_inline] [ossa] @$s13inline_always11testClosureyyF
+@inline(__always)
+func testClosure() {
+  // CHECK-LABEL: sil private [always_inline] [ossa] @$s13inline_always11testClosureyyFyycfU_
+  _ = { }
+}
+
 protocol AlwaysInline {
   func alwaysInlined()
 }

test/SILOptimizer/inlinealways_and_closure.swift

@@ -0,0 +1,26 @@
+// RUN: %target-swift-frontend  %s -O -module-name=test -emit-sil | %FileCheck %s
+
+// REQUIRES: swift_stdlib_no_asserts,optimized_stdlib
+
+public protocol P {
+  func takePointer<T>(_ p: UnsafePointer<T>)
+}
+
+extension P {
+  @inline(__always)
+  func genericFunc<T>(_ x: inout T) {
+    withUnsafePointer(to: &x) {
+      takePointer($0)
+    }
+  }
+}
+
+// CHECK-LABEL: sil {{.*}}@$s4test6testityyAA1P_pF
+// CHECK-NOT:     function_ref
+// CHECK:         witness_method
+// CHECK:       } // end sil function '$s4test6testityyAA1P_pF' 
+public func testit(_ p: P) {
+  var x = 0
+  p.genericFunc(&x)
+}
+