Merge pull request #40237 from ktoso/wip-distributed-private

Author: swift-ci

include/swift/AST/DiagnosticsSema.def

@@ -4519,9 +4519,6 @@ ERROR(nonisolated_distributed_actor_storage,none,
 ERROR(distributed_actor_func_nonisolated, none,
       "cannot declare method %0 as both 'nonisolated' and 'distributed'",
       (DeclName))
-ERROR(distributed_actor_func_private, none,
-      "%0 %1 cannot be 'private'",
-      (DescriptiveDeclKind, DeclName))
 ERROR(distributed_actor_func_inout, none,
       "cannot declare 'inout' argument %0 in %1 %2",
       (DeclName, DescriptiveDeclKind, DeclName))

lib/Sema/TypeCheckDistributed.cpp

@@ -125,13 +125,6 @@ bool swift::checkDistributedFunction(FuncDecl *func, bool diagnose) {
 
   auto module = func->getParentModule();
 
-  if (func->getEffectiveAccess() == AccessLevel::FilePrivate) {
-    func->diagnose(diag::distributed_actor_func_private,
-                   func->getDescriptiveKind(), func->getName());
-    // TODO(distributed): fixit remove the 'private' from the declaration
-    return true;
-  }
-
   // --- Check parameters for 'Codable' conformance
   for (auto param : *func->getParameters()) {
     auto paramTy = func->mapTypeIntoContext(param->getInterfaceType());

test/Distributed/distributed_actor_isolation.swift

@@ -52,8 +52,6 @@ distributed actor DistributedActor_1 {
   // expected-error@-1{{class methods are only allowed within classes; use 'static' to declare a static method}}
   // expected-error@-2{{'distributed' method cannot be 'static'}} // TODO(distributed): should call out 'class' instead?
 
-  distributed private func distributedPrivate() {} //expected-error{{distributed instance method 'distributedPrivate()' cannot be 'private'}}
-
   func hello() {} // expected-note{{distributed actor-isolated instance method 'hello()' declared here}}
   func helloAsync() async {} // expected-note{{distributed actor-isolated instance method 'helloAsync()' declared here}}
   func helloAsyncThrows() async throws {} // expected-note{{distributed actor-isolated instance method 'helloAsyncThrows()' declared here}}