Fix trivial warnings emitted during a full build.

Author: tshortli

lib/SILOptimizer/Mandatory/MoveKillsCopyableValuesChecker.cpp

@@ -380,7 +380,6 @@ bool MoveKillsCopyableValuesChecker::check() {
   //
   // TODO: We should add llvm.dbg.addr support for fastisel and also teach
   // CodeGen how to handle llvm.dbg.addr better.
-  bool emittedDiagnostic = false;
   while (!valuesToProcess.empty()) {
     auto lexicalValue = valuesToProcess.front();
     valuesToProcess = valuesToProcess.drop_front(1);
@@ -416,7 +415,6 @@ bool MoveKillsCopyableValuesChecker::check() {
         if (livenessInfo.liveness.isWithinBoundary(mvi)) {
           LLVM_DEBUG(llvm::dbgs() << "    WithinBoundary: Yes!\n");
           emitDiagnosticForMove(lexicalValue, varName, mvi);
-          emittedDiagnostic = true;
         } else {
           LLVM_DEBUG(llvm::dbgs() << "    WithinBoundary: No!\n");
           if (auto varInfo = dbgVarInst.getVarInfo()) {

lib/SILOptimizer/SILCombiner/SILCombinerMiscVisitors.cpp

@@ -2259,7 +2259,6 @@ visitAllocRefDynamicInst(AllocRefDynamicInst *ARDI) {
     if (!use || use->getUser() != ARDI)
       return nullptr;
 
-    auto silTy = AI->getType();
     auto storageTy = AI->getType().getASTType();
     // getContiguousArrayStorageType<SomeClass> =>
     //   ContiguousArrayStorage<AnyObject>

stdlib/public/Distributed/DistributedActor.cpp

@@ -96,7 +96,7 @@ static DistributedAccessorSignature::ContinuationType
     swift_distributed_execute_target_resume;
 
 SWIFT_CC(swiftasync)
-static void ::swift_distributed_execute_target_resume(
+static void swift_distributed_execute_target_resume(
     SWIFT_ASYNC_CONTEXT AsyncContext *context,
     SWIFT_CONTEXT SwiftError *error) {
   auto parentCtx = context->Parent;
@@ -110,7 +110,7 @@ static void ::swift_distributed_execute_target_resume(
 }
 
 SWIFT_CC(swiftasync)
-void ::swift_distributed_execute_target(
+void swift_distributed_execute_target(
     SWIFT_ASYNC_CONTEXT AsyncContext *callerContext,
     DefaultActor *actor,
     const char *targetNameStart, size_t targetNameLength,

tools/swift-demangle-yamldump/swift-demangle-yamldump.cpp

@@ -154,9 +154,7 @@ static llvm::StringRef substrAfter(llvm::StringRef whole,
 static void demangle(llvm::raw_ostream &os, llvm::StringRef name,
                      swift::Demangle::Context &DCtx,
                      const swift::Demangle::DemangleOptions &options) {
-  bool hadLeadingUnderscore = false;
   if (name.startswith("__")) {
-    hadLeadingUnderscore = true;
     name = name.substr(1);
   }
   swift::Demangle::NodePointer pointer = DCtx.demangleSymbolAsNode(name);

tools/swift-stdlib-tool/swift-stdlib-tool.cpp

@@ -604,7 +604,7 @@ int parse_fat(int fd, off_t fsize, char *buffer, size_t size,
   magic = *(uint32_t *)buffer;
   if (magic == FAT_MAGIC || magic == FAT_CIGAM) {
     struct fat_header *fh;
-    uint32_t fat_magic, fat_nfat_arch;
+    uint32_t fat_nfat_arch;
     struct fat_arch *archs;
     uint32_t i;
 
@@ -613,7 +613,6 @@ int parse_fat(int fd, off_t fsize, char *buffer, size_t size,
     }
 
     fh = (struct fat_header *)buffer;
-    fat_magic = OSSwapBigToHostInt32(fh->magic);
     fat_nfat_arch = OSSwapBigToHostInt32(fh->nfat_arch);
 
     size_t fat_arch_size;
@@ -645,14 +644,10 @@ int parse_fat(int fd, off_t fsize, char *buffer, size_t size,
 
     for (i = 0; i < fat_nfat_arch; i++) {
       int ret;
-      uint32_t arch_cputype, arch_cpusubtype, arch_offset, arch_size,
-          arch_align;
+      uint32_t arch_offset, arch_size;
 
-      arch_cputype = OSSwapBigToHostInt32(archs[i].cputype);
-      arch_cpusubtype = OSSwapBigToHostInt32(archs[i].cpusubtype);
       arch_offset = OSSwapBigToHostInt32(archs[i].offset);
       arch_size = OSSwapBigToHostInt32(archs[i].size);
-      arch_align = OSSwapBigToHostInt32(archs[i].align);
 
       /* Check that slice data is after all fat headers and archs */
       if (arch_offset < fat_arch_size) {