Merge pull request #60553 from zoecarver/enum-fix-for-computed-props

[cxx-interop] Fix anonymous enum issue for swift-named computed prope…

Author: zoecarver

lib/ClangImporter/ImportDecl.cpp

@@ -5706,14 +5706,35 @@ SwiftDeclConverter::getImplicitProperty(ImportedName importedName,
   if (dc->isTypeContext() && !getterName.getSelfIndex())
     isStatic = true;
 
-  // Compute the property type.
-  bool isFromSystemModule = isInSystemModule(dc);
-  auto importedType = Impl.importType(
-      propertyType, ImportTypeKind::Property,
-      ImportDiagnosticAdder(Impl, getter, getter->getLocation()),
-      Impl.shouldAllowNSUIntegerAsInt(isFromSystemModule, getter),
-      Bridgeability::Full, getImportTypeAttrs(accessor),
-      OTK_ImplicitlyUnwrappedOptional);
+  ImportedType importedType;
+
+  // Sometimes we import unavailable typedefs as enums. If that's the case,
+  // use the enum, not the typedef here.
+  if (auto typedefType = dyn_cast<clang::TypedefType>(propertyType.getTypePtr())) {
+    if (Impl.isUnavailableInSwift(typedefType->getDecl())) {
+      if (auto clangEnum = findAnonymousEnumForTypedef(Impl.SwiftContext, typedefType)) {
+        // If this fails, it means that we need a stronger predicate for
+        // determining the relationship between an enum and typedef.
+        assert(clangEnum.getValue()->getIntegerType()->getCanonicalTypeInternal() ==
+               typedefType->getCanonicalTypeInternal());
+        if (auto swiftEnum = Impl.importDecl(*clangEnum, Impl.CurrentVersion)) {
+          importedType = {cast<NominalTypeDecl>(swiftEnum)->getDeclaredType(), false};
+        }
+      }
+    }
+  }
+
+  if (!importedType) {
+    // Compute the property type.
+    bool isFromSystemModule = isInSystemModule(dc);
+    importedType = Impl.importType(
+        propertyType, ImportTypeKind::Property,
+        ImportDiagnosticAdder(Impl, getter, getter->getLocation()),
+        Impl.shouldAllowNSUIntegerAsInt(isFromSystemModule, getter),
+        Bridgeability::Full, getImportTypeAttrs(accessor),
+        OTK_ImplicitlyUnwrappedOptional);
+  }
+
   if (!importedType)
     return nullptr;
 

test/Interop/Cxx/enum/Inputs/anonymous-with-swift-name.h

@@ -28,6 +28,14 @@ inline CFColorMask renameCFColorMask(ParentStruct parent)
     __attribute__((swift_name("ParentStruct.childFn(self:)")))
 { return kSOColorMaskRed; }
 
+inline CFColorMask getCFColorMask(ParentStruct parent)
+    __attribute__((swift_name("getter:ParentStruct.colorProp(self:)")))
+{ return kSOColorMaskRed; }
+
+inline void getCFColorMask(ParentStruct parent, CFColorMask newValue)
+    __attribute__((swift_name("setter:ParentStruct.colorProp(self:newValue:)")))
+{ }
+
 typedef __attribute__((availability(swift, unavailable))) __attribute__((swift_name("ParentStruct.NewName"))) unsigned OldName;
 
 enum __attribute__((flag_enum,enum_extensibility(open))) : OldName {

test/Interop/Cxx/enum/anonymous-with-swift-name.swift

@@ -44,4 +44,12 @@ AnonymousEnumsTestSuite.test("Parameter types") {
   expectEqual(all, .all)
 }
 
+AnonymousEnumsTestSuite.test("Computed properties") {
+  let parent = ParentStruct()
+
+  expectEqual(parent.colorProp, useCFColorMask(.red))
+  parent.colorProp = .green
+  expectEqual(parent.colorProp, useCFColorMask(.red))
+}
+
 runAllTests()