Merge pull request #66014 from nate-chandler/rdar109540863

[IRGen] Cast dynamic alloca to appropriate type.

Author: nate-chandler

lib/IRGen/GenFunc.cpp

@@ -2158,7 +2158,9 @@ Optional<StackAddress> irgen::emitFunctionPartialApplication(
     HeapNonFixedOffsets offsets(IGF, layout);
     if (outType->isNoEscape()) {
       stackAddr = IGF.emitDynamicAlloca(
-          IGF.IGM.Int8Ty, layout.isFixedLayout() ? layout.emitSize(IGF.IGM) : offsets.getSize() , Alignment(16));
+          IGF.IGM.Int8Ty,
+          layout.isFixedLayout() ? layout.emitSize(IGF.IGM) : offsets.getSize(),
+          Alignment(16));
       stackAddr = stackAddr->withAddress(IGF.Builder.CreateElementBitCast(
           stackAddr->getAddress(), IGF.IGM.OpaqueTy));
       data = stackAddr->getAddress().getAddress();

lib/IRGen/GenOpaque.cpp

@@ -578,8 +578,11 @@ StackAddress IRGenFunction::emitDynamicAlloca(llvm::Type *eltTy,
     // MaximumAlignment.
     byteCount = alignUpToMaximumAlignment(IGM.SizeTy, byteCount);
     auto address = emitTaskAlloc(byteCount, align);
-    return {address, address.getAddress()};
-  // In coroutines, call llvm.coro.alloca.alloc.
+    auto stackAddress = StackAddress{address, address.getAddress()};
+    stackAddress = stackAddress.withAddress(
+        Builder.CreateElementBitCast(stackAddress.getAddress(), eltTy));
+    return stackAddress;
+    // In coroutines, call llvm.coro.alloca.alloc.
   } else if (isCoroutine()) {
     // NOTE: llvm does not support dynamic allocas in coroutines.
 
@@ -603,7 +606,11 @@ StackAddress IRGenFunction::emitDynamicAlloca(llvm::Type *eltTy,
     auto ptr = Builder.CreateIntrinsicCall(llvm::Intrinsic::coro_alloca_get,
                                            {allocToken});
 
-    return {Address(ptr, IGM.Int8Ty, align), allocToken};
+    auto stackAddress =
+        StackAddress{Address(ptr, IGM.Int8Ty, align), allocToken};
+    stackAddress = stackAddress.withAddress(
+        Builder.CreateElementBitCast(stackAddress.getAddress(), eltTy));
+    return stackAddress;
   }
 
   // Otherwise, use a dynamic alloca.

validation-test/IRGen/rdar109540863.swift

@@ -0,0 +1,23 @@
+// RUN: %target-swift-frontend %s -disable-availability-checking -emit-ir | %FileCheck %s
+
+// REQUIRES: concurrency
+
+// CHECK: define {{.*}}@callee
+@_silgen_name("callee")
+func callee<each T : P>(_ ts: repeat each T) async {
+  (repeat (each ts).foo())
+}
+
+// CHECK: define {{.*}}@caller
+@_silgen_name("caller")
+func caller<each T1 : P>(t1: repeat each T1) async {
+  await callee(S(), repeat each t1)
+}
+
+struct S : P {
+  func foo() {
+  }
+}
+protocol P {
+  func foo()
+}