Add curl build product

Add libcurl as a build product. This is another piece required to build
foundation in a freestanding configuration.

Author: etcwilde

utils/build-script-impl

@@ -267,6 +267,7 @@ components=(
   libicu
   libxml2
   zlib
+  curl
   llbuild
   lldb
   llvm
@@ -2567,6 +2568,13 @@ for host in "${ALL_HOSTS[@]}"; do
                     )
                 fi
 
+                if [[ ! "${SKIP_BUILD_CURL}" ]]; then
+                    BASE_INSTALL_DIR="$(get_host_install_destdir ${host})"
+                    CURL_BUILD_ARGS=(
+                        -DCURL_DIR="${BASE_INSTALL_DIR}/usr/lib/cmake/CURL"
+                    )
+                fi
+
                 if [[ "${SKIP_CLEAN_FOUNDATION}" == "0" ]]
                 then
                   # The Swift project might have been changed, but CMake might
@@ -2597,6 +2605,8 @@ for host in "${ALL_HOSTS[@]}"; do
 
                   ${ZLIB_BUILD_ARGS[@]}
 
+                  ${CURL_BUILD_ARGS[@]}
+
                   -DFOUNDATION_PATH_TO_LIBDISPATCH_SOURCE=${LIBDISPATCH_SOURCE_DIR}
                   -DFOUNDATION_PATH_TO_LIBDISPATCH_BUILD=$(build_directory ${host} libdispatch)
                   -Ddispatch_DIR=$(build_directory ${host} libdispatch)/cmake/modules

utils/build_swift/build_swift/driver_arguments.py

@@ -96,6 +96,9 @@ def _apply_default_arguments(args):
     if args.zlib_build_variant is None:
         args.zlib_build_variant = args.build_variant
 
+    if args.curl_build_variant is None:
+        args.curl_build_variant = args.build_variant
+
     # Assertions are enabled by default.
     if args.assertions is None:
         args.assertions = True
@@ -721,6 +724,9 @@ def create_argument_parser():
     option('--static-zlib', toggle_true('build_zlib'), default=False,
            help='build static zlib')
 
+    option('--static-curl', toggle_true('build_curl'), default=False,
+           help='build static curl libraries')
+
     option('--playgroundsupport', toggle_true('build_playgroundsupport'),
            help='build PlaygroundSupport')
     option('--install-playgroundsupport',
@@ -840,6 +846,10 @@ def create_argument_parser():
            const='Debug',
            help='build the Debug variant of zlib')
 
+    option('--debug-curl', store('curl_build_variant'),
+           const='Debug',
+           help='build the Debug variant of libcurl')
+
     # -------------------------------------------------------------------------
     # Assertions group
 
@@ -1276,6 +1286,8 @@ def create_argument_parser():
            help='skip building libxml2')
     option('--skip-build-zlib', toggle_false('build_zlib'),
            help='skip building zlib')
+    option('--skip-build-curl', toggle_false('build_curl'),
+           help='skip building curl')
 
     # We need to list --skip-test-swift explicitly because otherwise argparse
     # will auto-expand arguments like --skip-test-swift to the only known
@@ -1356,6 +1368,7 @@ def create_argument_parser():
                      /icu                        (optional)
                      /libxml2                    (optional)
                      /zlib                       (optional)
+                     /curl                       (optional)
 
 SWIFT_BUILD_ROOT: a directory in which to create out-of-tree builds.
                   Defaults to "$SWIFT_SOURCE_ROOT/build/".

utils/build_swift/tests/expected_options.py

@@ -68,6 +68,7 @@
     'build_libicu': False,
     'build_libxml2': False,
     'build_zlib': False,
+    'build_curl': False,
     'build_linux': True,
     'build_llbuild': False,
     'build_lldb': False,
@@ -185,6 +186,7 @@
     'libicu_build_variant': 'Debug',
     'libxml2_build_variant': 'Debug',
     'zlib_build_variant': 'Debug',
+    'curl_build_variant': 'Debug',
     'bootstrapping_mode': None,
     'lit_args': '-sv',
     'llbuild_assertions': True,
@@ -435,6 +437,7 @@ class BuildScriptImplOption(_BaseOption):
     SetOption('--debug-libicu', dest='libicu_build_variant', value='Debug'),
     SetOption('--debug-libxml2', dest='libxml2_build_variant', value='Debug'),
     SetOption('--debug-zlib', dest='zlib_build_variant', value='Debug'),
+    SetOption('--debug-curl', dest='curl_build_variant', value='Debug'),
     SetOption('--debug-lldb', dest='lldb_build_variant', value='Debug'),
     SetOption('--lldb-build-with-xcode', dest='lldb_build_with_xcode',
               value='1'),
@@ -568,6 +571,7 @@ class BuildScriptImplOption(_BaseOption):
     EnableOption('--libicu', dest='build_libicu'),
     EnableOption('--static-libxml2', dest='build_libxml2'),
     EnableOption('--static-zlib', dest='build_zlib'),
+    EnableOption('--static-curl', dest='build_curl'),
     EnableOption('--indexstore-db', dest='build_indexstoredb'),
     EnableOption('--test-indexstore-db-sanitize-all',
                  dest='test_indexstoredb_sanitize_all'),
@@ -673,6 +677,7 @@ class BuildScriptImplOption(_BaseOption):
                   dest='build_clang_tools_extra'),
     DisableOption('--skip-build-libxml2', dest='build_libxml2'),
     DisableOption('--skip-build-zlib', dest='build_zlib'),
+    DisableOption('--skip-build-curl', dest='build_curl'),
 
     ChoicesOption('--compiler-vendor',
                   choices=['none', 'apple']),

utils/swift_build_support/swift_build_support/build_script_invocation.py

@@ -256,7 +256,8 @@ def convert_to_impl_arguments(self):
             (args.build_libdispatch, "libdispatch"),
             (args.build_libicu, "libicu"),
             (args.build_libxml2, 'libxml2'),
-            (args.build_zlib, 'zlib')
+            (args.build_zlib, 'zlib'),
+            (args.build_curl, 'curl')
         ]
         for (should_build, string_name) in conditional_subproject_configs:
             if not should_build and not self.args.infer_dependencies:
@@ -549,6 +550,9 @@ def compute_product_pipelines(self):
         builder.add_product(products.zlib.Zlib,
                             is_enabled=self.args.build_zlib)
 
+        builder.add_product(products.curl.LibCurl,
+                            is_enabled=self.args.build_curl)
+
         # Begin a build-script-impl pipeline for handling the compiler toolchain
         # and a subset of the tools that we build. We build these in this manner
         # to preserve current build-script-impl run behavior as we transition

utils/swift_build_support/swift_build_support/products/__init__.py

@@ -13,6 +13,7 @@
 from .backdeployconcurrency import BackDeployConcurrency
 from .benchmarks import Benchmarks
 from .cmark import CMark
+from .curl import LibCurl
 from .earlyswiftdriver import EarlySwiftDriver
 from .foundation import Foundation
 from .indexstoredb import IndexStoreDB
@@ -50,6 +51,7 @@
     'LibICU',
     'LibXML2',
     'Zlib',
+    'LibCurl',
     'LLBuild',
     'LLDB',
     'LLVM',

utils/swift_build_support/swift_build_support/products/curl.py

@@ -0,0 +1,131 @@
+# swift_build_support/products/curl.py ---------------------------------------
+#
+# This source file is part of the Swift.org open source project
+#
+# Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
+# Licensed under Apache License v2.0 with Runtime Library Exception
+#
+# See https://swift.org/LICENSE.txt for license information
+# See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+#
+# ----------------------------------------------------------------------------
+
+from . import cmake_product
+from . import zlib
+
+
+class LibCurl(cmake_product.CMakeProduct):
+    @classmethod
+    def is_build_script_impl_product(cls):
+        """is_build_script_impl_product -> bool
+
+        Whether this product is produced by build-script-impl
+        """
+        return False
+
+    @classmethod
+    def is_before_build_script_impl_product(cls):
+        """is_before_build_script_impl_product -> bool
+
+        Whether this product is built before any build-script-impl products
+        """
+        return True
+
+    @classmethod
+    def is_nondarwin_only_build_product(cls):
+        return True
+
+    @classmethod
+    def product_source_name(cls):
+        """product_source_name -> Bool
+
+        returns 'curl'
+        """
+        return "curl"
+
+    @classmethod
+    def get_dependencies(cls):
+        return [zlib.Zlib]
+
+    def should_build(self, host_target):
+        """should_build() -> Bool
+
+        Return True if curl should be built
+        """
+        return self.args.build_curl
+
+    def should_test(self, host_target):
+        """should_test() -> Bool
+
+        Returns True if curl should be tested.
+        Currently is set to false
+        """
+        return False
+
+    def should_install(self, host_target):
+        """should_install() -> Bool
+
+        Returns True
+        If we're building curl, you're going to need it
+        """
+        return self.args.build_curl
+
+    def install(self, host_target):
+        """
+        Install curl to the target location
+        """
+        path = self.host_install_destdir(host_target)
+        self.install_with_cmake(['install'], path)
+
+    def build(self, host_target):
+        self.cmake_options.define('BUILD_SHARED_LIBS', 'NO')
+        self.cmake_options.define('CMAKE_POSITION_INDEPENDENT_CODE', 'YES')
+
+        if self.args.curl_build_variant is None:
+            self.args.curl_build_variant = 'Release'
+        self.cmake_options.define('CMAKE_BUILD_TYPE:STRING',
+                                  self.args.curl_build_variant)
+        self.cmake_options.define('CMAKE_INSTALL_LIBDIR', 'lib')
+        self.cmake_options.define('CMAKE_INSTALL_PREFIX', '/usr')
+        self.cmake_options.define('BUILD_CURL_EXE', 'NO')
+        self.cmake_options.define('CMAKE_USE_OPENSSL', 'NO')
+        self.cmake_options.define('CURL_CA_PATH', 'none')
+        self.cmake_options.define('CMAKE_USE_SCHANNEL', 'NO')
+        self.cmake_options.define('CMAKE_USE_LIBSSH2', 'NO')
+        self.cmake_options.define('HAVE_POLL_FINE', 'NO')
+        self.cmake_options.define('CURL_DISABLE_LDAP', 'YES')
+        self.cmake_options.define('CURL_DISABLE_LDAPS', 'YES')
+        self.cmake_options.define('CURL_DISABLE_TELNET', 'YES')
+        self.cmake_options.define('CURL_DISABLE_DICT', 'YES')
+        self.cmake_options.define('CURL_DISABLE_FILE', 'YES')
+        self.cmake_options.define('CURL_DISABLE_TFTP', 'YES')
+        self.cmake_options.define('CURL_DISABLE_RTSP', 'YES')
+        self.cmake_options.define('CURL_DISABLE_PROXY', 'YES')
+        self.cmake_options.define('CURL_DISABLE_POP3', 'YES')
+        self.cmake_options.define('CURL_DISABLE_IMAP', 'YES')
+        self.cmake_options.define('CURL_DISABLE_SMTP', 'YES')
+        self.cmake_options.define('CURL_DISABLE_GOPHER', 'YES')
+        self.cmake_options.define('CURL_ZLIB', 'YES')
+        self.cmake_options.define('ENABLE_UNIX_SOCKETS', 'NO')
+        self.cmake_options.define('ENABLE_THREADED_RESOLVER', 'NO')
+
+        (platform, arch) = host_target.split('-')
+        common_c_flags = ' '.join(self.common_cross_c_flags(platform, arch))
+        self.cmake_options.define('CMAKE_C_FLAGS', common_c_flags)
+        self.cmake_options.define('CMAKE_CXX_FLAGS', common_c_flags)
+
+        if host_target.startswith("macosx") or \
+           host_target.startswith("iphone") or \
+           host_target.startswith("appletv") or \
+           host_target.startswith("watch"):
+            toolchain_file = self.generate_darwin_toolchain_file(platform, arch)
+            self.cmake_options.define('CMAKE_TOOLCHAIN_FILE:PATH', toolchain_file)
+        elif platform == "linux":
+            toolchain_file = self.generate_linux_toolchain_file(platform, arch)
+            self.cmake_options.define('CMAKE_TOOLCHAIN_FILE:PATH', toolchain_file)
+
+        if self.args.build_zlib:
+            # If we're building zlib, make cmake search in the built toolchain
+            toolchain_path = self.host_install_destdir(host_target)
+            self.cmake_options.define('CMAKE_FIND_ROOT_PATH', toolchain_path)
+        self.build_with_cmake(['libcurl'], self.args.curl_build_variant, [])

utils/swift_build_support/swift_build_support/products/foundation.py

@@ -11,6 +11,7 @@
 # ----------------------------------------------------------------------------
 
 from . import cmark
+from . import curl
 from . import libcxx
 from . import libdispatch
 from . import libicu
@@ -55,7 +56,8 @@ def get_dependencies(cls):
                 swift.Swift,
                 libdispatch.LibDispatch,
                 libxml2.LibXML2,
-                zlib.Zlib]
+                zlib.Zlib,
+                curl.LibCurl]
 
     @classmethod
     def is_nondarwin_only_build_product(cls):