[sil] Make SILType::getCategoryType() use getRawASTType() instead of getASTType().

gottesmm · gottesmm · commit ee7753c2f97c · 2022-07-11T12:28:46.000-07:00
The reason why this makes sense is that this method is attempting to return the
current SILType but with a different category. So using getASTType() here and by
mistake removing move only would break semantics. Additionally, not making this
change breaks the expectation that this API would be idempotent.
diff --git a/include/swift/SIL/SILType.h b/include/swift/SIL/SILType.h
@@ -151,7 +151,7 @@ class SILType {
 
   /// Returns the \p Category variant of this type.
   SILType getCategoryType(SILValueCategory Category) const {
-    return SILType(getASTType(), Category);
+    return SILType(getRawASTType(), Category);
   }
 
   /// Returns the variant of this type that matches \p Ty.getCategory()

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ class SILType {`
`151`	`151`
`152`	`152`	`/// Returns the \p Category variant of this type.`
`153`	`153`	`SILType getCategoryType(SILValueCategory Category) const {`
`154`		`- return SILType(getASTType(), Category);`
	`154`	`+ return SILType(getRawASTType(), Category);`
`155`	`155`	`}`
`156`	`156`
`157`	`157`	`/// Returns the variant of this type that matches \p Ty.getCategory()`