Merge pull request #80330 from hborla/nonisolated-unsafe-let

[Concurrency] Never treat `nonisolated(unsafe)` properties as actor isolated.

Author: hborla

lib/Sema/TypeCheckConcurrency.cpp

@@ -7539,9 +7539,19 @@ ActorIsolation swift::getActorIsolationForReference(ValueDecl *decl,
   // the access is outside the module or if the property type is not
   // 'Sendable'.
   //
+  // Note that this is only allowed for source compatibility reasons.
+  // It is generally invalid to write `nonisolated` on an actor `let`
+  // if the type of the property is not Sendable. However, older compilers
+  // used to allow this, so it's only an error in the Swift 6 language
+  // mode, and it is a warning in prior language modes.
+  //
   // FIXME: getActorIsolation(decl) should treat these as isolated.
   // FIXME: Expand this out to local variables?
   if (auto var = dyn_cast<VarDecl>(decl)) {
+    // 'nonisolated(unsafe)' opts out of actor isolation.
+    if (declIsolation.isNonisolatedUnsafe())
+      return declIsolation;
+
     auto *fromModule = fromDC->getParentModule();
     ActorReferenceResult::Options options = std::nullopt;
     if (varIsSafeAcrossActors(fromModule, var, declIsolation, std::nullopt, options) &&

test/Concurrency/nonisolated_rules.swift

@@ -166,3 +166,14 @@ final class KlassB: Sendable {
   // expected-error@+1 {{'nonisolated' cannot be applied to mutable stored properties}}
   nonisolated var test: Int = 1
 }
+
+class NotSendable {}
+
+@MainActor
+struct UnsafeInitialization {
+  nonisolated(unsafe) let ns: NotSendable
+
+  nonisolated init(ns: NotSendable) {
+    self.ns = ns // okay
+  }
+}