AST: Remove ModuleDecl parameter from checkRequirements()

Author: slavapestov

include/swift/AST/Requirement.h

@@ -241,8 +241,7 @@ checkRequirementsWithoutContext(ArrayRef<Requirement> requirements);
 /// Check if each requirement is satisfied after applying the given
 /// substitutions. The substitutions must replace all type parameters that
 /// appear in the requirement with concrete types or archetypes.
-CheckRequirementsResult checkRequirements(ModuleDecl *module,
-                                          ArrayRef<Requirement> requirements,
+CheckRequirementsResult checkRequirements(ArrayRef<Requirement> requirements,
                                           TypeSubstitutionFn substitutions,
                                           SubstOptions options = std::nullopt);
 

lib/AST/Requirement.cpp

@@ -327,12 +327,12 @@ swift::checkRequirementsWithoutContext(ArrayRef<Requirement> requirements) {
 }
 
 CheckRequirementsResult swift::checkRequirements(
-    ModuleDecl *module, ArrayRef<Requirement> requirements,
+    ArrayRef<Requirement> requirements,
     TypeSubstitutionFn substitutions, SubstOptions options) {
   SmallVector<Requirement, 4> substReqs;
   for (auto req : requirements) {
     substReqs.push_back(req.subst(substitutions,
-                              LookUpConformanceInModule(), options));
+                                  LookUpConformanceInModule(), options));
   }
 
   return checkRequirements(substReqs);

lib/Sema/AssociatedTypeInference.cpp

@@ -2844,7 +2844,7 @@ bool AssociatedTypeInference::checkCurrentTypeWitnesses(
                                sanitizedRequirements);
 
   switch (checkRequirements(
-      dc->getParentModule(), sanitizedRequirements,
+      sanitizedRequirements,
       QuerySubstitutionMap{substitutions}, options)) {
   case CheckRequirementsResult::RequirementFailure:
     ++NumSolutionStatesFailedCheck;
@@ -2892,7 +2892,7 @@ bool AssociatedTypeInference::checkConstrainedExtension(ExtensionDecl *ext) {
 
   SubstOptions options = getSubstOptionsWithCurrentTypeWitnesses();
   switch (checkRequirements(
-      dc->getParentModule(), ext->getGenericSignature().getRequirements(),
+      ext->getGenericSignature().getRequirements(),
       QueryTypeSubstitutionMap{subs}, options)) {
   case CheckRequirementsResult::Success:
   case CheckRequirementsResult::SubstitutionFailure:

lib/Sema/CSStep.cpp

@@ -681,7 +681,6 @@ bool IsDeclRefinementOfRequest::evaluate(Evaluator &evaluator,
     return false;
 
   auto result = checkRequirements(
-      declA->getDeclContext()->getParentModule(),
       genericSignatureB.getRequirements(),
       QueryTypeSubstitutionMap{ substMap });
 

lib/Sema/CodeSynthesis.cpp

@@ -778,7 +778,6 @@ createDesignatedInitOverride(ClassDecl *classDecl,
     // satisfied by the derived class. In this case, we don't want to inherit
     // this initializer; there's no way to call it on the derived class.
     auto checkResult = checkRequirements(
-        classDecl->getParentModule(),
         superclassCtorSig.getRequirements(),
         [&](Type type) -> Type {
           auto substType = type.subst(subMap);

lib/Sema/IDETypeCheckingRequests.cpp

@@ -167,12 +167,10 @@ static bool isExtensionAppliedInternal(const DeclContext *DC, Type BaseTy,
   if (isExtensionWithSelfBound(ED, BaseTypeProtocolDecl)) {
     return true;
   }
-  auto *module = DC->getParentModule();
   GenericSignature genericSig = ED->getGenericSignature();
   SubstitutionMap substMap = BaseTy->getContextSubstitutionMap(
       ED->getExtendedNominal());
-  return checkRequirements(module,
-                           genericSig.getRequirements(),
+  return checkRequirements(genericSig.getRequirements(),
                            QuerySubstitutionMap{substMap}) ==
          CheckRequirementsResult::Success;
 }
@@ -210,7 +208,6 @@ static bool isMemberDeclAppliedInternal(const DeclContext *DC, Type BaseTy,
 
   // The context substitution map for the base type fixes the declaration's
   // outer generic parameters.
-  auto *module = DC->getParentModule();
   auto substMap = BaseTy->getContextSubstitutionMap(
       VD->getDeclContext(), genericDecl->getGenericEnvironment());
 
@@ -221,8 +218,7 @@ static bool isMemberDeclAppliedInternal(const DeclContext *DC, Type BaseTy,
 
   // We treat substitution failure as success, to ignore requirements
   // that involve innermost generic parameters.
-  return checkRequirements(module,
-                           genericSig.getRequirements(),
+  return checkRequirements(genericSig.getRequirements(),
                            [&](SubstitutableType *type) -> Type {
                              auto *paramTy = cast<GenericTypeParamType>(type);
                              if (paramTy->getDepth() == innerDepth)

lib/Sema/TypeCheckAttr.cpp

@@ -3840,13 +3840,12 @@ TypeEraserHasViableInitRequest::evaluate(Evaluator &evaluator,
     // type conforming to the annotated protocol. We will check this by
     // substituting the protocol's Self type for the generic arg and check that
     // the requirements in the generic signature are satisfied.
-    auto *module = nominalTypeDecl->getParentModule();
     auto baseMap =
         typeEraser->getContextSubstitutionMap(nominalTypeDecl);
     QuerySubstitutionMap getSubstitution{baseMap};
 
     auto result = checkRequirements(
-          module, genericSignature.getRequirements(),
+          genericSignature.getRequirements(),
           [&](SubstitutableType *type) -> Type {
             if (type->isEqual(genericParamType))
               return protocol->getSelfTypeInContext();