[sil] Now that we are enforcing that pack_metadata insts are only allowed in LoweredSIL, update some tests by splitting them into their own Lowered file.

Author: gottesmm

test/SIL/Parser/pack_metadata.sil

@@ -1,5 +1,7 @@
 // RUN: %target-sil-opt -enable-sil-verify-all=true %s | %target-sil-opt -enable-sil-verify-all=true | %FileCheck %s
 
+sil_stage lowered
+
 // CHECK-LABEL: sil @markers : {{.*}} {
 // CHECK:         [[MARKER:%[^,]+]] = alloc_pack_metadata
 // CHECK:         dealloc_pack_metadata [[MARKER]]

test/SIL/verifier_failures.sil

@@ -1,4 +1,5 @@
 // RUN: %target-sil-opt -emit-sorted-sil -verify-continue-on-failure -o /dev/null %s 2>&1 | %FileCheck %s
+
 // REQUIRES: asserts
 
 sil_stage canonical
@@ -17,28 +18,3 @@ sil [ossa] @end_borrow_1_addr_alloc_stack : $@convention(thin) () -> () {
   %retval = tuple ()
   return %retval : $()
 }
-
-// CHECK-LABEL: Begin Error in function alloc_pack_metadata_before_tuple
-// CHECK:       SIL verification failed: Introduces instruction of kind which cannot emit on-stack pack metadata:
-// CHECK-LABEL: End Error in function alloc_pack_metadata_before_tuple
-sil @alloc_pack_metadata_before_tuple : $@convention(thin) () -> () {
-  %marker = alloc_pack_metadata $()
-  %retval = tuple ()
-  dealloc_pack_metadata %marker : $*()
-  return %retval : $()
-}
-
-// CHECK-LABEL: Begin Error in function dealloc_pack_metadata_with_bad_operand
-// CHECK:       SIL verification failed: stack dealloc does not match most recent stack alloc:
-// CHECK-LABEL: End Error in function dealloc_pack_metadata_with_bad_operand
-// CHECK-LABEL: Begin Error in function dealloc_pack_metadata_with_bad_operand
-// CHECK:       SIL verification failed: Must have alloc_pack_metadata operand
-// CHECK-LABEL: End Error in function dealloc_pack_metadata_with_bad_operand
-sil @dealloc_pack_metadata_with_bad_operand : $@convention(thin) <each T> () -> () {
-  %marker = alloc_pack_metadata $()
-  // To make the %marker legal.
-  %out = apply undef<Pack{repeat each T}>() : $@convention(thin) <each T>() -> ()
-  dealloc_pack_metadata %out : $()
-  %retval = tuple ()
-  return %retval : $()
-}

test/SIL/verifier_loweredsil_failures.sil

@@ -0,0 +1,34 @@
+// RUN: %target-sil-opt -emit-sorted-sil -verify-continue-on-failure -o /dev/null %s 2>&1 | %FileCheck %s
+
+// REQUIRES: asserts
+
+sil_stage lowered
+
+import Builtin
+
+class C {}
+
+// CHECK-LABEL: Begin Error in function alloc_pack_metadata_before_tuple
+// CHECK:       SIL verification failed: Introduces instruction of kind which cannot emit on-stack pack metadata:
+// CHECK-LABEL: End Error in function alloc_pack_metadata_before_tuple
+sil @alloc_pack_metadata_before_tuple : $@convention(thin) () -> () {
+  %marker = alloc_pack_metadata $()
+  %retval = tuple ()
+  dealloc_pack_metadata %marker : $*()
+  return %retval : $()
+}
+
+// CHECK-LABEL: Begin Error in function dealloc_pack_metadata_with_bad_operand
+// CHECK:       SIL verification failed: stack dealloc does not match most recent stack alloc:
+// CHECK-LABEL: End Error in function dealloc_pack_metadata_with_bad_operand
+// CHECK-LABEL: Begin Error in function dealloc_pack_metadata_with_bad_operand
+// CHECK:       SIL verification failed: Must have alloc_pack_metadata operand
+// CHECK-LABEL: End Error in function dealloc_pack_metadata_with_bad_operand
+sil @dealloc_pack_metadata_with_bad_operand : $@convention(thin) <each T> () -> () {
+  %marker = alloc_pack_metadata $()
+  // To make the %marker legal.
+  %out = apply undef<Pack{repeat each T}>() : $@convention(thin) <each T>() -> ()
+  dealloc_pack_metadata %out : $()
+  %retval = tuple ()
+  return %retval : $()
+}