Merge pull request #40319 from bnbarham/loc-leaks

[AST] Prevent memory leak when allocating `ExternalSourceLocs`

Author: bnbarham

include/swift/Basic/BasicSourceInfo.h

@@ -50,7 +50,7 @@ struct ExternalSourceLocs {
 
   unsigned BufferID = 0;
   SourceLoc Loc;
-  SmallVector<CharSourceRange, 4> DocRanges;
+  ArrayRef<CharSourceRange> DocRanges;
 };
 
 class BasicSourceFileInfo {

lib/AST/Decl.cpp

@@ -653,9 +653,14 @@ const ExternalSourceLocs *Decl::getSerializedLocs() const {
   auto *Result = getASTContext().Allocate<ExternalSourceLocs>();
   Result->BufferID = BufferID;
   Result->Loc = ResolveLoc(RawLocs->Loc);
-  for (auto &Range : RawLocs->DocRanges) {
-    Result->DocRanges.emplace_back(ResolveLoc(Range.first), Range.second);
+
+  auto DocRanges = getASTContext().AllocateUninitialized<CharSourceRange>(RawLocs->DocRanges.size());
+  for (auto I : indices(RawLocs->DocRanges)) {
+    auto &Range = RawLocs->DocRanges[I];
+    DocRanges[I] = CharSourceRange(ResolveLoc(Range.first), Range.second);
   }
+  Result->DocRanges = DocRanges;
+
   Context.setExternalSourceLocs(this, Result);
   return Result;
 }