[Volatile] Rename UnsafeVolatilePointer to VolatileMappedRegister, use 'unsafe' name in initializer

Author: kubamracek

stdlib/public/Volatile/Volatile.swift

@@ -23,14 +23,14 @@ import Swift
 /// or reordered with other volatile operations by the compiler. They may be
 /// reordered with non-volatile operations. For details, see
 /// <https://llvm.org/docs/LangRef.html#volatile-memory-accesses>.
-public struct UnsafeVolatilePointer<Pointee> {
+public struct VolatileMappedRegister<Pointee> {
   public var _rawPointer: Builtin.RawPointer
-  public init(bitPattern: UInt) {
-    _rawPointer = UnsafeRawPointer(bitPattern: bitPattern)!._rawValue
+  public init(unsafeBitPattern: UInt) {
+    _rawPointer = UnsafeRawPointer(bitPattern: unsafeBitPattern)!._rawValue
   }
 }
 
-extension UnsafeVolatilePointer where Pointee == UInt8 {
+extension VolatileMappedRegister where Pointee == UInt8 {
   /// Perform an 8-bit volatile load operation from the target pointer.
   ///
   /// Do not use for inter-thread synchronization.
@@ -48,7 +48,7 @@ extension UnsafeVolatilePointer where Pointee == UInt8 {
   }
 }
 
-extension UnsafeVolatilePointer where Pointee == UInt16 {
+extension VolatileMappedRegister where Pointee == UInt16 {
   /// Perform a 16-bit volatile load operation from the target pointer.
   ///
   /// Do not use for inter-thread synchronization.
@@ -66,7 +66,7 @@ extension UnsafeVolatilePointer where Pointee == UInt16 {
   }
 }
 
-extension UnsafeVolatilePointer where Pointee == UInt32 {
+extension VolatileMappedRegister where Pointee == UInt32 {
   /// Perform a 32-bit volatile load operation from the target pointer.
   ///
   /// Do not use for inter-thread synchronization.
@@ -84,7 +84,7 @@ extension UnsafeVolatilePointer where Pointee == UInt32 {
   }
 }
 
-extension UnsafeVolatilePointer where Pointee == UInt64 {
+extension VolatileMappedRegister where Pointee == UInt64 {
   /// Perform a 64-bit volatile load operation from the target pointer.
   ///
   /// Do not use for inter-thread synchronization.

test/Volatile/volatile-ir.swift

@@ -6,7 +6,7 @@
 import _Volatile
 
 public func test_uint8() -> UInt8 {
-  let p = UnsafeVolatilePointer<UInt8>(bitPattern: 0xf000baaa)
+  let p = VolatileMappedRegister<UInt8>(bitPattern: 0xf000baaa)
   p.store(42)
   return p.load()
 }
@@ -18,7 +18,7 @@ public func test_uint8() -> UInt8 {
 // CHECK: }
 
 public func test_uint16() -> UInt16 {
-  let p = UnsafeVolatilePointer<UInt16>(bitPattern: 0xf000baaa)
+  let p = VolatileMappedRegister<UInt16>(bitPattern: 0xf000baaa)
   p.store(42)
   return p.load()
 }
@@ -30,7 +30,7 @@ public func test_uint16() -> UInt16 {
 // CHECK: }
 
 public func test_uint32() -> UInt32 {
-  let p = UnsafeVolatilePointer<UInt32>(bitPattern: 0xf000baaa)
+  let p = VolatileMappedRegister<UInt32>(bitPattern: 0xf000baaa)
   p.store(42)
   return p.load()
 }
@@ -42,7 +42,7 @@ public func test_uint32() -> UInt32 {
 // CHECK: }
 
 public func test_uint64() -> UInt64 {
-  let p = UnsafeVolatilePointer<UInt64>(bitPattern: 0xf000baaa)
+  let p = VolatileMappedRegister<UInt64>(bitPattern: 0xf000baaa)
   p.store(42)
   return p.load()
 }

test/Volatile/volatile-repeat-loads.swift

@@ -6,7 +6,7 @@
 import _Volatile
 
 public func test_volatilepointer() -> UInt8 {
-  let p = UnsafeVolatilePointer<UInt8>(bitPattern: 0xf000baaa)
+  let p = VolatileMappedRegister<UInt8>(bitPattern: 0xf000baaa)
   p.store(42)
   let a = p.load()
   let b = p.load()