tests: fix memory_lifetime tests

verifier failures must be placed into memory_lifetime_failures.sil. Otherwise they won't be tested.

Author: eeckstein

test/SIL/memory_lifetime.sil

@@ -709,20 +709,3 @@ entry:
   return %retval : $()
 }
 
-// CHECK: SIL memory lifetime failure in @begin_apply_inout_destroy: memory is not initialized, but should be
-sil [ossa] @begin_apply_inout_no_destroy : $@convention(thin) () -> () {
-entry:
-  (%instance, %token) = begin_apply undef<Inner>() : $@yield_once @convention(thin) <U> () -> @yields @inout U
-  end_apply %token
-  %retval = tuple ()
-  return %retval : $()
-}
-
-// CHECK: SIL memory lifetime failure in @begin_apply_inout_aliasable_destroy: memory is not initialized, but should be
-sil [ossa] @begin_apply_inout_aliasable_no_destroy : $@convention(thin) () -> () {
-entry:
-  (%instance, %token) = begin_apply undef<Inner>() : $@yield_once @convention(thin) <U> () -> @yields @inout_aliasable U
-  end_apply %token
-  %retval = tuple ()
-  return %retval : $()
-}

test/SIL/memory_lifetime_failures.sil

@@ -756,3 +756,21 @@ entry:
   %retval = tuple ()
   return %retval : $()
 }
+
+// CHECK: SIL memory lifetime failure in @begin_apply_inout_destroy: memory is not initialized, but should be
+sil [ossa] @begin_apply_inout_no_destroy : $@convention(thin) () -> () {
+entry:
+  (%instance, %token) = begin_apply undef<Inner>() : $@yield_once @convention(thin) <U> () -> @yields @inout U
+  end_apply %token
+  %retval = tuple ()
+  return %retval : $()
+}
+
+// CHECK: SIL memory lifetime failure in @begin_apply_inout_aliasable_destroy: memory is not initialized, but should be
+sil [ossa] @begin_apply_inout_aliasable_no_destroy : $@convention(thin) () -> () {
+entry:
+  (%instance, %token) = begin_apply undef<Inner>() : $@yield_once @convention(thin) <U> () -> @yields @inout_aliasable U
+  end_apply %token
+  %retval = tuple ()
+  return %retval : $()
+}