Fix bug missing return in operator=

valeriyvan · valeriyvan · commit e5d772d824fe · 2022-12-19T13:37:15.000+02:00
diff --git a/include/swift/Basic/SuccessorMap.h b/include/swift/Basic/SuccessorMap.h
@@ -78,13 +78,15 @@ class SuccessorMap {
     clear();
     Root = other.Root;
     other.Root = nullptr;
+    return *this;
   }
 
   SuccessorMap(const SuccessorMap &other) : Root(copyTree(other.Root)) {}
   SuccessorMap &operator=(const SuccessorMap &other) {
     // TODO: this is clearly optimizable to re-use nodes.
     deleteTree(Root);
     Root = copyTree(other.Root);
+    return *this;
   }
 
   ~SuccessorMap() {

Original file line number	Diff line number	Diff line change
`@@ -78,13 +78,15 @@ class SuccessorMap {`
`78`	`78`	`clear();`
`79`	`79`	`Root = other.Root;`
`80`	`80`	`other.Root = nullptr;`
	`81`	`+ return *this;`
`81`	`82`	`}`
`82`	`83`
`83`	`84`	`SuccessorMap(const SuccessorMap &other) : Root(copyTree(other.Root)) {}`
`84`	`85`	`SuccessorMap &operator=(const SuccessorMap &other) {`
`85`	`86`	`// TODO: this is clearly optimizable to re-use nodes.`
`86`	`87`	`deleteTree(Root);`
`87`	`88`	`Root = copyTree(other.Root);`
	`89`	`+ return *this;`
`88`	`90`	`}`
`89`	`91`
`90`	`92`	`~SuccessorMap() {`