Merge pull request #40757 from slavapestov/originally-defined-in-opaque-result-type

ASTMangler: Respect @_originallyDefinedIn in mangleOpaqueTypeDecl()

Author: slavapestov

lib/AST/ASTMangler.cpp

@@ -831,9 +831,11 @@ std::string ASTMangler::mangleOpaqueTypeDecl(const OpaqueTypeDecl *decl) {
 }
 
 std::string ASTMangler::mangleOpaqueTypeDecl(const ValueDecl *decl) {
-  DWARFMangling = true;
   OptimizeProtocolNames = false;
-  return mangleDeclAsUSR(decl, MANGLING_PREFIX_STR);
+
+  beginMangling();
+  appendEntity(decl);
+  return finalize();
 }
 
 std::string ASTMangler::mangleGenericSignature(const GenericSignature sig) {

lib/AST/Decl.cpp

@@ -2943,7 +2943,9 @@ TypeRepr *ValueDecl::getOpaqueResultTypeRepr() const {
 
 OpaqueTypeDecl *ValueDecl::getOpaqueResultTypeDecl() const {
   if (getOpaqueResultTypeRepr() == nullptr) {
-    if (isa<ModuleDecl>(this))
+    if (!isa<VarDecl>(this) &&
+        !isa<FuncDecl>(this) &&
+        !isa<SubscriptDecl>(this))
       return nullptr;
     auto file = cast<FileUnit>(getDeclContext()->getModuleScopeContext());
     // Don't look up when the decl is from source, otherwise a cycle will happen.

test/ModuleInterface/Inputs/CoreVegetable.swift

@@ -0,0 +1,5 @@
+@available(macOS 10.8, *)
+@_originallyDefinedIn(module: "CoreSoup", macOS 10.10)
+public struct Vegetable {
+  public init() {}
+}

test/ModuleInterface/originally-defined-attr-opaque-result.swift

@@ -0,0 +1,25 @@
+// RUN: %empty-directory(%t)
+
+// RUN: %target-swift-frontend -typecheck -emit-module-interface-path %t/CoreVegetable.swiftinterface %S/Inputs/CoreVegetable.swift -disable-availability-checking -enable-library-evolution -swift-version 5
+// RUN: %target-swift-frontend -typecheck -emit-module-interface-path %t/CoreChef.swiftinterface -module-name CoreChef %s -I %t -disable-availability-checking -enable-library-evolution -swift-version 5 -DLIB
+
+// RUN: %FileCheck %s < %t/CoreChef.swiftinterface
+
+// REQUIRES: OS=macosx
+import CoreVegetable
+
+public protocol Soup {}
+
+public struct VegetableSoup : Soup {}
+
+public protocol Chef {
+  associatedtype Food
+
+  func cookSoup(_: Vegetable) -> Food
+}
+
+public struct SoupChef : Chef {
+  public func cookSoup(_: Vegetable) -> some Soup { VegetableSoup() }
+}
+
+// CHECK-LABEL: public typealias Food = @_opaqueReturnTypeOf("$s8CoreChef04SoupB0V04cookC0yQr0aC09VegetableVF", 0) __