Merge pull request #72544 from gottesmm/pr-9b9437a095cb67aaf6c9f66f9c77174865b39be3

[region-isolation] Wordsmith "{access,use} here could race".

Author: gottesmm

include/swift/AST/DiagnosticsSIL.def

@@ -930,7 +930,7 @@ NOTE(sil_referencebinding_inout_binding_here, none,
 //===----------------------------------------------------------------------===//
 
 NOTE(regionbasedisolation_maybe_race, none,
-     "access here could race", ())
+     "use here could race", ())
 ERROR(regionbasedisolation_unknown_pattern, none,
       "pattern that the region based isolation checker does not understand how to check. Please file a bug",
       ())

test/Concurrency/experimental_feature_strictconcurrency.swift

@@ -33,7 +33,7 @@ func iterate(stream: AsyncStream<Int>) async {
 
   // expected-region-isolation-warning @+3 {{transferring 'it' may cause a race}}
   // expected-region-isolation-note @+2 {{transferring disconnected 'it' to nonisolated callee could cause races in between callee nonisolated and local main actor-isolated uses}}
-  // expected-region-isolation-note @+1 {{access here could race}}
+  // expected-region-isolation-note @+1 {{use here could race}}
   while let element = await it.next() {
     print(element)
   }

test/Concurrency/sendable_checking.swift

@@ -282,7 +282,7 @@ func testNonSendableBaseArg() async {
 
   _ = await t.x
   // expected-warning @-1 {{non-sendable type 'NonSendable' passed in implicitly asynchronous call to main actor-isolated property 'x' cannot cross actor boundary}}
-  // expected-tns-note@-2 {{access here could race}}
+  // expected-tns-note@-2 {{use here could race}}
 }
 
 @available(SwiftStdlib 5.1, *)

test/Concurrency/transfernonsendable.sil

@@ -160,7 +160,7 @@ bb0:
   // expected-warning @-1 {{transferring value of non-Sendable type 'NonSendableKlass' from nonisolated context to global actor '<null>'-isolated context}}
   %useIndirect = function_ref @useIndirect : $@convention(thin) <τ_0_0> (@in_guaranteed τ_0_0) -> ()
   apply %useIndirect<NonSendableKlass>(%1) : $@convention(thin) <τ_0_0> (@in_guaranteed τ_0_0) -> ()
-  // expected-note @-1 {{access here could race}}
+  // expected-note @-1 {{use here could race}}
 
   destroy_addr %1 : $*NonSendableKlass
   dealloc_stack %1 : $*NonSendableKlass

test/Concurrency/transfernonsendable.swift

@@ -47,7 +47,7 @@ bb3:
   // expected-warning @-1 {{transferring value of non-Sendable type 'NonSendableKlass' from nonisolated context to global actor '<null>'-isolated context; later accesses could race}}
   %useKlass = function_ref @useKlass : $@convention(thin) (@guaranteed NonSendableKlass) -> ()
   apply %useKlass(%klass) : $@convention(thin) (@guaranteed NonSendableKlass) -> ()
-  // expected-note @-1 {{access here could race}}
+  // expected-note @-1 {{use here could race}}
   destroy_value %klass : $NonSendableKlass
   %9999 = tuple ()
   return %9999 : $()

test/Concurrency/transfernonsendable_asynclet.swift

@@ -96,7 +96,7 @@ private class NonSendableLinkedListNode<T> { // expected-complete-note 3{{}}
   // expected-tns-note @-1 {{transferring disconnected 'x' to nonisolated callee could cause races in between callee nonisolated and local global actor 'GlobalActor'-isolated uses}}
   // expected-complete-warning @-2 {{passing argument of non-sendable type 'NonSendableLinkedListNode<Int>' outside of global actor 'GlobalActor'-isolated context may introduce data races}}
 
-  useValue(x) // expected-tns-note {{access here could race}}
+  useValue(x) // expected-tns-note {{use here could race}}
 }
 
 private struct StructContainingValue { // expected-complete-note 2{{}}
@@ -112,7 +112,7 @@ private struct StructContainingValue { // expected-complete-note 2{{}}
   // expected-tns-note @-1 {{transferring disconnected 'x' to nonisolated callee could cause races in between callee nonisolated and local global actor 'GlobalActor'-isolated uses}}
   // expected-complete-warning @-2 {{passing argument of non-sendable type 'StructContainingValue' outside of global actor 'GlobalActor'-isolated context may introduce data races}}
 
-  useValue(x) // expected-tns-note {{access here could race}}
+  useValue(x) // expected-tns-note {{use here could race}}
 }
 
 @GlobalActor func useGlobalActor7() async {
@@ -135,7 +135,7 @@ private struct StructContainingValue { // expected-complete-note 2{{}}
   // expected-complete-warning @-2 {{passing argument of non-sendable type '(NonSendableLinkedList<Int>, NonSendableLinkedList<Int>)' outside of global actor 'GlobalActor'-isolated context may introduce data races}}
   // expected-complete-warning @-3 {{passing argument of non-sendable type '(NonSendableLinkedList<Int>, NonSendableLinkedList<Int>)' outside of global actor 'GlobalActor'-isolated context may introduce data races}}
 
-  useValue(x) // expected-tns-note {{access here could race}}
+  useValue(x) // expected-tns-note {{use here could race}}
 }
 
 @GlobalActor func useGlobalActor9() async {