Merge pull request #85014 from aviralg/aviralgoel/performance-hints/ensure-primary-source-file

artemcm · web-flow · commit e32692dca359 · 2025-11-01T00:58:52.000-04:00
[Performance Hints] Disable performance hints if typechecker can skip function bodies
diff --git a/lib/Sema/PerformanceHints.cpp b/lib/Sema/PerformanceHints.cpp
@@ -31,7 +31,8 @@
 using namespace swift;
 
 bool swift::performanceHintDiagnosticsEnabled(ASTContext &ctx) {
-  return !ctx.Diags.isIgnoredDiagnosticGroupTree(DiagGroupID::PerformanceHints);
+  return !ctx.Diags.isIgnoredDiagnosticGroupTree(DiagGroupID::PerformanceHints) &&
+         (ctx.TypeCheckerOpts.SkipFunctionBodies == FunctionBodySkipping::None);
 }
 
 namespace {

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,8 @@`
`31`	`31`	`using namespace swift;`
`32`	`32`
`33`	`33`	`bool swift::performanceHintDiagnosticsEnabled(ASTContext &ctx) {`
`34`		`- return !ctx.Diags.isIgnoredDiagnosticGroupTree(DiagGroupID::PerformanceHints);`
	`34`	`+ return !ctx.Diags.isIgnoredDiagnosticGroupTree(DiagGroupID::PerformanceHints) &&`
	`35`	`+ (ctx.TypeCheckerOpts.SkipFunctionBodies == FunctionBodySkipping::None);`
`35`	`36`	`}`
`36`	`37`
`37`	`38`	`namespace {`