[ConstraintSystem] getExpressionTooComplex should check the flag before computing anything

xedin · xedin · commit e2b475959cb3 · 2022-04-22T17:55:35.000-07:00
diff --git a/include/swift/Sema/ConstraintSystem.h b/include/swift/Sema/ConstraintSystem.h
@@ -5450,6 +5450,9 @@ class ConstraintSystem {
   }
 
   bool getExpressionTooComplex(SmallVectorImpl<Solution> const &solutions) {
+    if (isExpressionAlreadyTooComplex)
+      return true;
+
     size_t solutionMemory = 0;
     for (auto const& s : solutions) {
       solutionMemory += s.getTotalMemory();

Original file line number	Diff line number	Diff line change
`@@ -5450,6 +5450,9 @@ class ConstraintSystem {`
`5450`	`5450`	`}`
`5451`	`5451`
`5452`	`5452`	`bool getExpressionTooComplex(SmallVectorImpl<Solution> const &solutions) {`
	`5453`	`+ if (isExpressionAlreadyTooComplex)`
	`5454`	`+ return true;`
	`5455`	`+`
`5453`	`5456`	`size_t solutionMemory = 0;`
`5454`	`5457`	`for (auto const& s : solutions) {`
`5455`	`5458`	`solutionMemory += s.getTotalMemory();`